Skip to contentSkip to conversation

ARM: dts: imx6*-hummingboard: fix pcie reset GPIO specification

PATCH New Russell King 3 participants 3 messages Jan 27, 2016 – Feb 2, 2016

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Russell King

author
#0 lore raw

PATCH 3/3 ARM: dts: imx6*-hummingboard: fix pcie reset GPIO specification

PCIe reset signals are active low, and our GPIO for this is directly connected to the PCIe reset. However, as the PCIe driver does not use the flag, the specification of '0' flags (which means active high) has not been noticed. Correct this oversight, and switch to using the GPIO flag definitions instead.

Signed-off-by Russell King <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-hummingboard.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6qdl-hummingboard.dtsi +1 -1
index 3a06516fe7a9..258107246d64 100644
@@ -253,7 +253,7 @@
 &pcie {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_hummingboard_pcie_reset>;
-	reset-gpio = <&gpio3 4 0>;
+	reset-gpio = <&gpio3 4 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
Signature · 1 line
2.1.0
reviewer
#1 lore raw

PATCH 3/3 ARM: dts: imx6*-hummingboard: fix pcie reset GPIO specification

Quoted 4 lines · Russell King

PCIe reset signals are active low, and our GPIO for this is directly connected to the PCIe reset. However, as the PCIe driver does not use the flag, the specification of '0' flags (which means active high) has not been noticed. Correct this oversight, and switch to using the

Yes, the mx6 pci driver did not use the flag, but it does now since 5c5fb40de8f1 ("PCI: imx6: Add support for active-low reset GPIO"), so it would be better to adjust the commit log.

Apart from that, patch looks good.

#2 lore raw

PATCH 3/3 ARM: dts: imx6*-hummingboard: fix pcie reset GPIO specification

Quoted 10 lines · Fabio Estevam
Quoted 4 lines · Russell King

PCIe reset signals are active low, and our GPIO for this is directly connected to the PCIe reset. However, as the PCIe driver does not use the flag, the specification of '0' flags (which means active high) has not been noticed. Correct this oversight, and switch to using the

Yes, the mx6 pci driver did not use the flag, but it does now since 5c5fb40de8f1 ("PCI: imx6: Add support for active-low reset GPIO"), so it would be better to adjust the commit log.

I updated the commit log a bit and applied the series.

Shawn