Skip to contentSkip to conversation

rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

PATCH Superseded Byeoungwook Kim 3 participants 4 messages Feb 3, 2016

Subsystems (3)
Networking Network drivers Realtek wireless driver (rtlwifi family)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Byeoungwook Kim

author
#0 lore raw

PATCH v2 1/2 rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

Conditional codes in rtl_addr_delay() were improved in readability and performance by using switch codes.

Signed-off-by Byeoungwook Kim <[email protected]>
Reviewed-by Julian Calaby <[email protected]>

---
V2 split in separate patchs.

 drivers/net/wireless/realtek/rtlwifi/core.c | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)
drivers/net/wireless/realtek/rtlwifi/core.c +14 -6
index 4ae421e..05f432c 100644
@@ -37,18 +37,26 @@
 
 void rtl_addr_delay(u32 addr)
 {
-	if (addr == 0xfe)
+	switch (addr) {
+	case 0xfe:
 		mdelay(50);
-	else if (addr == 0xfd)
+		break;
+	case 0xfd:
 		mdelay(5);
-	else if (addr == 0xfc)
+		break;
+	case 0xfc:
 		mdelay(1);
-	else if (addr == 0xfb)
+		break;
+	case 0xfb:
 		udelay(50);
-	else if (addr == 0xfa)
+		break;
+	case 0xfa:
 		udelay(5);
-	else if (addr == 0xf9)
+		break;
+	case 0xf9:
 		udelay(1);
+		break;
+	};
 }
 EXPORT_SYMBOL(rtl_addr_delay);
Signature · 1 line
2.5.0
build bot
#1 lore raw

[PATCH] rtlwifi: fix semicolon.cocci warnings

drivers/net/wireless/realtek/rtlwifi/core.c:59:2-3: Unneeded semicolon

drivers/net/wireless/realtek/rtlwifi/core.c:59:2-3: Unneeded semicolon

Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

CC Byeoungwook Kim <[email protected]>
Signed-off-by Fengguang Wu <[email protected]>

---

 core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtlwifi/core.c +1 -1
@@ -56,7 +56,7 @@ void rtl_addr_delay(u32 addr)
 	case 0xf9:
 		udelay(1);
 		break;
-	};
+	}
 }
 EXPORT_SYMBOL(rtl_addr_delay);
Acked-by
#2 lore raw

Re: [PATCH] rtlwifi: fix semicolon.cocci warnings

Quoted 10 lines · kbuild test robot

drivers/net/wireless/realtek/rtlwifi/core.c:59:2-3: Unneeded semicolon

Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

CC Byeoungwook Kim <[email protected]>
Signed-off-by Fengguang Wu <[email protected]>

---

Acked-by Larry Finger <[email protected]>

Thanks,

Larry

Quoted 16 lines
  core.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtlwifi/core.c +1 -1
@@ -56,7 +56,7 @@ void rtl_addr_delay(u32 addr)
  	case 0xf9:
  		udelay(1);
  		break;
-	};
+	}
  }
  EXPORT_SYMBOL(rtl_addr_delay);
build bot
#3 lore raw
In reply to Byeoungwook Kim
coccinelle warnings: (new ones prefixed by >>)

Hi Byeoungwook,

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on v4.5-rc2 next-20160202]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Byeoungwook-Kim/rtlwifi-Fix-improve-function-rtl_addr_delay-in-core-c/20160203-101854
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master

coccinelle warnings: (new ones prefixed by >>)

>> drivers/net/wireless/realtek/rtlwifi/core.c:59:2-3: Unneeded semicolon

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation