staging: wilc1000: Move Macro definition
PATCH 1/1 staging: wilc1000: Move Macro definition
From: Hari Prasath Gujulan Elango <[email protected]>
This patch move's a macro defined in the middle of a structure definition to make it more readable.
--- drivers/staging/wilc1000/wilc_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wilc1000/wilc_sdio.c +1 -1
@@ -29,12 +29,12 @@ static const struct sdio_device_id wilc_sdio_ids[] = { };#define WILC_SDIO_BLOCK_SIZE 512 +#define MAX_NUN_INT_THRPT_ENH2 (5)/* Max num interrupts allowed in registers 0xf7, 0xf8 */ typedef struct {bool irq_gpio;u32 block_size;int nint; -#define MAX_NUN_INT_THRPT_ENH2 (5)/* Max num interrupts allowed in registers 0xf7, 0xf8 */ int has_thrpt_enh3; }wilc_sdio_t ;
Signature · 1 line
1.9.1
[email protected]
maintainerQuoted 15 lines · Hari Prasath (H.)
From: Hari Prasath Gujulan Elango <[email protected]>
This patch move's a macro defined in the middle of a structure definition to make it more readable.
Signed-off-by Hari Prasath Gujulan Elango <[email protected]>--- drivers/staging/wilc1000/wilc_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/wilc1000/wilc_sdio.c +0
-0
drivers/staging/wilc1000/wilc_sdio.c static const struct sdio_device_id wilc_sdio_ids[] = { · line 37
Quoted 10 lines
drivers/staging/wilc1000/wilc_sdio.c +1
-1@@ -29,12 +29,12 @@ static const struct sdio_device_id wilc_sdio_ids[] = { };#define WILC_SDIO_BLOCK_SIZE 512 +#define MAX_NUN_INT_THRPT_ENH2 (5)/* Max num interrupts allowed in registers 0xf7, 0xf8 */ typedef struct { bool irq_gpio; u32 block_size; int nint; -#define MAX_NUN_INT_THRPT_ENH2 (5) /* Max num interrupts allowed in registers 0xf7, 0xf8 */
No, this is a very common way to show that this define is for this field in the structure, please don't change that.
sorry,
greg k-h
Quoted 30 lines · On Wed, Feb 03, 2016 at 03:19:50PM -0800, [email protected] wrote:
Quoted 15 lines · Hari Prasath (H.)
From: Hari Prasath Gujulan Elango <[email protected]>
This patch move's a macro defined in the middle of a structure definition to make it more readable.
Signed-off-by Hari Prasath Gujulan Elango <[email protected]>--- drivers/staging/wilc1000/wilc_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/wilc1000/wilc_sdio.c +0
-0drivers/staging/wilc1000/wilc_sdio.c static const struct sdio_device_id wilc_sdio_ids[] = { · line 37
Quoted 10 lines
drivers/staging/wilc1000/wilc_sdio.c +1
-1@@ -29,12 +29,12 @@ static const struct sdio_device_id wilc_sdio_ids[] = { };#define WILC_SDIO_BLOCK_SIZE 512 +#define MAX_NUN_INT_THRPT_ENH2 (5)/* Max num interrupts allowed in registers 0xf7, 0xf8 */ typedef struct { bool irq_gpio; u32 block_size; int nint; -#define MAX_NUN_INT_THRPT_ENH2 (5) /* Max num interrupts allowed in registers 0xf7, 0xf8 */No, this is a very common way to show that this define is for this field in the structure, please don't change that.
Quoted 3 lines
sorry,
greg k-h
Thanks Greg,I got the message clear.Please discard this patch. Regards,
Hari