Skip to contentSkip to conversation

powerpc/885: set SDCR to 0x40

PATCH New Christophe Leroy 1 participant 1 message Feb 4, 2016 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/885: set SDCR to 0x40

The MPC885 reference manual says that SDCR shall have value 0x40, but most exemples set SDCR to 0x1
With 0x1 in SDCR, we observe TX underruns on SCC when using it in QMC mode.
According the NXP technical support, this is a copy/paste error from MPC860 reference manual, 0x40 being the only value supported by the MPC885 HW.

---
 arch/powerpc/sysdev/cpm1.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
arch/powerpc/sysdev/cpm1.c +4 -1
index 5e6ff38..8ed6536 100644
@@ -228,7 +228,10 @@ void __init cpm_reset(void)
 	 * Bit 25, FAM can also be set to use FEC aggressive mode (860T).
 	 */
 	siu_conf = immr_map(im_siu_conf);
-	out_be32(&siu_conf->sc_sdcr, 1);
+	if ((mfspr(SPRN_IMMR) & 0xffff) == 0x0900) /* MPC885 */
+		out_be32(&siu_conf->sc_sdcr, 0x40);
+	else
+		out_be32(&siu_conf->sc_sdcr, 1);
 	immr_unmap(siu_conf);
 
 	cpm_muram_init();
Signature · 1 line
2.1.0