Skip to contentSkip to conversation

drivers/perf: arm_pmu: make info messages more verbose

PATCH New Dirk Behme 2 participants 2 messages Feb 4, 2016 Arm PMU profiling and debugging

lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

PATCH v2 1/1 drivers/perf: arm_pmu: make info messages more verbose

On a big.LITTLE system e.g. with Cortex A57 and A53 in case not all cores are online at PMU probe time we might get

hw perfevents: failed to probe PMU!
hw perfevents: failed to register PMU devices!

making it unclear which cores failed, here.

Add the device tree full name which failed and the error value resulting in a more verbose and helpful message like

hw perfevents: /soc/pmu_a53: failed to probe PMU! Error -6 hw perfevents: /soc/pmu_a53: failed to register PMU devices! Error -6

---
Changes in v2: Use the full node name from DT instead of pmu->name, as if we fail to find anything in the match table, that'll be NULL. Additionally, add the error value to get an idea why it failed.

 drivers/perf/arm_pmu.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/perf/arm_pmu.c +4 -2
index 166637f..6fb63a3 100644
@@ -898,7 +898,8 @@ int arm_pmu_device_probe(struct platform_device *pdev,
 	}
 
 	if (ret) {
-		pr_info("failed to probe PMU!\n");
+		pr_info("%s: failed to probe PMU! Error %i\n",
+			node->full_name, ret);
 		goto out_free;
 	}
 
@@ -918,7 +919,8 @@ int arm_pmu_device_probe(struct platform_device *pdev,
 out_destroy:
 	cpu_pmu_destroy(pmu);
 out_free:
-	pr_info("failed to register PMU devices!\n");
+	pr_info("%s: failed to register PMU devices! Error %i\n",
+		node->full_name, ret);
 	kfree(pmu);
 	return ret;
 }
Signature · 1 line
2.5.1
#1 lore raw

PATCH v2 1/1 drivers/perf: arm_pmu: make info messages more verbose

Quoted 14 lines · Dirk Behme

On a big.LITTLE system e.g. with Cortex A57 and A53 in case not all cores are online at PMU probe time we might get

hw perfevents: failed to probe PMU!
hw perfevents: failed to register PMU devices!

making it unclear which cores failed, here.

Add the device tree full name which failed and the error value resulting in a more verbose and helpful message like

hw perfevents: /soc/pmu_a53: failed to probe PMU! Error -6 hw perfevents: /soc/pmu_a53: failed to register PMU devices! Error -6

Quoted 8 lines

---
Changes in v2: Use the full node name from DT instead of pmu->name, as if we fail to find anything in the match table, that'll be NULL. Additionally, add the error value to get an idea why it failed.

 drivers/perf/arm_pmu.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

This looks fine to me, but please can you rebase on top of my perf/updates branch [1] so that I can queue it?

Cheers,

Will

[1] https://git.kernel.org/cgit/linux/kernel/git/will/linux.git/log/?h=perf/updates