Skip to contentSkip to conversation

package/lirc-tools: not available on musl

PATCH New Bernd Kuhls 2 participants 2 messages Feb 5, 2016

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH v3 1/1 package/lirc-tools: not available on musl

GLOB_BRACE is not supported by the musl libc:
http://www.openwall.com/lists/musl/2013/09/16/1

Upstream correctly rejected the hack proposed by me:
http://patchwork.ozlabs.org/patch/576188/
http://sourceforge.net/p/lirc/tickets/174/#b087

Fixes
http://autobuild.buildroot.net/results/603/603c4426c47220808305a416f3d60fec2d8c02a3/
http://autobuild.buildroot.net/results/c08/c08abddeb5f0d0d1adec63ab4390562e3cfe1087/

Signed-off-by Bernd Kuhls <[email protected]>

---
v3: re-wrote the patch, lirc-tools is currently broken on musl (Arnout)
v2: re-formatted patch and sent upstream (Thomas)

 package/lirc-tools/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/lirc-tools/Config.in +4 -2
index a0fbbb8..3bee094 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_LIRC_TOOLS
 	bool "lirc-tools"
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_TOOLCHAIN_USES_MUSL # GLOB_BRACE
 	# dlopen()
 	depends on !BR2_STATIC_LIBS
 	help

@@ -17,6 +18,7 @@ config BR2_PACKAGE_LIRC_TOOLS
 
 	  http://www.lirc.org/
 
-comment "lirc-tools needs a toolchain w/ threads, dynamic library"
+comment "lirc-tools needs a uClibc or (e)glibc toolchain w/ threads, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \
+		|| BR2_TOOLCHAIN_USES_MUSL
Signature · 1 line
2.7.0
Applied
#1 lore raw

PATCH v3 1/1 package/lirc-tools: not available on musl

Dear Bernd Kuhls,

Quoted 7 lines · Bernd Kuhls

GLOB_BRACE is not supported by the musl libc:
http://www.openwall.com/lists/musl/2013/09/16/1

Upstream correctly rejected the hack proposed by me:
http://patchwork.ozlabs.org/patch/576188/
http://sourceforge.net/p/lirc/tickets/174/#b087

Quoted 8 lines

Fixes
http://autobuild.buildroot.net/results/603/603c4426c47220808305a416f3d60fec2d8c02a3/
http://autobuild.buildroot.net/results/c08/c08abddeb5f0d0d1adec63ab4390562e3cfe1087/

Signed-off-by Bernd Kuhls <[email protected]>

---
v3: re-wrote the patch, lirc-tools is currently broken on musl (Arnout)
v2: re-formatted patch and sent upstream (Thomas)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com