Skip to contentSkip to conversation

xl: use bool type for flags instead of int

PATCH In review Dario Faggioli 3 participants 3 messages Feb 6, 2016 – Feb 8, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xl: use bool type for flags instead of int

in schedulers' command handlers.

No functional change intended.

---
Cc: Ian Jackson <[email protected]>
Cc: Ian Campbell <[email protected]>
Cc: Wei Liu <[email protected]>
Cc: George Dunlap <[email protected]>

---
 tools/libxl/xl_cmdimpl.c |   27 +++++++++++++++------------
 1 file changed, 15 insertions(+), 12 deletions(-)
tools/libxl/xl_cmdimpl.c +15 -12
index 20704d2..d07ccb2 100644
@@ -6035,9 +6035,11 @@ int main_sched_credit(int argc, char **argv)
 {
     const char *dom = NULL;
     const char *cpupool = NULL;
-    int weight = 256, cap = 0, opt_w = 0, opt_c = 0;
-    int opt_s = 0;
-    int tslice = 0, opt_t = 0, ratelimit = 0, opt_r = 0;
+    int weight = 256, cap = 0;
+    int tslice = 0, ratelimit = 0;
+    bool opt_w = false, opt_c = false;
+    bool opt_t = false, opt_r = false;
+    bool opt_s = false;
     int opt, rc;
     static struct option opts[] = {
         {"domain", 1, 0, 'd'},
@@ -6056,22 +6058,22 @@ int main_sched_credit(int argc, char **argv)
         break;
     case 'w':
         weight = strtol(optarg, NULL, 10);
-        opt_w = 1;
+        opt_w = true;
         break;
     case 'c':
         cap = strtol(optarg, NULL, 10);
-        opt_c = 1;
+        opt_c = true;
         break;
     case 't':
         tslice = strtol(optarg, NULL, 10);
-        opt_t = 1;
+        opt_t = true;
         break;
     case 'r':
         ratelimit = strtol(optarg, NULL, 10);
-        opt_r = 1;
+        opt_r = true;
         break;
     case 's':
-        opt_s = 1;
+        opt_s = true;
         break;
     case 'p':
         cpupool = optarg;
@@ -6157,7 +6159,8 @@ int main_sched_credit2(int argc, char **argv)
 {
     const char *dom = NULL;
     const char *cpupool = NULL;
-    int weight = 256, opt_w = 0;
+    int weight = 256;
+    bool opt_w = false;
     int opt, rc;
     static struct option opts[] = {
         {"domain", 1, 0, 'd'},
@@ -6172,7 +6175,7 @@ int main_sched_credit2(int argc, char **argv)
         break;
     case 'w':
         weight = strtol(optarg, NULL, 10);
-        opt_w = 1;
+        opt_w = true;
         break;
     case 'p':
         cpupool = optarg;
@@ -6246,11 +6249,11 @@ int main_sched_rtds(int argc, char **argv)
         break;
     case 'p':
         period = strtol(optarg, NULL, 10);
-        opt_p = 1;
+        opt_p = true;
         break;
     case 'b':
         budget = strtol(optarg, NULL, 10);
-        opt_b = 1;
+        opt_b = true;
         break;
     case 'c':
         cpupool = optarg;
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Dario Faggioli

in schedulers' command handlers.

No functional change intended.

Quoted 90 lines

---
Cc: Ian Jackson <[email protected]>
Cc: Ian Campbell <[email protected]>
Cc: Wei Liu <[email protected]>
Cc: George Dunlap <[email protected]>

---
 tools/libxl/xl_cmdimpl.c |   27 +++++++++++++++------------
 1 file changed, 15 insertions(+), 12 deletions(-)
tools/libxl/xl_cmdimpl.c +15 -12
index 20704d2..d07ccb2 100644
@@ -6035,9 +6035,11 @@ int main_sched_credit(int argc, char **argv)
 {
     const char *dom = NULL;
     const char *cpupool = NULL;
-    int weight = 256, cap = 0, opt_w = 0, opt_c = 0;
-    int opt_s = 0;
-    int tslice = 0, opt_t = 0, ratelimit = 0, opt_r = 0;
+    int weight = 256, cap = 0;
+    int tslice = 0, ratelimit = 0;
+    bool opt_w = false, opt_c = false;
+    bool opt_t = false, opt_r = false;
+    bool opt_s = false;
     int opt, rc;
     static struct option opts[] = {
         {"domain", 1, 0, 'd'},
@@ -6056,22 +6058,22 @@ int main_sched_credit(int argc, char **argv)
         break;
     case 'w':
         weight = strtol(optarg, NULL, 10);
-        opt_w = 1;
+        opt_w = true;
         break;
     case 'c':
         cap = strtol(optarg, NULL, 10);
-        opt_c = 1;
+        opt_c = true;
         break;
     case 't':
         tslice = strtol(optarg, NULL, 10);
-        opt_t = 1;
+        opt_t = true;
         break;
     case 'r':
         ratelimit = strtol(optarg, NULL, 10);
-        opt_r = 1;
+        opt_r = true;
         break;
     case 's':
-        opt_s = 1;
+        opt_s = true;
         break;
     case 'p':
         cpupool = optarg;
@@ -6157,7 +6159,8 @@ int main_sched_credit2(int argc, char **argv)
 {
     const char *dom = NULL;
     const char *cpupool = NULL;
-    int weight = 256, opt_w = 0;
+    int weight = 256;
+    bool opt_w = false;
     int opt, rc;
     static struct option opts[] = {
         {"domain", 1, 0, 'd'},
@@ -6172,7 +6175,7 @@ int main_sched_credit2(int argc, char **argv)
         break;
     case 'w':
         weight = strtol(optarg, NULL, 10);
-        opt_w = 1;
+        opt_w = true;
         break;
     case 'p':
         cpupool = optarg;
@@ -6246,11 +6249,11 @@ int main_sched_rtds(int argc, char **argv)
         break;
     case 'p':
         period = strtol(optarg, NULL, 10);
-        opt_p = 1;
+        opt_p = true;
         break;
     case 'b':
         budget = strtol(optarg, NULL, 10);
-        opt_b = 1;
+        opt_b = true;
         break;
     case 'c':
         cpupool = optarg;