net: Wrong Initialization in davinci-emac driver
PATCH v3 1/1 net: Wrong Initialization in davinci-emac driver
Author: Vishwas Srivastava <[email protected]> Date: Mon Jan 25 21:28:17 2016 +0530
Wrong Initialization in davinci emac driver
emac module of the davinci platform supports only 8 tx and 8 rx channels (total 16). emac driver for davinci platform, however, while doing initialization of the dma descriptor head pointers,wrongly initializes the 16 head pointers (instead of 8) for tx dma and 16 head pointers(insted of 8) for rx dma, which is wrong.The result is, that this register initilization spills over the other registers which was not intended and is undesirable.This patch fixes this problem.
Changes for v2:
-cleaned up the style format
-addressed various comments given by Joe <[email protected]> on the first version of the patch.
Changes for v3:
- Added the missing patch part of v2
drivers/net/davinci_emac.c +0 -0
@@ -459,11 +459,11 @@ static int davinci_eth_open(struct eth_device *dev,
bd_t *bis)
/* Set DMA 8 TX / 8 RX Head pointers to 0 */
addr = &adap_emac->TX0HDP;
- for(cnt = 0; cnt < 16; cnt++)
+ for (cnt = 0; cnt < 8; cnt++)
writel(0, addr++);
addr = &adap_emac->RX0HDP;
- for(cnt = 0; cnt < 16; cnt++)
+ for (cnt = 0; cnt < 8; cnt++)
writel(0, addr++);
/* Clear Statistics (do this before setting MacControl register) */Quoted 110 lines · Vishwas Srivastava
Author: Vishwas Srivastava <[email protected]> Date: Mon Jan 25 21:28:17 2016 +0530Wrong Initialization in davinci emac driver
emac module of the davinci platform supports only 8 tx and 8 rx channels (total 16). emac driver for davinci platform, however, while doing initialization of the dma descriptor head pointers,wrongly initializes the 16 head pointers (instead of 8) for tx dma and 16 head pointers(insted of 8) for rx dma, which is wrong.The result is, that this register initilization spills over the other registers which was not intended and is undesirable.This patch fixes this problem.
Changes for v2:
-cleaned up the style format
-addressed various comments given by Joe <[email protected]> on the first version of the patch.Signed-off-by Vishwas Srivastava <[email protected]>CC Joe Hershberger <[email protected]>Acked-by Joe Hershberger <[email protected]>drivers/net/davinci_emac.c +1
-1@@ -459,11 +459,11 @@ static int davinci_eth_open(struct eth_device *dev, bd_t *bis)/* Set DMA 8 TX / 8 RX Head pointers to 0 */ addr = &adap_emac->TX0HDP; -for (cnt =0 ; cnt <16 ; cnt++) +for (cnt =0 ; cnt <8 ; cnt++)writel (0 , addr++);Quoted 68 lines · Joe Hershberger
Quoted 2 lines · Vishwas Srivastava
Author: Vishwas Srivastava <[email protected]> Date: Mon Jan 25 21:28:17 2016 +0530Please fix the patch subject. No Leading colon.
Quoted 12 lines
Wrong Initialization in davinci emac driver
emac module of the davinci platform supports only 8 tx and 8 rx channels (total 16). emac driver for davinci platform, however, while doing initialization of the dma descriptor head pointers,wrongly initializes the 16 head pointers (instead of 8) for tx dma and 16 head pointers for rx dma, which is wrong.The result is, that this register initilization spills over the other registers which was not intended and is undesirable.This patch fixes this problem.
Quoted 3 lines
Signed-off-by Vishwas Srivastava <[email protected]>CC Sergey Kubushyn <[email protected]>;Joe Hershberger <joe.hershberger at ni.com>
Please fix this formatting. One "Cc:" per line.
Quoted 1 line
Signed-off-by Vishwas Srivastava <[email protected]>Don't specify this twice.
drivers/net/davinci_emac.c static int davinci_eth_open(struct eth_device
Quoted 6 lines
drivers/net/davinci_emac.c +0
-0@@ -459,11 +459,11 @@ static int davinci_eth_open(struct eth_device*dev,
drivers/net/davinci_emac.c static int davinci_eth_open(struct eth_device · line 459
Quoted 1 line
drivers/net/davinci_emac.c +0
-0bd_t *bis)This line wrap is corrupt. The patch won't apply cleanly.
drivers/net/davinci_emac.c static int davinci_eth_open(struct eth_device · line 469
Quoted 13 lines
drivers/net/davinci_emac.c +2
-2/* Set DMA 8 TX / 8 RX Head pointers to 0 */ addr = &adap_emac->TX0HDP; -for (cnt =0 ; cnt <16 ; cnt++) +for (cnt =0 ; cnt <8 ; cnt++)writel (0 , addr++); addr = &adap_emac->RX0HDP; -for (cnt =0 ; cnt <16 ; cnt++) +for (cnt =0 ; cnt <8 ; cnt++)writel (0 , addr++);/* Clear Statistics (do this before setting MacControl register) */
This line was corrupted by patchwork. You are doing something wrong.
Quoted 4 lines
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-bootPlease correct all these issues, but for the content of the patch, still Acked.
Thanks,
-Joe
PATCH v3 1/1 net: Wrong Initialization in davinci-emac driver
Hello Vishwas,
Quoted 2 lines · Vishwas Srivastava
Author: Vishwas Srivastava <[email protected]> Date: Mon Jan 25 21:28:17 2016 +0530
This is unneeded in the commit message, as the author and date are already provided in the mail.
Quoted 1 line
Wrong Initialization in davinci emac driver
This is the title of the patch and does not need to be repeated.
Quoted 7 lines
Changes for v2:
-cleaned up the style format
-addressed various comments given by Joe <[email protected]> on the first version of the patch.Changes for v3:
- Added the missing patch part of v2
Changes should not be part of the commit message; they should appear after the '---' line which, by the way, is completely missing here, along with some lines at the start of the patch ; and changes should start with the most recent change first.
Also, you are quoting the previous patch, which is unneeded.
It seems like you put this e-mail together from the output of a manual diff rather than producing it with git send-email or patman. I suggest re-sending (under v3 to avoid confusion) using patman, which would ease the work of formatting the mail and managing patch versions.
Amicalement,
Signature · 1 line
Albert.
PATCH 1/1 net: fix wrong initialization in davinci-emac driver
In reply to Vishwas SrivastavaFrom: Vishwas Srivastava <[email protected]>
emac module of the davinci platform supports only 8 tx and 8 rx channels (total 16). emac driver for davinci platform, however, while doing initialization of the dma descriptor head pointers, wrongly initializes the 16 head pointers (instead of 8) for tx dma and 16 head pointers (insted of 8) for rx dma, which is wrong. The result is, that this register initilization spills over the other registers which was not intended and is undesirable. This patch fixes this problem.
---
Changes for v4:
- slightly edit the commit message
- prepare properly formated patch
Changes for v3:
- Added the missing patch part of v2
Changes for v2:
- cleaned up the style format
- addressed various comments given by Joe
drivers/net/davinci_emac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/davinci_emac.c +2 -2
@@ -459,11 +459,11 @@ static int davinci_eth_open(struct eth_device *dev, bd_t *bis)/* Set DMA 8 TX / 8 RX Head pointers to 0 */ addr = &adap_emac->TX0HDP; -for (cnt =0 ; cnt <16 ; cnt++) +for (cnt =0 ; cnt <8 ; cnt++)writel (0 , addr++); addr = &adap_emac->RX0HDP; -for (cnt =0 ; cnt <16 ; cnt++) +for (cnt =0 ; cnt <8 ; cnt++)writel (0 , addr++);/* Clear Statistics (do this before setting MacControl register) */
Signature · 1 line
1.7.9.5
PATCH 1/1 net: fix wrong initialization in davinci-emac driver
Quoted 24 lines · On Sat, 6 Feb 2016 15:28:26 +0100 Anatolij Gustschin agust at denx.de wrote:
From: Vishwas Srivastava <[email protected]>
emac module of the davinci platform supports only 8 tx and 8 rx channels (total 16). emac driver for davinci platform, however, while doing initialization of the dma descriptor head pointers, wrongly initializes the 16 head pointers (instead of 8) for tx dma and 16 head pointers (insted of 8) for rx dma, which is wrong. The result is, that this register initilization spills over the other registers which was not intended and is undesirable. This patch fixes this problem.
Signed-off-by Vishwas Srivastava <[email protected]>CC Joe Hershberger <[email protected]>Acked-by Joe Hershberger <[email protected]>Signed-off-by Anatolij Gustschin <[email protected]>---
Changes for v4:
- slightly edit the commit message
- prepare properly formated patchChanges for v3:
- Added the missing patch part of v2
Quoted 6 lines
Changes for v2:
- cleaned up the style format
- addressed various comments given by Joedrivers/net/davinci_emac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to u-boot-staging, thanks!
--
Anatolij