Skip to contentSkip to conversation

Staging: speakup: Fix allyesconfig build on mn10300

PATCH In review Samuel Thibault 3 participants 5 messages Feb 1, 2016 – Feb 7, 2016 Staging

lore
Share & tools
lore

Samuel Thibault

author
#0 lore raw

PATCH 1/1 Staging: speakup: Fix allyesconfig build on mn10300

mn10300 uses an mmio-driven uart. This is not supported by speakup, so prevent from enabling it.

Signed-off-by Samuel Thibault <[email protected]>
drivers/staging/speakup/Kconfig +1 -1
@@ -1,7 +1,7 @@
 menu "Speakup console speech"
 
 config SPEAKUP
-	depends on VT
+	depends on VT && !MN10300
 	tristate "Speakup core"
 	---help---
 		This is the Speakup screen reader.  Think of it as a
maintainer
#1 lore raw

drivers/staging/speakup/Kconfig line 4

Quoted 13 lines · Samuel Thibault

mn10300 uses an mmio-driven uart. This is not supported by speakup, so prevent from enabling it.

Signed-off-by Samuel Thibault <[email protected]>
drivers/staging/speakup/Kconfig +1 -1
@@ -1,7 +1,7 @@
 menu "Speakup console speech"
 
 config SPEAKUP
-	depends on VT
+	depends on VT && !MN10300

Heh, that's funny. I'll go queue this up, thanks for the patch.

greg k-h

#2 lore raw
In reply to Samuel Thibault

Hi Samuel,

Quoted 2 lines · Samuel Thibault

mn10300 uses an mmio-driven uart. This is not supported by speakup, so prevent from enabling it.

Just wondering, what are the symptoms of the failure? Is it a compile-time or run-time failure?

Is this about drivers/staging/speakup/serialio.c?
I guess there are many other platforms where the UART is MMIO-driven...

drivers/staging/speakup/Kconfig line 7

Quoted 13 lines
Signed-off-by Samuel Thibault <[email protected]>
drivers/staging/speakup/Kconfig +1 -1
@@ -1,7 +1,7 @@
 menu "Speakup console speech"
 
 config SPEAKUP
-       depends on VT
+       depends on VT && !MN10300
        tristate "Speakup core"
        ---help---
                This is the Speakup screen reader.  Think of it as a

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

author
#3 lore raw
Quoted 6 lines · Geert Uytterhoeven, on Sun 07 Feb 2016 10:18:46 +0100, wrote:
Quoted 2 lines · Samuel Thibault

mn10300 uses an mmio-driven uart. This is not supported by speakup, so prevent from enabling it.

Just wondering, what are the symptoms of the failure?

It'll try to request the 0x00-0x08 ports and fail, returning -ENODEV.

Quoted 1 line

Is it a compile-time or run-time failure?

The fix is for compile-time. run-time failure will already return -ENODEV.

Quoted 1 line

Is this about drivers/staging/speakup/serialio.c?

Yes.

This code is to be replaced anyway.

Samuel

author
#4 lore raw
In reply to Geert Uytterhoeven
Quoted 1 line · Geert Uytterhoeven, on Sun 07 Feb 2016 10:18:46 +0100, wrote:

I guess there are many other platforms where the UART is MMIO-driven...

Actually they can't ever get to be exposed to speakup's serialio.c:
their SERIAL_PORT_DFNS would set SERIAL_IO_MEM in the io_type field, but that field doesn't even exist in serialio.c's old_serial_port, so serialio.c would actually not even build, so we are on the safe side.

Samuel