package/musepack: fix musl build
PATCH 1/1 package/musepack: fix musl build
Fixes
http://autobuild.buildroot.net/results/6eb/6ebc9cbee3fc48f4f5b658d11b040ad62fb6607f/
--- package/musepack/0003-musl.patch | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 package/musepack/0003-musl.patch
package/musepack/0003-musl.patch new file +24 -0
@@ -0,0 +1,24 @@ +Fix musl build + +Signed-off-by: Bernd Kuhls <[email protected]> + +diff -uNr musepack_src_r475.org/mpcenc/mpcenc.h musepack_src_r475/mpcenc/mpcenc.h +--- musepack_src_r475.org/mpcenc/mpcenc.h 2009-02-23 19:15:46.000000000 +0100 ++++ musepack_src_r475/mpcenc/mpcenc.h 2016-01-30 09:29:08.000000000 +0100 +@@ -34,6 +34,7 @@ + //// portable system includes ////////////////////////////////////// + #include <stddef.h> + #include <math.h> ++#include <sys/select.h> + + //// system dependent system includes ////////////////////////////// + // low level I/O, where are prototypes and constants? +@@ -50,7 +51,7 @@ + # include <unistd.h> + #endif + +-#if defined __linux__ ++#if defined __GLIBC__ + # include <fpu_control.h> + #elif defined __FreeBSD__ + # include <machine/floatingpoint.h>
Signature · 1 line
2.7.0.rc3
PATCH 1/1 package/musepack: fix musl build
Dear Bernd Kuhls,
Quoted 8 lines · Bernd Kuhls
Fixes
http://autobuild.buildroot.net/results/6eb/6ebc9cbee3fc48f4f5b658d11b040ad62fb6607f/Signed-off-by Bernd Kuhls <[email protected]>--- package/musepack/0003-musl.patch | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 package/musepack/0003-musl.patch
I've applied, but to be honest, I almost rejected your patch:
1/ The musepack patch does two completely different things, they
should have been two separate patches.
2/ "Fix musl" is not a proper patch description. Due to this, I have
to dig myself again in the issue, to understand what was the problem, and how your patch fixes it. Please add a proper description to each and every patch. "Fix musl" is *not* a good description.
See
https://git.busybox.net/buildroot/commit/package/musepack?id=5f3aed3f50ff48c8a60185407d7220aeedfea5e5
for the type of description that we need to have.
Don't get me wrong: I definitely appreciate your effort to fix numerous musl build failures. But with such short descriptions, I have to basically re-do all the investigation you have already done... which means I spend as much time as you have done. Could you please help by writing longer patch descriptions ?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com