Skip to contentSkip to conversation

staging: dgnc: convert to wait_event_interruptible_timeout

PATCH New Gujulan Elango, Hari Prasath (H.) 1 participant 1 message Feb 8, 2016 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: dgnc: convert to wait_event_interruptible_timeout

From: Hari Prasath Gujulan Elango <[email protected]>

This patch makes use of wait_event_interruptible_timeout to achieve timeout functionality.This is a TODO mentiond in the comment which is also removed.It also aligns with what the function is supposed to do as in the comments.

---
v2: Patch introduced checkpatch warning on the 80 character
limit & it was pointed out by Greg.Hence resubmitting

---
 drivers/staging/dgnc/dgnc_neo.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/dgnc/dgnc_neo.c +3 -3
index 39c76e7..ee3155b 100644
@@ -1306,10 +1306,10 @@ static int neo_drain(struct tty_struct *tty, uint seconds)
 	/*
 	 * Go to sleep waiting for the tty layer to wake me back up when
 	 * the empty flag goes away.
-	 *
-	 * NOTE: TODO: Do something with time passed in.
 	 */
-	rc = wait_event_interruptible(un->un_flags_wait, ((un->un_flags & UN_EMPTY) == 0));
+	rc = wait_event_interruptible_timeout(un->un_flags_wait,
+					      ((un->un_flags & UN_EMPTY) == 0),
+					      msecs_to_jiffies(seconds * 1000));
 
 	/* If ret is non-zero, user ctrl-c'ed us */
 	return rc;
Signature · 1 line
1.9.1