fix typo for libilclient.so on target
Schenk
PATCH 1/1 fix typo for libilclient.so on target
--- package/rpi-userland/rpi-userland.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
package/rpi-userland/rpi-userland.mk +2 -2
@@ -35,14 +35,14 @@ RPI_USERLAND_CONF_OPTS += -DALL_APPS=ON define RPI_USERLAND_EXTRA_LIBS_TARGET $(INSTALL) -m 0644 -D \ $(@D)/build/lib/libilclient.so \ - $(TARGET_DIR)/usr/lib/libilcient.so + $(TARGET_DIR)/usr/lib/libilclient.so endef RPI_USERLAND_POST_INSTALL_TARGET_HOOKS += RPI_USERLAND_EXTRA_LIBS_TARGET define RPI_USERLAND_EXTRA_LIBS_STAGING $(INSTALL) -m 0644 -D \ $(@D)/build/lib/libilclient.so \ - $(STAGING_DIR)/usr/lib/libilcient.so + $(STAGING_DIR)/usr/lib/libilclient.so endef RPI_USERLAND_POST_INSTALL_STAGING_HOOKS += RPI_USERLAND_EXTRA_LIBS_STAGING
Signature · 1 line
1.9.1
PATCH 1/1 fix typo for libilclient.so on target
Dear Schenk, Michael,
Quoted 4 lines · Michael
Signed-off-by Schenk, Michael <[email protected]>--- package/rpi-userland/rpi-userland.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, I've applied after tweaking two things:
- The commit title, which should always follow the format:
<package>: <description>
And also your commit title was talking about "target", but you're also fixing the "staging" installation. So all in all, I've changed the commit title to:
rpi-userland: fix typos in the libilclient.so library installation
For future patches, if you could use this convention for commit titles, it would be great.
- The author/SoB lines, where for consistency reasons we prefer to have the first name before the last name. Yes, I know that depending on your geographical area, the common way of doing this is different, but Buildroot Git history uses "FirstName LastName <email>" everywhere, so I've changed this. If you can change your Git configuration to use this for future patches, it would be great.
Thanks a lot for your contribution!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 fix typo for libilclient.so on target
Thomas, Michael, All,
On 2016-02-08 16:29 +0100, Thomas Petazzoni spake thusly:
Quoted 7 lines · Michael
Quoted 4 lines
Signed-off-by Schenk, Michael <[email protected]>--- package/rpi-userland/rpi-userland.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Thanks, I've applied after tweaking two things:
[--SNIP--]
Quoted 6 lines
- The author/SoB lines, where for consistency reasons we prefer to have the first name before the last name. Yes, I know that depending on your geographical area, the common way of doing this is different, but Buildroot Git history uses "FirstName LastName <email>" everywhere, so I've changed this. If you can change your Git configuration to use this for future patches, it would be great.
I beg to disagree here. I amongst all would prefer we do not force people to identify one way or another. We should *really* let people identify the way *they* want to.
Thank you.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 fix typo for libilclient.so on target
Hello,
Quoted 9 lines · Yann E. MORIN
Quoted 1 line
Thanks, I've applied after tweaking two things:
[--SNIP--]
Quoted 6 lines
- The author/SoB lines, where for consistency reasons we prefer to have the first name before the last name. Yes, I know that depending on your geographical area, the common way of doing this is different, but Buildroot Git history uses "FirstName LastName <email>" everywhere, so I've changed this. If you can change your Git configuration to use this for future patches, it would be great.
Quoted 3 lines
I beg to disagree here. I amongst all would prefer we do not force people to identify one way or another. We should *really* let people identify the way *they* want to.
I disagree here. For one, we already force people to use their real name instead of any pseudonym or fake name. Since we're already asking them to use their real name for legal reasons (without the real name, the DCO is moot), then it is not adding much more constraint to require the naming to follow a certain convention that makes it easier to identify the contributors.
So, no, we are not going to let people identify the way they want to, simply because the DCO does not allow that. If you want to do that, then you should stop asking people to sign-off their patches.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com