usb/cpia2_core: clean up a min_t() cast

PATCH New Dan Carpenter 1 participant 1 message Feb 9, 2016

Subsystems (2)

Media (V4L/DVB) Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2016-02-09 11:14 UTC #0 lore raw

PATCH 1/1 usb/cpia2_core: clean up a min_t() cast

It makes sense to make the min_t() cast unsigned here since we don't really want negative sizes. Making it signed causes a static checker warning in Smatch. Smatch knows "fw->size - i" is positive but it doesn't know that fw->size is less than INT_MAX so in theory casting it to int might lead to a negative.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/usb/cpia2/cpia2_core.c +1 -1

index 187012c..0310fd6 100644
@@ -923,7 +923,7 @@ static int apply_vp_patch(struct camera_data *cam)
 	/* ... followed by the data payload */
 	for (i = 2; i < fw->size; i += 64) {
 		cmd.start = 0x0C; /* Data */
-		cmd.reg_count = min_t(int, 64, fw->size - i);
+		cmd.reg_count = min_t(uint, 64, fw->size - i);
 		memcpy(cmd.buffer.block_data, &fw->data[i], cmd.reg_count);
 		cpia2_send_command(cam, &cmd);
 	}