Add hardware dependency to TS-4800 board drivers
Subsystems (4)
cover Add hardware dependency to TS-4800 board drivers
Hi all,
This adds hardware dependency to 3 drivers for the Technologic Systems TS-4800 board. Thanks to these dependencies, users of other systems will not accidentally enable these drivers.
Once again I must urge subsystem maintainers to add such dependencies to all new drivers which needs them. The lack of such dependencies makes distribution kernel maintainers' lives a nightmare.
[PATCH 1/3] watchdog: ts4800: add hardware dependency [PATCH 2/3] Input: ts4800: add hardware dependency [PATCH 3/3] irqchip/ts4800: Add hardware dependency
Signature · 2 lines
Jean Delvare SUSE L3 Support
PATCH 1/3 watchdog: ts4800: add hardware dependency
The Technologic Systems TS-4800 is an i.MX515 board, so its drivers are useless unless building a SOC_IMX51 kernel, except for build testing purposes.
--- drivers/watchdog/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/watchdog/Kconfig +1 -0
@@ -468,6 +468,7 @@ config NUC900_WATCHDOG config TS4800_WATCHDOG tristate "TS-4800 Watchdog" depends on HAS_IOMEM && OF + depends on SOC_IMX51 || COMPILE_TEST select WATCHDOG_CORE select MFD_SYSCON help
Signature · 2 lines
Jean Delvare SUSE L3 Support
Re: [PATCH 1/3] watchdog: ts4800: add hardware dependency
Quoted 9 lines · Jean Delvare
The Technologic Systems TS-4800 is an i.MX515 board, so its drivers are useless unless building a
SOC_IMX51kernel, except for build testing purposes.Signed-off-by Jean Delvare <[email protected]>Cc Damien Riegel <[email protected]>Cc Rob Herring <[email protected]>Cc Guenter Roeck <[email protected]>Cc Wim Van Sebroeck <[email protected]>
Re: [PATCH 1/3] watchdog: ts4800: add hardware dependency
In reply to Jean DelvareHi Jean,
Quoted 27 lines
The Technologic Systems TS-4800 is an i.MX515 board, so its drivers are useless unless building a
SOC_IMX51kernel, except for build testing purposes.Signed-off-by Jean Delvare <[email protected]>Cc Damien Riegel <[email protected]>Cc Rob Herring <[email protected]>Cc Guenter Roeck <[email protected]>Cc Wim Van Sebroeck <[email protected]>--- drivers/watchdog/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/watchdog/Kconfig +1
-0@@ -468,6 +468,7 @@ config NUC900_WATCHDOG config TS4800_WATCHDOG tristate "TS-4800 Watchdog" depends on HAS_IOMEM && OF + depends on SOC_IMX51 || COMPILE_TEST select WATCHDOG_CORE select MFD_SYSCON helpSignature · 3 lines
-- Jean Delvare SUSE L3 Support
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
PATCH 2/3 Input: ts4800: add hardware dependency
In reply to Jean DelvareThe Technologic Systems TS-4800 is an i.MX515 board, so its drivers are useless unless building a SOC_IMX51 kernel, except for build testing purposes.
--- drivers/input/touchscreen/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/input/touchscreen/Kconfig +1 -0
@@ -941,6 +941,7 @@ config TOUCHSCREEN_TOUCHIT213 config TOUCHSCREEN_TS4800 tristate "TS-4800 touchscreen" depends on HAS_IOMEM && OF + depends on SOC_IMX51 || COMPILE_TEST select MFD_SYSCON select INPUT_POLLDEV help
Signature · 2 lines
Jean Delvare SUSE L3 Support
Re: [PATCH 2/3] Input: ts4800: add hardware dependency
Quoted 5 lines · Jean Delvare
The Technologic Systems TS-4800 is an i.MX515 board, so its drivers are useless unless building a
SOC_IMX51kernel, except for build testing purposes.Signed-off-by Jean Delvare <[email protected]>
Applied, thank you.
Quoted 21 lines
Cc Damien Riegel <[email protected]>Cc Rob Herring <[email protected]>Cc Dmitry Torokhov <[email protected]>--- drivers/input/touchscreen/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/input/touchscreen/Kconfig +1
-0@@ -941,6 +941,7 @@ config TOUCHSCREEN_TOUCHIT213 config TOUCHSCREEN_TS4800 tristate "TS-4800 touchscreen" depends on HAS_IOMEM && OF + depends on SOC_IMX51 || COMPILE_TEST select MFD_SYSCON select INPUT_POLLDEV helpSignature · 3 lines
-- Jean Delvare SUSE L3 Support
Signature · 1 line
Dmitry
PATCH 3/3 irqchip/ts4800: Add hardware dependency
In reply to Jean DelvareThe Technologic Systems TS-4800 is an i.MX515 board, so its drivers are useless unless building a SOC_IMX51 kernel, except for build testing purposes.
--- drivers/irqchip/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/irqchip/Kconfig +1 -0
@@ -160,6 +160,7 @@ config TS4800_IRQ tristate "TS-4800 IRQ controller" select IRQ_DOMAIN depends on HAS_IOMEM + depends on SOC_IMX51 || COMPILE_TEST help Support for the TS-4800 FPGA IRQ controller
Signature · 2 lines
Jean Delvare SUSE L3 Support
Jason Cooper
AppliedRe: [PATCH 3/3] irqchip/ts4800: Add hardware dependency
Quoted 4 lines · Jean Delvare
The Technologic Systems TS-4800 is an i.MX515 board, so its drivers are useless unless building a
SOC_IMX51kernel, except for build testing purposes.
Quoted 8 lines
Signed-off-by Jean Delvare <[email protected]>Cc Damien Riegel <[email protected]>Cc Thomas Gleixner <[email protected]>Cc Jason Cooper <[email protected]>Cc Marc Zyngier <[email protected]>--- drivers/irqchip/Kconfig | 1 + 1 file changed, 1 insertion(+)
Applied to irqchip/core. Once we see this IP appear outside of IMX51, we can redo the Kconfig symbols based on what we see.
thx,
Jason.
Guenter Roeck
maintainerQuoted 6 lines · Jean Delvare
Hi all,
This adds hardware dependency to 3 drivers for the Technologic Systems TS-4800 board. Thanks to these dependencies, users of other systems will not accidentally enable these drivers.
Quoted 8 lines
Once again I must urge subsystem maintainers to add such dependencies to all new drivers which needs them. The lack of such dependencies makes distribution kernel maintainers' lives a nightmare.
[PATCH 1/3] watchdog: ts4800: add hardware dependency [PATCH 2/3] Input: ts4800: add hardware dependency [PATCH 3/3] irqchip/ts4800: Add hardware dependency
How about TOUCHSCREEN_TS4800 ?
Guenter
Hi Guenter,
Quoted 11 lines · Guenter Roeck
Quoted 10 lines · Jean Delvare
Hi all,
This adds hardware dependency to 3 drivers for the Technologic Systems TS-4800 board. Thanks to these dependencies, users of other systems will not accidentally enable these drivers.
Once again I must urge subsystem maintainers to add such dependencies to all new drivers which needs them. The lack of such dependencies makes distribution kernel maintainers' lives a nightmare.
Quoted 5 lines
Quoted 4 lines
[PATCH 1/3] watchdog: ts4800: add hardware dependency [PATCH 2/3] Input: ts4800: add hardware dependency [PATCH 3/3] irqchip/ts4800: Add hardware dependency
How about
TOUCHSCREEN_TS4800?
This is patch 2/3 above. Maybe I could make the subject line clearer indeed.
Signature · 2 lines
Jean Delvare SUSE L3 Support
Hi Jean,
Quoted 5 lines · Jean Delvare
Hi all,
This adds hardware dependency to 3 drivers for the Technologic Systems TS-4800 board. Thanks to these dependencies, users of other systems will not accidentally enable these drivers.
These drivers are for IPs implemented in an FPGA. For now it is true that they are used only on one board with an iMX.51 but this is not a strong dependency and it might change in the future if Technologic Systems decide to reuse these IPs on boards based on different SoCs.
As the FPGA and the SoC are two separate chips, I don't know how such dependency should be expressed in kconfig.
Thanks,
Damien
Guenter Roeck
maintainerQuoted 9 lines · Damien Riegel
Hi Jean,
Quoted 5 lines · Jean Delvare
Hi all,
This adds hardware dependency to 3 drivers for the Technologic Systems TS-4800 board. Thanks to these dependencies, users of other systems will not accidentally enable these drivers.
Quoted 8 lines
These drivers are for IPs implemented in an FPGA. For now it is true that they are used only on one board with an iMX.51 but this is not a strong dependency and it might change in the future if Technologic Systems decide to reuse these IPs on boards based on different SoCs.
As the FPGA and the SoC are two separate chips, I don't know how such dependency should be expressed in kconfig.
You could add a Kconfig option for the FPGA, which currently depends on the SoC.
Guenter
Hi Damien,
Quoted 9 lines · Damien Riegel
Quoted 3 lines · Jean Delvare
This adds hardware dependency to 3 drivers for the Technologic Systems TS-4800 board. Thanks to these dependencies, users of other systems will not accidentally enable these drivers.
These drivers are for IPs implemented in an FPGA. For now it is true that they are used only on one board with an iMX.51 but this is not a strong dependency and it might change in the future if Technologic Systems decide to reuse these IPs on boards based on different SoCs.
When this happens, we can update the dependency accordingly, this is not a problem.
Quoted 2 lines
As the FPGA and the SoC are two separate chips, I don't know how such dependency should be expressed in kconfig.
The way I did ;-)
These dependencies just tell where the hardware is being used at the moment. They do not imply that the same hardware can't be reused later on another board. In which case we can extend the dependency (e.g. adding another SOC family), or broaden it (e.g. "depends on ARM") or drop it altogether if the piece of hardware in question has taken over the world meanwhile.
But my experience is that a piece of hardware developed for i.MX has little chances to be found on a PowerPC system, even 5 years later.
Signature · 2 lines
Jean Delvare SUSE L3 Support