Deterministic replay extensions
v2 cover Deterministic replay extensions
This set of patches is related to the reverse execution and deterministic replay of qemu execution. It includes recording and replaying of serial devices and block devices operations.
With these patches one can record and deterministically replay behavior of the system with connected disk drives and serial communication ports (e.g., telnet terminal).
Patches for deterministic replay of the block devices intercept calls of blk_aio_ functions. These functions are used only by virtual devices. Replay cannot be embedded as block driver functions layer, because these functions are also used for qemu internal operations (e.g., migration).
v2 changes:
- removed obsolete call of qemu_clock_warp
- fixed record/replay of aio_cancel
- simplified call sequence for blk_aio_ functions in non-replay mode (as suggested by Kevin Wolf)
---
Pavel Dovgalyuk (4):
replay: character devices
icount: remove obsolete warp call
replay: introduce new checkpoint for icount warp
replay: introduce block devices record/replay
block/block-backend.c | 54 ++++++++++++-- cpus.c | 10 +-- gdbstub.c | 2 - include/qemu/timer.h | 3 + include/sysemu/char.h | 26 +++++++ include/sysemu/replay.h | 43 ++++++++++++ main-loop.c | 2 - qemu-char.c | 56 +++++++++++++-- qemu-timer.c | 2 - replay/Makefile.objs | 2 + replay/replay-block.c | 172 ++++++++++++++++++++++++++++++++++++++++++++++ replay/replay-char.c | 97 ++++++++++++++++++++++++++ replay/replay-events.c | 68 +++++++++++++++++- replay/replay-internal.h | 39 ++++++++++ replay/replay.c | 25 ++++++- stubs/clock-warp.c | 2 - stubs/replay.c | 50 +++++++++++++ 17 files changed, 622 insertions(+), 31 deletions(-) create mode 100755 replay/replay-block.c create mode 100755 replay/replay-char.c
Signature · 1 line
Pavel Dovgalyuk
PATCH v2 1/4 replay: character devices
This patch implements record and replay of character devices. It records chardevs communication in replay mode. Recorded information include data read from backend and counter of bytes written from frontend to backend to preserve frontend internal state. If character device was configured through the command line in record mode, then in replay mode it should be also added to command line. Backend of the character device could be changed in replay mode.
Replaying of devices that perform ioctl and get_msgfd operations is not supported.
gdbstub which also acts as a backend is not recorded to allow controlling the replaying through gdb.
--- gdbstub.c | 2 - include/sysemu/char.h | 26 ++++++++++++ include/sysemu/replay.h | 12 ++++++ qemu-char.c | 56 ++++++++++++++++++++++++--- replay/Makefile.objs | 1 replay/replay-char.c | 97 ++++++++++++++++++++++++++++++++++++++++++++++ replay/replay-events.c | 17 +++++++- replay/replay-internal.h | 15 +++++++ replay/replay.c | 25 +++++++++++- 9 files changed, 240 insertions(+), 11 deletions(-) create mode 100755 replay/replay-char.c
gdbstub.c +1 -1
@@ -1752,7 +1752,7 @@ int gdbserver_start(const char *device) sigaction(SIGINT, &act, NULL); }#endif - chr =qemu_chr_new ("gdb" , device,NULL ); + chr =qemu_chr_new_noreplay ("gdb" , device,NULL );if (!chr)return -1 ;
include/sysemu/char.h +26 -0
@@ -86,6 +86,7 @@ struct CharDriverState {int is_mux;guint fd_in_tag;QemuOpts *opts; +bool replay;QTAILQ_ENTRY (CharDriverState) next; };
@@ -129,6 +130,22 @@ CharDriverState *qemu_chr_new(const char *label, const char *filename, void (*init)(struct CharDriverState *s));/** +* @qemu_chr_new_noreplay: +* +* Create a new character backend from a URI. +* Character device communications are not written +* into the replay log. +* +* @label the name of the backend +* @filename the URI +* @init not sure.. +* +* Returns: a new character backend +*/ +CharDriverState *qemu_chr_new_noreplay (const char *label,const char *filename, +void (*init)(struct CharDriverState *s)); + +/** * @qemu_chr_delete: * * Destroy a character backend and remove it from the list of
@@ -331,6 +348,15 @@ int qemu_chr_be_can_write(CharDriverState *s);*/ void qemu_chr_be_write (CharDriverState *s,uint8_t *buf,int len); +/** +* @qemu_chr_be_write_impl: +* +* Implementation of back end writing. Used by replay module. +* +* @buf a buffer to receive data from the front end +* @len the number of bytes to receive from the front end +*/ +void qemu_chr_be_write_impl (CharDriverState *s,uint8_t *buf,int len);/** * @qemu_chr_be_event:
include/sysemu/replay.h +12 -0
@@ -117,4 +117,16 @@ void replay_input_event(QemuConsole *src, InputEvent *evt);/*! Adds input sync event to the queue */ void replay_input_sync_event (void ); +/* Character device */ + +/*! Registers char driver to save it's events */ +void replay_register_char_driver (struct CharDriverState *chr); +/*! Saves write to char device event to the log */ +void replay_chr_be_write (struct CharDriverState *s,uint8_t *buf,int len); + +/* Other data */ + +/*! Writes or reads integer value to/from replay log. */ +void replay_data_int (int *data); +#endif
qemu-char.c +50 -6
101 lines not on this page · raw message
replay/Makefile.objs +1 -0
@@ -3,3 +3,4 @@ common-obj-y += replay-internal.o common-obj-y += replay-events.o common-obj-y += replay-time.o common-obj-y += replay-input.o +common-obj-y += replay-char.o
replay/replay-char.c new file +97 -0
97 lines not on this page · raw message
replay/replay-events.c +14 -3
@@ -48,6 +48,9 @@ static void replay_run_event(Event *event)case REPLAY_ASYNC_EVENT_INPUT_SYNC :qemu_input_event_sync_impl ();break ; +case REPLAY_ASYNC_EVENT_CHAR : +replay_event_char_run (event->opaque); +break ;default :error_report ("Replay: invalid async event ID (%d) in the queue" , event->event_kind);
@@ -102,9 +105,9 @@ void replay_clear_events(void) }/*! Adds specified async event to the queue */ -static void replay_add_event (ReplayAsyncEventKind event_kind, -void *opaque, -void *opaque2,uint64_t id) +void replay_add_event (ReplayAsyncEventKind event_kind, +void *opaque, +void *opaque2,uint64_t id) {assert (event_kind <REPLAY_ASYNC_COUNT );
@@ -168,6 +171,9 @@ static void replay_save_event(Event *event, int checkpoint)break ;case REPLAY_ASYNC_EVENT_INPUT_SYNC :break ; +case REPLAY_ASYNC_EVENT_CHAR : +replay_event_char_save (event->opaque); +break ;default :error_report ("Unknown ID %d of replay event" , read_event_kind);exit (1 );
@@ -221,6 +227,11 @@ static Event *replay_read_event(int checkpoint) event->event_kind = read_event_kind; event->opaque =0 ;return event; +case REPLAY_ASYNC_EVENT_CHAR : + event =g_malloc0 (sizeof (Event)); + event->event_kind = read_event_kind; + event->opaque =replay_event_char_read (); +return event;default :error_report ("Unknown ID %d of replay event" , read_event_kind);exit (1 );
replay/replay-internal.h +15 -0
@@ -25,6 +25,8 @@ enum ReplayEvents {EVENT_ASYNC ,/* for shutdown request */ EVENT_SHUTDOWN , +/* for int data */ +EVENT_DATA_INT ,/* for clock read/writes */ /* some of greater codes are reserved for clocks */ EVENT_CLOCK,
@@ -44,6 +46,7 @@ enum ReplayAsyncEventKind {REPLAY_ASYNC_EVENT_BH ,REPLAY_ASYNC_EVENT_INPUT ,REPLAY_ASYNC_EVENT_INPUT_SYNC , +REPLAY_ASYNC_EVENT_CHAR , REPLAY_ASYNC_COUNT };
@@ -125,6 +128,9 @@ bool replay_has_events(void);void replay_save_events (int checkpoint);/*! Read events from the file into the input queue */ void replay_read_events (int checkpoint); +/*! Adds specified async event to the queue */ +void replay_add_event (ReplayAsyncEventKind event_kind,void *opaque, +void *opaque2,uint64_t id);/* Input events */
@@ -137,4 +143,13 @@ void replay_add_input_event(struct InputEvent *event);/*! Adds input sync event to the queue */ void replay_add_input_sync_event (void ); +/* Character devices */ + +/*! Called to run char device event. */ +void replay_event_char_run (void *opaque); +/*! Writes char event to the file. */ +void replay_event_char_save (void *opaque); +/*! Reads char event from the file. */ +void *replay_event_char_read (void ); +#endif
replay/replay.c +24 -1
@@ -20,7 +20,7 @@/* Current version of the replay mechanism. Increase it when file format changes. */ -#define REPLAY_VERSION 0xe02002 +#define REPLAY_VERSION 0xe02003/* Size of replay log header */ #define HEADER_SIZE (sizeof(uint32_t) + sizeof(uint64_t))
@@ -340,3 +340,26 @@ void replay_add_blocker(Error *reason) { replay_blockers =g_slist_prepend (replay_blockers, reason); } + +void replay_data_int (int *data) +{ +if (replay_mode ==REPLAY_MODE_PLAY ) { +replay_account_executed_instructions (); +replay_mutex_lock (); +if (replay_next_event_is (EVENT_DATA_INT )) { + *data =replay_get_dword (); +replay_finish_event (); +replay_mutex_unlock (); + }else { +replay_mutex_unlock (); +error_report ("Missing data int event in the replay log" ); +exit (1 ); + } + }else if (replay_mode ==REPLAY_MODE_RECORD ) { +replay_save_instructions (); +replay_mutex_lock (); +replay_put_event (EVENT_DATA_INT ); +replay_put_dword (*data); +replay_mutex_unlock (); + } +}
PATCH v2 2/4 icount: remove obsolete warp call
In reply to Pavel Dovgalyukqemu_clock_warp call in qemu_tcg_wait_io_event function is not needed anymore, because it is called in every iteration of main_loop_wait.
--- cpus.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
cpus.c +0 -3
@@ -995,9 +995,6 @@ static void qemu_wait_io_event_common(CPUState *cpu)static void qemu_tcg_wait_io_event (CPUState *cpu) {while (all_cpu_threads_idle ()) { -/* Start accounting real time to the virtual clock if the CPUs -are idle. */ -qemu_clock_warp (QEMU_CLOCK_VIRTUAL );qemu_cond_wait (cpu->halt_cond, &qemu_global_mutex); }
PATCH v2 3/4 replay: introduce new checkpoint for icount warp
In reply to Pavel Dovgalyukqemu_clock_warp function is called to update virtual clock when CPU is sleeping. This function includes replay checkpoint to make execution deterministic in icount mode.
Record/replay module flushes async event queue at checkpoints. Some of the events (e.g., block devices operations) include interaction with hardware. E.g., APIC polled by block devices sets one of IRQ flags. Flag to be set depends on currently executed thread (CPU or iothread). Therefore in replay mode we have to process the checkpoints in the same thread as they were recorded.qemu_clock_warp function (and its checkpoint) may be called from different thread. This patch introduces new checkpoint which distinguished warp checkpoint calls from different threads.
--- cpus.c | 7 ++++--- include/qemu/timer.h | 3 ++- include/sysemu/replay.h | 1 + main-loop.c | 2 +- qemu-timer.c | 2 +- stubs/clock-warp.c | 2 +- 6 files changed, 10 insertions(+), 7 deletions(-)
cpus.c +4 -3
@@ -396,7 +396,7 @@ void qtest_clock_warp(int64_t dest)qemu_clock_notify (QEMU_CLOCK_VIRTUAL ); } -void qemu_clock_warp (QEMUClockType type) +void qemu_clock_warp (QEMUClockType type,bool in_tcg) {int64_t clock;int64_t deadline;
@@ -418,7 +418,8 @@ void qemu_clock_warp(QEMUClockType type) }/* warp clock deterministically in record/replay mode */ -if (!replay_checkpoint (CHECKPOINT_CLOCK_WARP )) { +if (!replay_checkpoint (in_tcg ?CHECKPOINT_CLOCK_WARP_TCG + :CHECKPOINT_CLOCK_WARP )) {return ; }
@@ -1496,7 +1497,7 @@ static void tcg_exec_all(void)int r;/* Account partial waits to QEMU_CLOCK_VIRTUAL. */ -qemu_clock_warp (QEMU_CLOCK_VIRTUAL ); +qemu_clock_warp (QEMU_CLOCK_VIRTUAL , true);if (next_cpu ==NULL ) { next_cpu = first_cpu;
include/qemu/timer.h +2 -1
@@ -212,10 +212,11 @@ void qemu_clock_enable(QEMUClockType type, bool enabled);/** * qemu_clock_warp: * @type: the clock type +* @in_tcg: true if function is called from TCG CPU thread * * Warp a clock to a new value */ -void qemu_clock_warp (QEMUClockType type); +void qemu_clock_warp (QEMUClockType type,bool in_tcg);/** * qemu_clock_register_reset_notifier:
include/sysemu/replay.h +1 -0
@@ -31,6 +31,7 @@ typedef enum ReplayClockKind ReplayClockKind;/* IDs of the checkpoints */ enum ReplayCheckpoint {CHECKPOINT_CLOCK_WARP , +CHECKPOINT_CLOCK_WARP_TCG ,CHECKPOINT_RESET_REQUESTED ,CHECKPOINT_SUSPEND_REQUESTED ,CHECKPOINT_CLOCK_VIRTUAL ,
main-loop.c +1 -1
@@ -509,7 +509,7 @@ int main_loop_wait(int nonblocking)/* CPU thread can infinitely wait for event after missing the warp */ -qemu_clock_warp (QEMU_CLOCK_VIRTUAL ); +qemu_clock_warp (QEMU_CLOCK_VIRTUAL , false);qemu_clock_run_all_timers ();return ret;
qemu-timer.c +1 -1
@@ -394,7 +394,7 @@ static bool timer_mod_ns_locked(QEMUTimerList *timer_list,static void timerlist_rearm (QEMUTimerList *timer_list) {/* Interrupt execution to force deadline recalculation. */ -qemu_clock_warp (timer_list->clock->type); +qemu_clock_warp (timer_list->clock->type, false);timerlist_notify (timer_list); }
stubs/clock-warp.c +1 -1
@@ -2,7 +2,7 @@#include "qemu-common.h" #include "qemu/timer.h" -void qemu_clock_warp (QEMUClockType type) +void qemu_clock_warp (QEMUClockType type,bool in_tcg) { }
PATCH v2 4/4 replay: introduce block devices record/replay
In reply to Pavel DovgalyukThis patch introduces a set of functions that implement recording and replaying of block devices' operations. These functions form a thin layer between blk_aio_ functions and replay subsystem.
All asynchronous block requests are added to the queue to be processed at deterministically invoked record/replay checkpoints. Queue is flushed at checkpoints and information about processed requests is recorded to the log. In replay phase the queue is matched with events read from the log. Therefore block devices requests are processed deterministically.
--- block/block-backend.c | 54 ++++++++++++-- include/sysemu/replay.h | 30 ++++++++ replay/Makefile.objs | 1 replay/replay-block.c | 172 ++++++++++++++++++++++++++++++++++++++++++++++ replay/replay-events.c | 51 ++++++++++++++ replay/replay-internal.h | 24 ++++++ stubs/replay.c | 50 +++++++++++++ 7 files changed, 372 insertions(+), 10 deletions(-) create mode 100755 replay/replay-block.c
block/block-backend.c +44 -10
@@ -17,6 +17,7 @@#include "block/throttle-groups.h" #include "sysemu/blockdev.h" #include "sysemu/sysemu.h" +#include "sysemu/replay.h" #include "qapi-event.h" /* Number of coroutines to reserve per attached device model */
@@ -688,7 +689,7 @@ BlockAIOCB *blk_abort_aio_request(BlockBackend *blk, bh =aio_bh_new (blk_get_aio_context (blk), error_callback_bh, acb); acb->bh = bh; -qemu_bh_schedule (bh); +replay_bh_schedule_event (bh);return &acb->common; }
@@ -702,8 +703,13 @@ BlockAIOCB *blk_aio_write_zeroes(BlockBackend *blk, int64_t sector_num,return blk_abort_aio_request (blk, cb, opaque, ret); } -return bdrv_aio_write_zeroes (blk->bs, sector_num, nb_sectors, flags, - cb, opaque); +if (replay_mode ==REPLAY_MODE_NONE ) { +return bdrv_aio_write_zeroes (blk->bs, sector_num, nb_sectors, flags, + cb, opaque); + }else { +return replay_aio_write_zeroes (blk->bs, sector_num, nb_sectors, flags, + cb, opaque); + } }int blk_pread (BlockBackend *blk,int64_t offset,void *buf,int count)
@@ -762,7 +768,11 @@ BlockAIOCB *blk_aio_readv(BlockBackend *blk, int64_t sector_num,return blk_abort_aio_request (blk, cb, opaque, ret); } -return bdrv_aio_readv (blk->bs, sector_num, iov, nb_sectors, cb, opaque); +if (replay_mode ==REPLAY_MODE_NONE ) { +return bdrv_aio_readv (blk->bs, sector_num, iov, nb_sectors, cb, opaque); + }else { +return replay_aio_readv (blk->bs, sector_num, iov, nb_sectors, cb, opaque); + } } BlockAIOCB *blk_aio_writev(BlockBackend *blk, int64_t sector_num,
@@ -774,7 +784,11 @@ BlockAIOCB *blk_aio_writev(BlockBackend *blk, int64_t sector_num,return blk_abort_aio_request (blk, cb, opaque, ret); } -return bdrv_aio_writev (blk->bs, sector_num, iov, nb_sectors, cb, opaque); +if (replay_mode ==REPLAY_MODE_NONE ) { +return bdrv_aio_writev (blk->bs, sector_num, iov, nb_sectors, cb, opaque); + }else { +return replay_aio_writev (blk->bs, sector_num, iov, nb_sectors, cb, opaque); + } } BlockAIOCB *blk_aio_flush(BlockBackend *blk,
@@ -784,7 +798,11 @@ BlockAIOCB *blk_aio_flush(BlockBackend *blk,return blk_abort_aio_request (blk, cb, opaque, -ENOMEDIUM ); } -return bdrv_aio_flush (blk->bs, cb, opaque); +if (replay_mode ==REPLAY_MODE_NONE ) { +return bdrv_aio_flush (blk->bs, cb, opaque); + }else { +return replay_aio_flush (blk->bs, cb, opaque); + } } BlockAIOCB *blk_aio_discard(BlockBackend *blk,
@@ -796,17 +814,29 @@ BlockAIOCB *blk_aio_discard(BlockBackend *blk,return blk_abort_aio_request (blk, cb, opaque, ret); } -return bdrv_aio_discard (blk->bs, sector_num, nb_sectors, cb, opaque); +if (replay_mode ==REPLAY_MODE_NONE ) { +return bdrv_aio_discard (blk->bs, sector_num, nb_sectors, cb, opaque); + }else { +return replay_aio_discard (blk->bs, sector_num, nb_sectors, cb, opaque); + } }void blk_aio_cancel (BlockAIOCB *acb) { -bdrv_aio_cancel (acb); +if (replay_mode ==REPLAY_MODE_NONE ) { +bdrv_aio_cancel (acb); + }else { +replay_aio_cancel (acb); + } }void blk_aio_cancel_async (BlockAIOCB *acb) { -bdrv_aio_cancel_async (acb); +if (replay_mode ==REPLAY_MODE_NONE ) { +bdrv_aio_cancel_async (acb); + }else { +replay_aio_cancel (acb); + } }int blk_aio_multiwrite (BlockBackend *blk,BlockRequest *reqs,int num_reqs)
@@ -839,7 +869,11 @@ BlockAIOCB *blk_aio_ioctl(BlockBackend *blk, unsigned long int req, void *buf,return blk_abort_aio_request (blk, cb, opaque, -ENOMEDIUM ); } -return bdrv_aio_ioctl (blk->bs, req, buf, cb, opaque); +if (replay_mode ==REPLAY_MODE_NONE ) { +return bdrv_aio_ioctl (blk->bs, req, buf, cb, opaque); + }else { +return replay_aio_ioctl (blk->bs, req, buf, cb, opaque); + } }int blk_co_discard (BlockBackend *blk,int64_t sector_num,int nb_sectors)
include/sysemu/replay.h +30 -0
@@ -17,6 +17,8 @@#include "qapi-types.h" #include "qapi/error.h" #include "qemu/typedefs.h" +#include "block/aio.h" +#include "block/block.h" /* replay clock kinds */ enum ReplayClockKind {
@@ -125,6 +127,34 @@ void replay_register_char_driver(struct CharDriverState *chr);/*! Saves write to char device event to the log */ void replay_chr_be_write (struct CharDriverState *s,uint8_t *buf,int len); +/* Block devices */ + +/*! Asynchronous read function. Adds read request to the queue. */ +BlockAIOCB *replay_aio_readv (BlockDriverState *bs,int64_t sector_num, +QEMUIOVector *iov,int nb_sectors, +BlockCompletionFunc *cb,void *opaque); +/*! Asynchronous write function. Adds write request to the queue. */ +BlockAIOCB *replay_aio_writev (BlockDriverState *bs,int64_t sector_num, +QEMUIOVector *iov,int nb_sectors, +BlockCompletionFunc *cb,void *opaque); +/*! Asynchronous write zeroes function. Adds this request to the queue. */ +BlockAIOCB *replay_aio_write_zeroes (BlockDriverState *bs,int64_t sector_num, +int nb_sectors,BdrvRequestFlags flags, +BlockCompletionFunc *cb,void *opaque); +/*! Asynchronous flush function. Adds flush request to the queue. */ +BlockAIOCB *replay_aio_flush (BlockDriverState *bs, +BlockCompletionFunc *cb,void *opaque); +/*! Asynchronous discard function. Adds discard request to the queue. */ +BlockAIOCB *replay_aio_discard (BlockDriverState *bs,int64_t sector_num, +int nb_sectors,BlockCompletionFunc *cb, +void *opaque); +/*! Asynchronous ioctl function. Adds ioctl request to the queue. */ +BlockAIOCB *replay_aio_ioctl (BlockDriverState *bs,unsigned long int req,void *buf, +BlockCompletionFunc *cb,void *opaque); +/*! Cancels pending asynchronous IO request. */ +void replay_aio_cancel (BlockAIOCB *acb); + +/* Other data */ /*! Writes or reads integer value to/from replay log. */
replay/Makefile.objs +1 -0
@@ -4,3 +4,4 @@ common-obj-y += replay-events.o common-obj-y += replay-time.o common-obj-y += replay-input.o common-obj-y += replay-char.o +common-obj-y += replay-block.o
replay/replay-block.c new file +172 -0
172 lines not on this page · raw message
replay/replay-events.c +51 -0
75 lines not on this page · raw message
replay/replay-internal.h +24 -0
@@ -47,6 +47,12 @@ enum ReplayAsyncEventKind {REPLAY_ASYNC_EVENT_INPUT ,REPLAY_ASYNC_EVENT_INPUT_SYNC ,REPLAY_ASYNC_EVENT_CHAR , +REPLAY_ASYNC_EVENT_BLOCK_READV , +REPLAY_ASYNC_EVENT_BLOCK_WRITEV , +REPLAY_ASYNC_EVENT_BLOCK_WRITE_ZEROES , +REPLAY_ASYNC_EVENT_BLOCK_FLUSH , +REPLAY_ASYNC_EVENT_BLOCK_DISCARD , +REPLAY_ASYNC_EVENT_BLOCK_IOCTL ,REPLAY_ASYNC_COUNT };
@@ -131,6 +137,9 @@ void replay_read_events(int checkpoint);/*! Adds specified async event to the queue */ void replay_add_event (ReplayAsyncEventKind event_kind,void *opaque,void *opaque2,uint64_t id); +/*! Removes specified async event from the queue */ +void replay_remove_event (ReplayAsyncEventKind event_kind, +void *opaque,void *opaque2,uint64_t id);/* Input events */
@@ -152,4 +161,19 @@ void replay_event_char_save(void *opaque);/*! Reads char event from the file. */ void *replay_event_char_read (void ); +/* Block devices */ + +/*! Called to run block device readv event. */ +void replay_event_block_readv_run (void *opaque); +/*! Called to run block device writev event. */ +void replay_event_block_writev_run (void *opaque); +/*! Called to run block device write zeroes event. */ +void replay_event_block_write_zeroes_run (void *opaque); +/*! Called to run block device flush event. */ +void replay_event_block_flush_run (void *opaque); +/*! Called to run block device discard event. */ +void replay_event_block_discard_run (void *opaque); +/*! Called to run block device ioctl event. */ +void replay_event_block_ioctl_run (void *opaque); +#endif
stubs/replay.c +50 -0
59 lines not on this page · raw message
Re: [Qemu-devel] [PATCH v2 4/4] replay: introduce block devices record/replay
block/block-backend.c BlockAIOCB *blk_aio_flush(BlockBackend *blk, · line 806
Quoted 11 lines · Pavel Dovgalyuk
block/block-backend.c +5
-1@@ -784,7 +798,11 @@ BlockAIOCB *blk_aio_flush(BlockBackend *blk,return blk_abort_aio_request (blk, cb, opaque, -ENOMEDIUM ); } -return bdrv_aio_flush (blk->bs, cb, opaque); +if (replay_mode ==REPLAY_MODE_NONE ) { +return bdrv_aio_flush (blk->bs, cb, opaque); + }else { +return replay_aio_flush (blk->bs, cb, opaque); + } }
I am only looking at this patch in isolation and am not familiar with the record/replay work, but these changes appear invasive. In order for record/replay to keep working in the future, everyone touching block layer code must be familiar with the principles of how record/replay works. This patch does not include documentation.
Can you point me to documentation that explains the how record replay works?
Thanks,
Stefan
Re: [Qemu-devel] [PATCH v2 4/4] replay: introduce block devices record/replay
Quoted 6 lines
From: Stefan Hajnoczi [mailto:[email protected]]
Quoted 4 lines · Pavel Dovgalyuk
block/block-backend.c +0
-0@@ -784,7 +798,11 @@ BlockAIOCB *blk_aio_flush(BlockBackend *blk,return blk_abort_aio_request (blk, cb, opaque, -ENOMEDIUM ); }
Quoted 13 lines
block/block-backend.c BlockAIOCB *blk_aio_flush(BlockBackend *blk, · line 806
Quoted 7 lines
block/block-backend.c +5
-1-return bdrv_aio_flush (blk->bs, cb, opaque); +if (replay_mode ==REPLAY_MODE_NONE ) { +return bdrv_aio_flush (blk->bs, cb, opaque); + }else { +return replay_aio_flush (blk->bs, cb, opaque); + } }I am only looking at this patch in isolation and am not familiar with the record/replay work, but these changes appear invasive. In order for record/replay to keep working in the future, everyone touching block layer code must be familiar with the principles of how record/replay works. This patch does not include documentation.
We've already discussed it with Kevin.
He proposes adding new block driver for record/replay.
Quoted 2 lines
Can you point me to documentation that explains the how record replay works?
There is some information about it in docs/replay.txt and in
http://wiki.qemu.org/Features/record-replay
Pavel Dovgalyuk
Re: [Qemu-devel] [PATCH v2 4/4] replay: introduce block devices record/replay
Quoted 20 lines · Pavel Dovgalyuk
Quoted 6 lines
From: Stefan Hajnoczi [mailto:[email protected]]
Quoted 4 lines · Pavel Dovgalyuk
block/block-backend.c +0
-0@@ -784,7 +798,11 @@ BlockAIOCB *blk_aio_flush(BlockBackend *blk,return blk_abort_aio_request (blk, cb, opaque, -ENOMEDIUM ); }Quoted 13 lines
block/block-backend.c BlockAIOCB *blk_aio_flush(BlockBackend *blk, · line 806
Quoted 7 lines
block/block-backend.c +5
-1-return bdrv_aio_flush (blk->bs, cb, opaque); +if (replay_mode ==REPLAY_MODE_NONE ) { +return bdrv_aio_flush (blk->bs, cb, opaque); + }else { +return replay_aio_flush (blk->bs, cb, opaque); + } }I am only looking at this patch in isolation and am not familiar with the record/replay work, but these changes appear invasive. In order for record/replay to keep working in the future, everyone touching block layer code must be familiar with the principles of how record/replay works. This patch does not include documentation.
Quoted 8 lines
We've already discussed it with Kevin.
He proposes adding new block driver for record/replay.Quoted 2 lines
Can you point me to documentation that explains the how record replay works?
There is some information about it in
docs/replay.txtand in
http://wiki.qemu.org/Features/record-replay
I was thinking about developer documentation. A feature like this is "cross-cutting" - it affects many components. There should be documentation that explains the semantics so everyone modifying code can follow the rules to keep record/replay working.
Live migration is similar in that it touches many components. The docs/migration.txt file explains the APIs and general idea. It communicates the assumptions, limitations, and requirements that live migration imposes. Many QEMU developers understand migration basics and keep them in mind during code review. This way we can prevent most (but not all) migration breakage.
Record/replay should aim for the same level of education/awareness, otherwise the feature will break and bitrot.
The alternative is to implement it in a way that isn't invasive. Then other developers don't need to understand how it works. Maybe implementing it in a block driver can achieve this.
Stefan