Skip to contentSkip to conversation

dissect: s/mode_t/usage_t/ in report_member()

PATCH In review Oleg Nesterov 4 participants 5 messages Feb 11, 2016 – Nov 2, 2016 Sparse checker

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dissect: s/mode_t/usage_t/ in report_member()

Cosmetic, fix the typo.

---
 dissect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
dissect.c +1 -1
index 2d13d2a..67428ec 100644
@@ -130,7 +130,7 @@ static inline struct symbol *no_member(struct ident *name)
 	return &sym;
 }
 
-static struct symbol *report_member(mode_t mode, struct position *pos,
+static struct symbol *report_member(usage_t mode, struct position *pos,
 					struct symbol *type, struct symbol *mem)
 {
 	struct symbol *ret = mem->ctype.base_type;
Signature · 1 line
2.5.0
Acked-by on v1 1/1
#1 lore raw
Quoted 31 lines

From: "Oleg Nesterov" <[email protected]>
To: "Christopher Li" <[email protected]>, "Josh Triplett" <[email protected]>
Cc: [email protected]
Sent: Thursday, February 11, 2016 5:47:10 PM
Subject: [PATCH] dissect: s/mode_t/usage_t/ in report_member()

Cosmetic, fix the typo.

---
 dissect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
dissect.c +1 -1
index 2d13d2a..67428ec 100644
@@ -130,7 +130,7 @@ static inline struct symbol *no_member(struct ident
 *name)
 	return &sym;
 }
 
-static struct symbol *report_member(mode_t mode, struct position *pos,
+static struct symbol *report_member(usage_t mode, struct position *pos,
 					struct symbol *type, struct symbol *mem)
 {

struct symbol *ret = mem->ctype.base_type;
--
2.5.0

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Better late than never:

maintainer
#3 lore raw
Quoted 8 lines · Oleg Nesterov
Quoted 4 lines · Lance Richardson

Better late than never:

Thanks, perhaps you can also ack other patches I sent by that time ;) Although it seems that nobody cares anyway.

Err, better late than never. Let me pick this up again.

Chris

Acked-by on v1 1/1
#4 lore raw
In reply to Oleg Nesterov
Quoted 13 lines · Oleg Nesterov

Cosmetic, fix the typo.

---
 dissect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
dissect.c +0 -0
index 2d13d2a..67428ec 100644

dissect.c static inline struct symbol *no_member(struct ident *name) · line 136

Quoted 8 lines
dissect.c +1 -1
@@ -130,7 +130,7 @@ static inline struct symbol *no_member(struct ident *name)
 	return &sym;
 }
 
-static struct symbol *report_member(mode_t mode, struct position *pos,
+static struct symbol *report_member(usage_t mode, struct position *pos,
 					struct symbol *type, struct symbol *mem)
 {
 	struct symbol *ret = mem->ctype.base_type;

For what it's worth: