misc: mic: use after free printing error message

PATCH New Dan Carpenter 1 participant 1 message Feb 12, 2016

Subsystems (2)

Kernel janitors Char and misc drivers

lore

Share & tools

lore

Dan Carpenter

author

2016-02-12 06:40 UTC #0 lore raw

PATCH 1/2 misc: mic: use after free printing error message

Swap the printk and kfree() to avoid a use after free bug.

Fixes 61e9c905df78 ('misc: mic: Enable VOP host side functionality')

Signed-off-by Dan Carpenter <[email protected]>

drivers/misc/mic/vop/vop_vringh.c +1 -1

index c1dd000..c3613f3 100644
@@ -290,9 +290,9 @@ static int vop_virtio_add_device(struct vop_vdev *vdev,
 
 	ret = vop_copy_dp_entry(vdev, argp, &type, &dd);
 	if (ret) {
-		kfree(vdev);
 		dev_err(vop_dev(vdev), "%s %d err %d\n",
 			__func__, __LINE__, ret);
+		kfree(vdev);
 		return ret;
 	}