misc: mic: silence an overflow warning

PATCH New Dan Carpenter 1 participant 1 message Feb 12, 2016

Subsystems (2)

Kernel janitors Char and misc drivers

lore

Share & tools

lore

Dan Carpenter

author

2016-02-12 06:44 UTC #0 lore raw

PATCH 2/2 misc: mic: silence an overflow warning

Static checkers complain that the this is a potential array overflow. We verify that it's not on the next line so this code is OK, but static checker warnings are annoying.

Signed-off-by Dan Carpenter <[email protected]>

---
We would have caught CVE-2015-5327 if we had ordered it to check first before using the offset.

drivers/misc/mic/vop/vop_vringh.c +2 -1

index c3613f3..e94c7fb 100644
@@ -848,12 +848,13 @@ static int vop_virtio_copy_desc(struct vop_vdev *vdev,
 				struct mic_copy_desc *copy)
 {
 	int err;
-	struct vop_vringh *vvr = &vdev->vvr[copy->vr_idx];
+	struct vop_vringh *vvr;
 
 	err = vop_verify_copy_args(vdev, copy);
 	if (err)
 		return err;
 
+	vvr = &vdev->vvr[copy->vr_idx];
 	mutex_lock(&vvr->vr_mutex);
 	if (!vop_vdevup(vdev)) {
 		err = -ENODEV;