Skip to contentSkip to conversation

staging:fbtft: Fix block comment coding style

PATCH In review Anchal Jain 2 participants 2 messages Feb 14, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging:fbtft: Fix block comment coding style

Add the required leading * on subsequent lines as well as move the */ on a separate line. Checkpatch found this issue.

---
 drivers/staging/fbtft/fbtft-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/fbtft/fbtft-core.c +2 -1
index 3bcbabf..c61c6ce 100644
@@ -519,7 +519,8 @@ static ssize_t fbtft_fb_write(struct fb_info *info, const char __user *buf,
 	res = fb_sys_write(info, buf, count, ppos);
 
 	/* TODO: only mark changed area
-	   update all for now */
+	 * update all for now
+	 */
 	par->fbtftops.mkdirty(info, -1, 0);
 
 	return res;
Signature · 1 line
1.9.1
#1 lore raw
Quoted 1 line · Anchal Jain

Add the required leading * on subsequent lines as well as move the */ on a separate line. Checkpatch found this issue.

Actually, there is no need for this to be a multiline comment. The whole thing would fit on a single line.

Also, in the subject line, there should be a space after staging:

julia

Quoted 31 lines
---
 drivers/staging/fbtft/fbtft-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/fbtft/fbtft-core.c +2 -1
index 3bcbabf..c61c6ce 100644
@@ -519,7 +519,8 @@ static ssize_t fbtft_fb_write(struct fb_info *info, const char __user *buf,
 	res = fb_sys_write(info, buf, count, ppos);
 
 	/* TODO: only mark changed area
-	   update all for now */
+	 * update all for now
+	 */
 	par->fbtftops.mkdirty(info, -1, 0);
 
 	return res;
Signature · 8 lines
1.9.1

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160214104333.GA27431%40life-desktop.
For more options, visit https://groups.google.com/d/optout.