Skip to contentSkip to conversation

pinctrl: mediatek: signedness bug in mtk_pmx_gpio_request_enable()

PATCH In review Dan Carpenter 3 participants 3 messages Feb 16, 2016 – Feb 18, 2016

Subsystems (5)
Kernel janitors GPIO Arm MediaTek Pin control +1 more subsystems
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 pinctrl: mediatek: signedness bug in mtk_pmx_gpio_request_enable()

"muxval" stores a value from 0-255 or a negative error code. It has to be signed for the error handling to work.

Fixes 59ee9c96dd5d ('pinctrl: mediatek: Add gpio_request_enable support')
Signed-off-by Dan Carpenter <[email protected]>
drivers/pinctrl/mediatek/pinctrl-mtk-common.c +2 -2
index cbc2204..1fbaf28 100644
@@ -755,14 +755,14 @@ static int mtk_pmx_gpio_request_enable(struct pinctrl_dev *pctldev,
 				    struct pinctrl_gpio_range *range,
 				    unsigned offset)
 {
-	unsigned long muxval;
+	int muxval;
 	struct mtk_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev);
 
 	muxval = mtk_pmx_find_gpio_mode(pctl, offset);
 
 	if (muxval < 0) {
 		dev_err(pctl->dev, "invalid gpio pin %d.\n", offset);
-		return -EINVAL;
+		return muxval;
 	}
 
 	mtk_pmx_set_mode(pctldev, offset, muxval);