Skip to contentSkip to conversation

writeback: initialize inode members that track writeback history

PATCH In review Tahsin Erdogan 2 participants 2 messages Feb 16, 2016 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 writeback: initialize inode members that track writeback history

inode struct members that track cgroup writeback information should be reinitialized when inode gets allocated from kmem_cache. Otherwise, their values remain and get used by the new inode.

---
 fs/inode.c | 6 ++++++
 1 file changed, 6 insertions(+)
fs/inode.c +6 -0
index 9f62db3..69b8b52 100644
@@ -154,6 +154,12 @@ int inode_init_always(struct super_block *sb, struct inode *inode)
 	inode->i_rdev = 0;
 	inode->dirtied_when = 0;
 
+#ifdef CONFIG_CGROUP_WRITEBACK
+	inode->i_wb_frn_winner = 0;
+	inode->i_wb_frn_avg_time = 0;
+	inode->i_wb_frn_history = 0;
+#endif
+
 	if (security_inode_alloc(inode))
 		goto out;
 	spin_lock_init(&inode->i_lock);
Signature · 1 line
2.7.0.rc3.207.g0ac5344
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Tahsin Erdogan

inode struct members that track cgroup writeback information should be reinitialized when inode gets allocated from kmem_cache. Otherwise, their values remain and get used by the new inode.

It might make sense to route this through block with the other writeback fix. Can you please repost with Jens Axboe <[email protected]> cc'd?

Thanks.

Signature · 1 line
tejun