writeback: initialize inode members that track writeback history
PATCH 1/1 writeback: initialize inode members that track writeback history
inode struct members that track cgroup writeback information should be reinitialized when inode gets allocated from kmem_cache. Otherwise, their values remain and get used by the new inode.
--- fs/inode.c | 6 ++++++ 1 file changed, 6 insertions(+)
fs/inode.c +6 -0
@@ -154,6 +154,12 @@ int inode_init_always(struct super_block *sb, struct inode *inode) inode->i_rdev =0 ; inode->dirtied_when =0 ; +#ifdef CONFIG_CGROUP_WRITEBACK + inode->i_wb_frn_winner =0 ; + inode->i_wb_frn_avg_time =0 ; + inode->i_wb_frn_history =0 ; +#endif +if (security_inode_alloc (inode)) goto out;spin_lock_init (&inode->i_lock);
Signature · 1 line
2.7.0.rc3.207.g0ac5344
Hello,
Quoted 7 lines · Tahsin Erdogan
inode struct members that track cgroup writeback information should be reinitialized when inode gets allocated from
kmem_cache. Otherwise, their values remain and get used by the new inode.Signed-off-by Tahsin Erdogan <[email protected]>Acked-by Tejun Heo <[email protected]>
This one should go for 4.5 and also prolly have the following tag.
Thanks.
Signature · 1 line
tejun
Quoted 8 lines · Tejun Heo
Hello,
Quoted 5 lines · Tahsin Erdogan
inode struct members that track cgroup writeback information should be reinitialized when inode gets allocated from
kmem_cache. Otherwise, their values remain and get used by the new inode.
Quoted 6 lines
Quoted 2 lines
Signed-off-by Tahsin Erdogan <[email protected]>Acked-by Tejun Heo <[email protected]>This one should go for 4.5 and also prolly have the following tag.
Fixes d10c80955265 ("writeback: implement foreign cgroup inode bdi_writeback switching")
I've added it for 4.5 with the fixes tag.
Signature · 1 line
Jens Axboe