Skip to contentSkip to conversation

package/links: add optional support for libevent

PATCH New Bernd Kuhls 2 participants 4 messages Feb 10, 2016 – Feb 20, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/links: add optional support for libevent

When libevent was compiled before, links will use it as optional dependency:

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/links | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [liblzma.so.5]
 0x00000001 (NEEDED)                     Shared library: [libbz2.so.1.0]
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
 0x00000001 (NEEDED)                     Shared library: [libevent-2.0.so.5]
 0x00000001 (NEEDED)                     Shared library: [libc.so.1]

(xz support will be added with the next patch of this series)

---
 package/links/links.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/links/links.mk +4 -0
index ba55061..b948de4 100644
@@ -39,6 +39,10 @@ ifeq ($(BR2_PACKAGE_BZIP2),y)
 LINKS_DEPENDENCIES += bzip2
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEVENT),y)
+LINKS_DEPENDENCIES += libevent
+endif
+
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 LINKS_DEPENDENCIES += openssl
 endif
Signature · 1 line
2.7.0
#1 lore raw

PATCH 2/2 package/links: add optional support for xz

When xz was compiled before, links will use it as optional dependency:

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/links | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [liblzma.so.5]
 0x00000001 (NEEDED)                     Shared library: [libbz2.so.1.0]
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
 0x00000001 (NEEDED)                     Shared library: [libevent-2.0.so.5]
 0x00000001 (NEEDED)                     Shared library: [libc.so.1]
---
 package/links/links.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/links/links.mk +4 -0
index b948de4..4d2cb2e 100644
@@ -47,6 +47,10 @@ ifeq ($(BR2_PACKAGE_OPENSSL),y)
 LINKS_DEPENDENCIES += openssl
 endif
 
+ifeq ($(BR2_PACKAGE_XZ),y)
+LINKS_DEPENDENCIES += xz
+endif
+
 ifeq ($(BR2_PACKAGE_ZLIB),y)
 LINKS_DEPENDENCIES += zlib
 endif
Signature · 1 line
2.7.0
#2 lore raw

PATCH 1/2 package/links: add optional support for libevent

In reply to Bernd Kuhls

Dear Bernd Kuhls,

Quoted 10 lines · Bernd Kuhls

When libevent was compiled before, links will use it as optional dependency:

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/links | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [liblzma.so.5]
 0x00000001 (NEEDED)                     Shared library: [libbz2.so.1.0]
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
 0x00000001 (NEEDED)                     Shared library: [libevent-2.0.so.5]
 0x00000001 (NEEDED)                     Shared library: [libc.so.1]
Quoted 6 lines

(xz support will be added with the next patch of this series)

---
 package/links/links.mk | 4 ++++
 1 file changed, 4 insertions(+)

I've applied both patches to master. However, could you send another patch that forces --with-<foo>/--without-<foo> ? Since we were not doing that for other dependencies, I applied your patches as-is, but I would like to see those options added explicitly.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/2 package/links: add optional support for libevent

Am Tue, 16 Feb 2016 23:11:04 +0100 schrieb Thomas Petazzoni:

Quoted 4 lines

I've applied both patches to master. However, could you send another patch that forces --with-<foo>/--without-<foo> ? Since we were not doing that for other dependencies, I applied your patches as-is, but I would like to see those options added explicitly.

Hi Thomas,

do you prefer the patches for the master or the next branch?

Regards, Bernd