Skip to contentSkip to conversation

package/gdb: add optional support for xz

PATCH New Bernd Kuhls 4 participants 14 messages Feb 10, 2016 – Feb 20, 2016

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH 1/1 package/gdb: add optional support for xz

When xz was compiled before, gdb will use it as optional dependency:

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/gdb | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [libdl.so.1]
 0x00000001 (NEEDED)                     Shared library: [libncurses.so.5]
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
 0x00000001 (NEEDED)                     Shared library: [libm.so.1]
 0x00000001 (NEEDED)                     Shared library: [liblzma.so.5]
 0x00000001 (NEEDED)                     Shared library: [libc.so.1]
Signed-off-by Bernd Kuhls <[email protected]>
---
 package/gdb/gdb.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/gdb/gdb.mk +7 -0
index 3b0f501..32d52eb 100644
@@ -118,6 +118,13 @@ else
 GDB_CONF_OPTS += --without-expat
 endif
 
+ifeq ($(BR2_PACKAGE_XZ),y)
+GDB_CONF_OPTS += --with-lzma
+GDB_DEPENDENCIES += xz
+else
+GDB_CONF_OPTS += --without-lzma
+endif
+
 ifeq ($(BR2_PACKAGE_ZLIB),y)
 GDB_CONF_OPTS += --with-zlib
 GDB_DEPENDENCIES += zlib
Signature · 1 line
2.7.0
author
#1 lore raw

PATCH 1/1 package/libarchive: add optional support for bzip2

When bzip2 was compiled before, libarchive will use it as optional dependency:

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/lib/libarchive.so.13.1.2 | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [liblzma.so.5]
 0x00000001 (NEEDED)                     Shared library: [libbz2.so.1.0]
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
 0x00000001 (NEEDED)                     Shared library: [libc.so.1]
Signed-off-by Bernd Kuhls <[email protected]>
---
 package/libarchive/libarchive.mk | 6 ++++++
 1 file changed, 6 insertions(+)
package/libarchive/libarchive.mk +6 -0
index 206de3f..f438d6e 100644
@@ -42,6 +42,12 @@ else
 LIBARCHIVE_CONF_OPTS += --disable-xattr
 endif
 
+ifeq ($(BR2_PACKAGE_BZIP2),y)
+LIBARCHIVE_DEPENDENCIES += bzip2
+else
+LIBARCHIVE_CONF_OPTS += --without-bz2lib
+endif
+
 ifeq ($(BR2_PACKAGE_EXPAT),y)
 LIBARCHIVE_DEPENDENCIES += expat
 else
Signature · 1 line
2.7.0
#2 lore raw

PATCH 1/1 package/libarchive: add optional support for bzip2

Quoted 19 lines · Bernd Kuhls

When bzip2 was compiled before, libarchive will use it as optional dependency:

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/lib/libarchive.so.13.1.2 | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [liblzma.so.5]
 0x00000001 (NEEDED)                     Shared library: [libbz2.so.1.0]
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
 0x00000001 (NEEDED)                     Shared library: [libc.so.1]
Signed-off-by Bernd Kuhls <[email protected]>
---
 package/libarchive/libarchive.mk | 6 ++++++
 1 file changed, 6 insertions(+)
package/libarchive/libarchive.mk +0 -0
index 206de3f..f438d6e 100644

package/libarchive/libarchive.mk else · line 46

Quoted 5 lines
package/libarchive/libarchive.mk +2 -0
@@ -42,6 +42,12 @@ else
 LIBARCHIVE_CONF_OPTS += --disable-xattr
 endif
 
+ifeq ($(BR2_PACKAGE_BZIP2),y)
+LIBARCHIVE_DEPENDENCIES += bzip2

No --with-bz2lib? If there is a good reason, mention it in the commit log.

Regards,
Arnout

Quoted 8 lines
package/libarchive/libarchive.mk +4 -0
+else
+LIBARCHIVE_CONF_OPTS += --without-bz2lib
+endif
+
 ifeq ($(BR2_PACKAGE_EXPAT),y)
 LIBARCHIVE_DEPENDENCIES += expat
 else
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#3 lore raw

PATCH 1/1 package/libarchive: add optional support for bzip2

Bernd,

Quoted 4 lines · Arnout Vandecappelle

package/libarchive/libarchive.mk else · line 46

Quoted 2 lines
package/libarchive/libarchive.mk +2 -0
+ifeq ($(BR2_PACKAGE_BZIP2),y)
+LIBARCHIVE_DEPENDENCIES += bzip2

No --with-bz2lib? If there is a good reason, mention it in the commit log.

Could you give some feedback on this?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#4 lore raw

PATCH 1/1 package/libarchive: add optional support for bzip2

In reply to Arnout Vandecappelle

Am Wed, 10 Feb 2016 22:19:07 +0100 schrieb Arnout Vandecappelle:

Quoted 2 lines

No --with-bz2lib? If there is a good reason, mention it in the commit log.

Hi Arnout,

libarchive always checks for bzip2 unless --without-bz2lib is used:
https://github.com/libarchive/libarchive/blob/master/configure.ac#L300

Therefore I see no need for --with-bz2lib and I also should not have added --with-lzma as well, I will send a patch removing it along with v2 of this patch explaining why --with-bz2lib is not needed.

Regards, Bernd

#5 lore raw

PATCH 1/1 package/libarchive: add optional support for bzip2

Quoted 5 lines · Bernd Kuhls

Am Wed, 10 Feb 2016 22:19:07 +0100 schrieb Arnout Vandecappelle:

Quoted 2 lines

No --with-bz2lib? If there is a good reason, mention it in the commit log.

Quoted 8 lines

Hi Arnout,

libarchive always checks for bzip2 unless --without-bz2lib is used:
https://github.com/libarchive/libarchive/blob/master/configure.ac#L300

Therefore I see no need for --with-bz2lib and I also should not have added --with-lzma as well, I will send a patch removing it along with v2 of this patch explaining why --with-bz2lib is not needed.

We prefer to have both an explicit enable and disable (or with and without)
because:

- it makes it simpler in case the default changes after a version bump;

- it makes it easier for other people to understand that the right thing is done (no need to check in configure what the default is);

- AFAIK the typical --enable/--with will give an error if the dependency is not found, which gives an extra safety net;

- we do it like this in other places, it's nice to see the same pattern everywhere.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
author
#6 lore raw

PATCH 1/1 package/tiff: add optional support for xz

In reply to Bernd Kuhls

When xz was compiled before, tiff will use it as optional dependency:

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/lib/libtiff.so.5.2.4 | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [liblzma.so.5]
 0x00000001 (NEEDED)                     Shared library: [libjpeg.so.9]
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
 0x00000001 (NEEDED)                     Shared library: [libm.so.1]
 0x00000001 (NEEDED)                     Shared library: [libc.so.1]
Signed-off-by Bernd Kuhls <[email protected]>
---
 package/tiff/Config.in | 4 ++++
 package/tiff/tiff.mk   | 6 ++++++
 2 files changed, 10 insertions(+)
package/tiff/Config.in +4 -0
index acb335c..00c2a3d 100644
@@ -41,6 +41,10 @@ config BR2_PACKAGE_TIFF_ZLIB
 	select BR2_PACKAGE_ZLIB
 	default y
 
+config BR2_PACKAGE_TIFF_XZ
+	bool "XZ compression"
+	select BR2_PACKAGE_XZ
+
 config BR2_PACKAGE_TIFF_PIXARLOG
 	bool "Pixar log-format algorithm (requires Zlib)"
 	select BR2_PACKAGE_TIFF_ZLIB
package/tiff/tiff.mk +6 -0
index c2e713c..266272a 100644
@@ -49,6 +49,12 @@ else
 TIFF_DEPENDENCIES += zlib
 endif
 
+ifneq ($(BR2_PACKAGE_TIFF_XZ),y)
+TIFF_CONF_OPTS += --disable-lzma
+else
+TIFF_DEPENDENCIES += xz
+endif
+
 ifneq ($(BR2_PACKAGE_TIFF_PIXARLOG),y)
 TIFF_CONF_OPTS += --disable-pixarlog
 endif
Signature · 1 line
2.7.0
Applied
#7 lore raw

PATCH 1/1 package/tiff: add optional support for xz

Dear Bernd Kuhls,

Quoted 9 lines · Bernd Kuhls

When xz was compiled before, tiff will use it as optional dependency:

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/lib/libtiff.so.5.2.4 | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [liblzma.so.5]
 0x00000001 (NEEDED)                     Shared library: [libjpeg.so.9]
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
 0x00000001 (NEEDED)                     Shared library: [libm.so.1]
 0x00000001 (NEEDED)                     Shared library: [libc.so.1]
Quoted 5 lines
Signed-off-by Bernd Kuhls <[email protected]>
---
 package/tiff/Config.in | 4 ++++
 package/tiff/tiff.mk   | 6 ++++++
 2 files changed, 10 insertions(+)

I've applied, but I would *really* like to see additional patches to use --enable-<foo> explicitly for all dependencies of the tiff package.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#8 lore raw

PATCH 1/1 package/gdb: add optional support for xz

In reply to Bernd Kuhls
Quoted 11 lines · Bernd Kuhls

When xz was compiled before, gdb will use it as optional dependency:

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/gdb | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [libdl.so.1]
 0x00000001 (NEEDED)                     Shared library: [libncurses.so.5]
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
 0x00000001 (NEEDED)                     Shared library: [libm.so.1]
 0x00000001 (NEEDED)                     Shared library: [liblzma.so.5]
 0x00000001 (NEEDED)                     Shared library: [libc.so.1]
Signed-off-by Bernd Kuhls <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

This should probably go in to 2016.02.

Regards,
Arnout

Quoted 23 lines
---
 package/gdb/gdb.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/gdb/gdb.mk +7 -0
index 3b0f501..32d52eb 100644
@@ -118,6 +118,13 @@ else
 GDB_CONF_OPTS += --without-expat
 endif
 
+ifeq ($(BR2_PACKAGE_XZ),y)
+GDB_CONF_OPTS += --with-lzma
+GDB_DEPENDENCIES += xz
+else
+GDB_CONF_OPTS += --without-lzma
+endif
+
 ifeq ($(BR2_PACKAGE_ZLIB),y)
 GDB_CONF_OPTS += --with-zlib
 GDB_DEPENDENCIES += zlib
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
author
#9 lore raw

PATCH 1/1 package/gdb: add optional support for xz

Am Wed, 10 Feb 2016 22:14:42 +0100 schrieb Arnout Vandecappelle:

Quoted 1 line

This should probably go in to 2016.02.

Hi @all,

in the coming days I will post 60-80 patches like this one for a variety of packages. Currently I only have a list of packages with missing dependencies, I have yet to prepare the patches for them. Because I consider them as bugfixes I sent the first patches based on git HEAD, shall I continue to do so?

Regards, Bernd

#10 lore raw

PATCH 1/1 package/gdb: add optional support for xz

Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Bernd" == Bernd Kuhls <[email protected]> writes:

Am Wed, 10 Feb 2016 22:14:42 +0100 schrieb Arnout Vandecappelle:

Quoted 1 line

This should probably go in to 2016.02.

Quoted 7 lines

Hi @all,

in the coming days I will post 60-80 patches like this one for a variety of packages. Currently I only have a list of packages with missing dependencies, I have yet to prepare the patches for them. Because I consider them as bugfixes I sent the first patches based on git HEAD, shall I continue to do so?

Yes, please.

Signature · 1 line
Bye, Peter Korsgaard
#11 lore raw

PATCH 1/1 package/gdb: add optional support for xz

In reply to Bernd Kuhls
Quoted 11 lines · Bernd Kuhls

When xz was compiled before, gdb will use it as optional dependency:

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/gdb | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [libdl.so.1]
 0x00000001 (NEEDED)                     Shared library: [libncurses.so.5]
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
 0x00000001 (NEEDED)                     Shared library: [libm.so.1]
 0x00000001 (NEEDED)                     Shared library: [liblzma.so.5]
 0x00000001 (NEEDED)                     Shared library: [libc.so.1]
Signed-off-by Bernd Kuhls <[email protected]>

This would obviously be needed for host-gdb as well, but that is impossible to
handle without explicit host Config.in options.

I really think we should go that way, there are several problems that need it.

Regards,
Arnout

Quoted 23 lines
---
 package/gdb/gdb.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/gdb/gdb.mk +7 -0
index 3b0f501..32d52eb 100644
@@ -118,6 +118,13 @@ else
 GDB_CONF_OPTS += --without-expat
 endif
 
+ifeq ($(BR2_PACKAGE_XZ),y)
+GDB_CONF_OPTS += --with-lzma
+GDB_DEPENDENCIES += xz
+else
+GDB_CONF_OPTS += --without-lzma
+endif
+
 ifeq ($(BR2_PACKAGE_ZLIB),y)
 GDB_CONF_OPTS += --with-zlib
 GDB_DEPENDENCIES += zlib
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#12 lore raw

PATCH 1/1 package/gdb: add optional support for xz

Dear Arnout Vandecappelle,

Quoted 4 lines · Arnout Vandecappelle

This would obviously be needed for host-gdb as well, but that is impossible to
handle without explicit host Config.in options.

I really think we should go that way, there are several problems that need it.

Or explicitly disable such features in host-gdb ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Applied
#13 lore raw

PATCH 1/1 package/gdb: add optional support for xz

In reply to Bernd Kuhls

Dear Bernd Kuhls,

Quoted 10 lines · Bernd Kuhls

When xz was compiled before, gdb will use it as optional dependency:

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/gdb | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [libdl.so.1]
 0x00000001 (NEEDED)                     Shared library: [libncurses.so.5]
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
 0x00000001 (NEEDED)                     Shared library: [libm.so.1]
 0x00000001 (NEEDED)                     Shared library: [liblzma.so.5]
 0x00000001 (NEEDED)                     Shared library: [libc.so.1]
Quoted 4 lines
Signed-off-by Bernd Kuhls <[email protected]>
---
 package/gdb/gdb.mk | 7 +++++++
 1 file changed, 7 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com