jsen: new package JSEN (JSON Sentinel) validates your JSON objects using JSON-Schema.
PATCH v2 1/1 jsen: new package JSEN (JSON Sentinel) validates your JSON objects using JSON-Schema.
Changes v1->v2
-Added the jsen under the javascript menu(as suggested by Thomas). -Updated the loop for retrieving the JSEN directories.
--- package/Config.in | 1 + package/jsen/Config.in | 6 ++++++ package/jsen/jsen.hash | 2 ++ package/jsen/jsen.mk | 20 ++++++++++++++++++++ 4 files changed, 29 insertions(+) create mode 100644 package/jsen/Config.in create mode 100644 package/jsen/jsen.hash create mode 100644 package/jsen/jsen.mk
package/Config.in +1 -0
@@ -985,6 +985,7 @@ menu "External jQuery plugins" endmenu endif source "package/jsmin/Config.in" + source "package/jsen/Config.in" source "package/json-javascript/Config.in" endmenu
package/jsen/Config.in new file +6 -0
@@ -0,0 +1,6 @@ +config BR2_PACKAGE_JSEN + bool "jsen" + help + JSEN (JSON Sentinel) validates your JSON objects using JSON-Schema. + + https://github.com/bugventure/jsen
package/jsen/jsen.hash new file +2 -0
@@ -0,0 +1,2 @@ +# Locally Computed +sha256 651b3ae5c92865705c144175a8297305788a0e9a1f46ee9b8caa127c6bce6709 jsen-v0.6.0.tar.gz
package/jsen/jsen.mk new file +20 -0
@@ -0,0 +1,20 @@ +################################################################################ +# +# jsen +# +################################################################################ + +JSEN_VERSION = v0.6.0 +JSEN_SITE = $(call github,bugventure,jsen,$(JSEN_VERSION)) +JSEN_LICENSE = MIT +JSEN_LICENSE_FILES = LICENSE +JSEN_DIRECTORIES_LIST = dist lib +JSEN_ROOT_FILES_LIST = index.js + +define JSEN_INSTALL_TARGET_CMDS + mkdir -p $(TARGET_DIR)/usr/share/jsen + $(foreach d,dist lib index.js,\ + cp -dpfr $(@D)/$(d) $(TARGET_DIR)/usr/share/jsen/$(sep)) +endef + +$(eval $(generic-package))
Signature · 1 line
2.5.0
PATCH v2 1/1 jsen: new package JSEN (JSON Sentinel) validates your JSON objects using JSON-Schema.
Dear Atul Singh,
Thanks for this new version. I could apply it by doing a few changes, but I prefer to give you a review so you know what the remaining issues are.
First the title of the commit should be:
jsen: new package
and nothing else. If you want to put some additional explanations, you need to separate it with an empty new line. Like this:
"""
jsen: new package
This new package adds the JSEN Javascript library. JSEN (JSON Sentinel) validates your JSON objectifs using JSON-Schema.
Signed-off-by: ....
"""
Review
Quoted 3 lines · Atul Singh
Changes
v1->v2(quoted diff) +0
-2-Added the jsen under the javascript menu(as suggested by Thomas). -Updated the loop for retrieving the JSEN directories.
It's very good to have a change log, but it should go....
Quoted 3 lines
Signed-off-by Atul Singh <[email protected]>---
... here, i.e after the "---" sign.
This way, the changelog is part of your patch (so I can see it when reviewing your patch) but it will not be integrated in the Git history as part of the commit log.
package/Config.in menu "External jQuery plugins" · line 989
Quoted 10 lines
package/Config.in +1
-0@@ -985,6 +985,7 @@ menu "External jQuery plugins" endmenu endif source "package/jsmin/Config.in" + source "package/jsen/Config.in" source "package/json-javascript/Config.in"
Alphabetic ordering it not correct here.
Quoted 7 lines
new file mode 100644
index 0000000..f5949aapackage/jsen/jsen.mk new file +2
-0@@ -0,0 +1,20 @@ +################################################################################ +#
package/jsen/jsen.mk line 12
Quoted 10 lines
package/jsen/jsen.mk new file +10
-0+# jsen +# +################################################################################ + +JSEN_VERSION = v0.6.0 +JSEN_SITE = $(call github,bugventure,jsen,$(JSEN_VERSION)) +JSEN_LICENSE = MIT +JSEN_LICENSE_FILES = LICENSE +JSEN_DIRECTORIES_LIST = dist lib +JSEN_ROOT_FILES_LIST = index.js
Those two variables are useless now.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com