drm/i915/bxt: Remove DSP CLK_GATE programming for BXT
Subsystems (2)
PATCH 1/1 drm/i915/bxt: Remove DSP CLK_GATE programming for BXT
From: Uma Shankar <[email protected]>
DSP CLK_GATE registers are specific to BYT and CHT. Avoid programming the same for BXT platform.
v2: Rebased on latest drm nightly branch.
v3: Fixed Jani's review comments
--- drivers/gpu/drm/i915/intel_dsi.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_dsi.c +7 -4
@@ -634,7 +634,6 @@ static void intel_dsi_post_disable(struct intel_encoder *encoder) {struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;struct intel_dsi *intel_dsi =enc_to_intel_dsi (&encoder->base); -u32 val;DRM_DEBUG_KMS ("\n" );
@@ -642,9 +641,13 @@ static void intel_dsi_post_disable(struct intel_encoder *encoder)intel_dsi_clear_device_ready (encoder); - val =I915_READ (DSPCLK_GATE_D ); - val &= ~DPOUNIT_CLOCK_GATE_DISABLE ; -I915_WRITE (DSPCLK_GATE_D , val); +if (!IS_BROXTON (dev_priv)) { +u32 val; + + val =I915_READ (DSPCLK_GATE_D ); + val &= ~DPOUNIT_CLOCK_GATE_DISABLE ; +I915_WRITE (DSPCLK_GATE_D , val); + }drm_panel_unprepare (intel_dsi->panel);
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Jani Nikula
From: Uma Shankar <[email protected]>
DSP
CLK_GATEregisters are specific to BYT and CHT. Avoid programming the same for BXT platform.v2: Rebased on latest drm nightly branch.
v3: Fixed Jani's review comments
Signed-off-by Uma Shankar <[email protected]>Signed-off-by Jani Nikula <[email protected]>
I gave up hoping to get CI results for this one, after two attempts. We have no coverage for this function anyway, and I've tested this before to not break BYT. Thus pushed to drm-intel-next-queued.
BR,
Jani.
Quoted 32 lines
--- drivers/gpu/drm/i915/intel_dsi.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/intel_dsi.c +7
-4@@ -634,7 +634,6 @@ static void intel_dsi_post_disable(struct intel_encoder *encoder) {struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;struct intel_dsi *intel_dsi =enc_to_intel_dsi (&encoder->base); -u32 val;DRM_DEBUG_KMS ("\n" );@@ -642,9 +641,13 @@ static void intel_dsi_post_disable(struct intel_encoder *encoder)intel_dsi_clear_device_ready (encoder); - val =I915_READ (DSPCLK_GATE_D ); - val &= ~DPOUNIT_CLOCK_GATE_DISABLE ; -I915_WRITE (DSPCLK_GATE_D , val); +if (!IS_BROXTON (dev_priv)) { +u32 val; + + val =I915_READ (DSPCLK_GATE_D ); + val &= ~DPOUNIT_CLOCK_GATE_DISABLE ; +I915_WRITE (DSPCLK_GATE_D , val); + }drm_panel_unprepare (intel_dsi->panel);
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/bxt: Remove DSP CLK_GATE programming for BXT (rev2)
In reply to Jani Nikula== Summary ==
== Summary ==
Series 3521v2 drm/i915/bxt: Remove DSP CLK_GATE programming for BXT
http://patchwork.freedesktop.org/api/1.0/series/3521/revisions/2/mbox/
Test kms_flip:
Subgroup basic-flip-vs-modeset:
pass -> INCOMPLETE (ilk-hp8440p) UNSTABLE
Test kms_force_connector_basic:
Subgroup force-connector-state:
pass -> SKIP (ivb-t430s)
Subgroup force-load-detect:
dmesg-fail -> FAIL (hsw-gt2)
fail -> SKIP (ivb-t430s)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
dmesg-warn -> PASS (skl-i5k-2) UNSTABLE
pass -> DMESG-WARN (skl-i7k-2) UNSTABLE
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (skl-i5k-2) UNSTABLE
dmesg-warn -> PASS (skl-i7k-2) UNSTABLE
Subgroup suspend-read-crc-pipe-c:
dmesg-warn -> PASS (bsw-nuc-2)
Test pm_rpm:
Subgroup basic-pci-d3-state:
fail -> PASS (bdw-ultra)bdw-nuci7 total:164 pass:153 dwarn:0 dfail:0 fail:0 skip:11 bdw-ultra total:167 pass:153 dwarn:0 dfail:0 fail:0 skip:14 bsw-nuc-2 total:167 pass:136 dwarn:1 dfail:0 fail:0 skip:30 byt-nuc total:167 pass:141 dwarn:1 dfail:0 fail:0 skip:25 hsw-gt2 total:167 pass:156 dwarn:0 dfail:0 fail:1 skip:10 ilk-hp8440p total:113 pass:79 dwarn:1 dfail:0 fail:0 skip:32 ivb-t430s total:167 pass:151 dwarn:0 dfail:0 fail:0 skip:16 skl-i5k-2 total:167 pass:150 dwarn:1 dfail:0 fail:0 skip:16 skl-i7k-2 total:167 pass:150 dwarn:1 dfail:0 fail:0 skip:16 snb-dellxps total:167 pass:144 dwarn:0 dfail:0 fail:1 skip:22
Results at /archive/results/CI_IGT_test/Patchwork_1434/
094be102b10f6acd9b670b327e2363d49c09a65c drm-intel-nightly: 2016y-02m-18d-09h-43m-08s UTC integration manifest 70b416e188df67c1d908e6e8363ac21f9c5ce3f7 drm/i915/bxt: Remove DSP CLK_GATE programming for BXT
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx