Skip to contentSkip to conversation

package/links: With or without you ;)

PATCH Superseded Bernd Kuhls 3 participants 22 messages Feb 20, 2016 – Feb 21, 2016

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover package/links: With or without you ;)

Hi,

this patch series adds --with/--without to CONF_OPTS as requested by
Thomas: http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/140285

Regards, Bernd

Bernd Kuhls (8):
package/links: add --with/--without-zlib
package/links: add --with/--without-lzma
package/links: add --with/--without-ssl
package/links: add --with/--without-libevent
package/links: add --with/--without-bzip2
package/links: add --with/--without-libtiff
package/links: add --disable-graphics
package/links: add --with/--without-libjpeg

 package/links/links.mk | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
Signature · 1 line
2.7.0
#1 lore raw

PATCH 1/8 package/links: add --with/--without-zlib

---
 package/links/links.mk | 3 +++
 1 file changed, 3 insertions(+)
package/links/links.mk +3 -0
index 4d2cb2e..8d7ecba 100644
@@ -52,7 +52,10 @@ LINKS_DEPENDENCIES += xz
 endif
 
 ifeq ($(BR2_PACKAGE_ZLIB),y)
+LINKS_CONF_OPTS += --with-zlib
 LINKS_DEPENDENCIES += zlib
+else
+LINKS_CONF_OPTS += --without-zlib
 endif
 
 $(eval $(autotools-package))
Signature · 1 line
2.7.0
#2 lore raw

PATCH 1/8 package/links: add --with/--without-zlib

Bernd, All,

On 2016-02-20 17:40 +0100, Bernd Kuhls spake thusly:

Quoted 1 line

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 package/links/links.mk | 3 +++
 1 file changed, 3 insertions(+)
package/links/links.mk +3 -0
index 4d2cb2e..8d7ecba 100644
@@ -52,7 +52,10 @@ LINKS_DEPENDENCIES += xz
 endif
 
 ifeq ($(BR2_PACKAGE_ZLIB),y)
+LINKS_CONF_OPTS += --with-zlib
 LINKS_DEPENDENCIES += zlib
+else
+LINKS_CONF_OPTS += --without-zlib
 endif
 
 $(eval $(autotools-package))
Signature · 6 lines
2.7.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 2/8 package/links: add --with/--without-lzma

In reply to Bernd Kuhls
---
 package/links/links.mk | 3 +++
 1 file changed, 3 insertions(+)
package/links/links.mk +3 -0
index 8d7ecba..3515e5f 100644
@@ -48,7 +48,10 @@ LINKS_DEPENDENCIES += openssl
 endif
 
 ifeq ($(BR2_PACKAGE_XZ),y)
+LINKS_CONF_OPTS += --with-lzma
 LINKS_DEPENDENCIES += xz
+else
+LINKS_CONF_OPTS += --without-lzma
 endif
 
 ifeq ($(BR2_PACKAGE_ZLIB),y)
Signature · 1 line
2.7.0
#4 lore raw

PATCH 2/8 package/links: add --with/--without-lzma

Bernd, All,

On 2016-02-20 17:40 +0100, Bernd Kuhls spake thusly:

Quoted 1 line

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 package/links/links.mk | 3 +++
 1 file changed, 3 insertions(+)
package/links/links.mk +3 -0
index 8d7ecba..3515e5f 100644
@@ -48,7 +48,10 @@ LINKS_DEPENDENCIES += openssl
 endif
 
 ifeq ($(BR2_PACKAGE_XZ),y)
+LINKS_CONF_OPTS += --with-lzma
 LINKS_DEPENDENCIES += xz
+else
+LINKS_CONF_OPTS += --without-lzma
 endif
 
 ifeq ($(BR2_PACKAGE_ZLIB),y)
Signature · 6 lines
2.7.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#5 lore raw

PATCH 3/8 package/links: add --with/--without-ssl

In reply to Bernd Kuhls
---
 package/links/links.mk | 3 +++
 1 file changed, 3 insertions(+)
package/links/links.mk +3 -0
index 3515e5f..3a4519f 100644
@@ -44,7 +44,10 @@ LINKS_DEPENDENCIES += libevent
 endif
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LINKS_CONF_OPTS += --with-ssl=$(STAGING_DIR)/usr --enable-ssl-pkgconfig
 LINKS_DEPENDENCIES += openssl
+else
+LINKS_CONF_OPTS += --without-ssl
 endif
 
 ifeq ($(BR2_PACKAGE_XZ),y)
Signature · 1 line
2.7.0
#6 lore raw

PATCH 3/8 package/links: add --with/--without-ssl

Bernd, All,

On 2016-02-20 17:40 +0100, Bernd Kuhls spake thusly:

Quoted 10 lines
---
 package/links/links.mk | 3 +++
 1 file changed, 3 insertions(+)
package/links/links.mk +0 -0
index 3515e5f..3a4519f 100644

package/links/links.mk LINKS_DEPENDENCIES += libevent · line 47

Quoted 4 lines
package/links/links.mk +1 -0
@@ -44,7 +44,10 @@ LINKS_DEPENDENCIES += libevent
 endif
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LINKS_CONF_OPTS += --with-ssl=$(STAGING_DIR)/usr --enable-ssl-pkgconfig

So, even when using pkg-config, we still need to tell it where OpenSSL is located?

Regards,
Yann E. MORIN.

Quoted 13 lines
package/links/links.mk +2 -0
 LINKS_DEPENDENCIES += openssl
+else
+LINKS_CONF_OPTS += --without-ssl
 endif
 
 ifeq ($(BR2_PACKAGE_XZ),y)
Signature · 6 lines
2.7.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#7 lore raw

PATCH 3/8 package/links: add --with/--without-ssl

Am Sat, 20 Feb 2016 18:43:48 +0100 schrieb Yann E. MORIN:

Quoted 6 lines
Quoted 3 lines

ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LINKS_CONF_OPTS += --with-ssl=$(STAGING_DIR)/usr
--enable-ssl-pkgconfig

So, even when using pkg-config, we still need to tell it where OpenSSL is located?

Hi,

no, it works without the path to $STAGING_DIR, I just wanted to make sure ;)

Regards, Bernd

#8 lore raw

PATCH 3/8 package/links: add --with/--without-ssl

Bernd, All,

On 2016-02-20 18:47 +0100, Bernd Kuhls spake thusly:

Quoted 11 lines

Am Sat, 20 Feb 2016 18:43:48 +0100 schrieb Yann E. MORIN:

Quoted 6 lines
Quoted 3 lines

ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LINKS_CONF_OPTS += --with-ssl=$(STAGING_DIR)/usr
--enable-ssl-pkgconfig

So, even when using pkg-config, we still need to tell it where OpenSSL is located?

no, it works without the path to $STAGING_DIR, I just wanted to make sure ;)

Then do not provide it, please.

Thanks!

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#10 lore raw

PATCH 4/8 package/links: add --with/--without-libevent

In reply to Bernd Kuhls
---
 package/links/links.mk | 3 +++
 1 file changed, 3 insertions(+)
package/links/links.mk +3 -0
index 3a4519f..847d311 100644
@@ -40,7 +40,10 @@ LINKS_DEPENDENCIES += bzip2
 endif
 
 ifeq ($(BR2_PACKAGE_LIBEVENT),y)
+LINKS_CONF_OPTS += --with-libevent
 LINKS_DEPENDENCIES += libevent
+else
+LINKS_CONF_OPTS += --without-libevent
 endif
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
Signature · 1 line
2.7.0
#11 lore raw

PATCH 4/8 package/links: add --with/--without-libevent

Bernd, All,

On 2016-02-20 17:40 +0100, Bernd Kuhls spake thusly:

Quoted 1 line

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 package/links/links.mk | 3 +++
 1 file changed, 3 insertions(+)
package/links/links.mk +3 -0
index 3a4519f..847d311 100644
@@ -40,7 +40,10 @@ LINKS_DEPENDENCIES += bzip2
 endif
 
 ifeq ($(BR2_PACKAGE_LIBEVENT),y)
+LINKS_CONF_OPTS += --with-libevent
 LINKS_DEPENDENCIES += libevent
+else
+LINKS_CONF_OPTS += --without-libevent
 endif
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
Signature · 6 lines
2.7.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#12 lore raw

PATCH 5/8 package/links: add --with/--without-bzip2

In reply to Bernd Kuhls
---
 package/links/links.mk | 3 +++
 1 file changed, 3 insertions(+)
package/links/links.mk +3 -0
index 847d311..26af392 100644
@@ -36,7 +36,10 @@ endif
 endif
 
 ifeq ($(BR2_PACKAGE_BZIP2),y)
+LINKS_CONF_OPTS += --with-bzip2
 LINKS_DEPENDENCIES += bzip2
+else
+LINKS_CONF_OPTS += --without-bzip2
 endif
 
 ifeq ($(BR2_PACKAGE_LIBEVENT),y)
Signature · 1 line
2.7.0
#13 lore raw

PATCH 5/8 package/links: add --with/--without-bzip2

Bernd, All,

On 2016-02-20 17:40 +0100, Bernd Kuhls spake thusly:

Quoted 1 line

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 package/links/links.mk | 3 +++
 1 file changed, 3 insertions(+)
package/links/links.mk +3 -0
index 847d311..26af392 100644
@@ -36,7 +36,10 @@ endif
 endif
 
 ifeq ($(BR2_PACKAGE_BZIP2),y)
+LINKS_CONF_OPTS += --with-bzip2
 LINKS_DEPENDENCIES += bzip2
+else
+LINKS_CONF_OPTS += --without-bzip2
 endif
 
 ifeq ($(BR2_PACKAGE_LIBEVENT),y)
Signature · 6 lines
2.7.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#14 lore raw

PATCH 6/8 package/links: add --with/--without-libtiff

In reply to Bernd Kuhls
---
 package/links/links.mk | 3 +++
 1 file changed, 3 insertions(+)
package/links/links.mk +3 -0
index 26af392..3486d94 100644
@@ -31,7 +31,10 @@ ifeq ($(BR2_PACKAGE_JPEG),y)
 LINKS_DEPENDENCIES += jpeg
 endif
 ifeq ($(BR2_PACKAGE_TIFF),y)
+LINKS_CONF_OPTS += --with-libtiff
 LINKS_DEPENDENCIES += tiff
+else
+LINKS_CONF_OPTS += --without-libtiff
 endif
 endif
 
Signature · 1 line
2.7.0
#15 lore raw

PATCH 6/8 package/links: add --with/--without-libtiff

Bernd, All,

On 2016-02-20 17:40 +0100, Bernd Kuhls spake thusly:

Quoted 1 line

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 package/links/links.mk | 3 +++
 1 file changed, 3 insertions(+)
package/links/links.mk +3 -0
index 26af392..3486d94 100644
@@ -31,7 +31,10 @@ ifeq ($(BR2_PACKAGE_JPEG),y)
 LINKS_DEPENDENCIES += jpeg
 endif
 ifeq ($(BR2_PACKAGE_TIFF),y)
+LINKS_CONF_OPTS += --with-libtiff
 LINKS_DEPENDENCIES += tiff
+else
+LINKS_CONF_OPTS += --without-libtiff
 endif
 endif
 
Signature · 6 lines
2.7.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#16 lore raw

PATCH 7/8 package/links: add --disable-graphics

In reply to Bernd Kuhls
---
 package/links/links.mk | 2 ++
 1 file changed, 2 insertions(+)
package/links/links.mk +2 -0
index 3486d94..f42f21c 100644
@@ -36,6 +36,8 @@ LINKS_DEPENDENCIES += tiff
 else
 LINKS_CONF_OPTS += --without-libtiff
 endif
+else
+LINKS_CONF_OPTS += --disable-graphics
 endif
 
 ifeq ($(BR2_PACKAGE_BZIP2),y)
Signature · 1 line
2.7.0
#17 lore raw

PATCH 7/8 package/links: add --disable-graphics

Bernd, All,

On 2016-02-20 17:40 +0100, Bernd Kuhls spake thusly:

Quoted 1 line

Regards,
Yann E. MORIN.

Quoted 24 lines
---
 package/links/links.mk | 2 ++
 1 file changed, 2 insertions(+)
package/links/links.mk +2 -0
index 3486d94..f42f21c 100644
@@ -36,6 +36,8 @@ LINKS_DEPENDENCIES += tiff
 else
 LINKS_CONF_OPTS += --without-libtiff
 endif
+else
+LINKS_CONF_OPTS += --disable-graphics
 endif
 
 ifeq ($(BR2_PACKAGE_BZIP2),y)
Signature · 6 lines
2.7.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#18 lore raw

PATCH 8/8 package/links: add --with/--without-libjpeg

In reply to Bernd Kuhls
---
 package/links/links.mk | 3 +++
 1 file changed, 3 insertions(+)
package/links/links.mk +3 -0
index f42f21c..b62889f 100644
@@ -28,7 +28,10 @@ else
 LINKS_CONF_OPTS += --without-directfb
 endif
 ifeq ($(BR2_PACKAGE_JPEG),y)
+LINKS_CONF_OPTS += --with-libjpeg
 LINKS_DEPENDENCIES += jpeg
+else
+LINKS_CONF_OPTS += --without-libjpeg
 endif
 ifeq ($(BR2_PACKAGE_TIFF),y)
 LINKS_CONF_OPTS += --with-libtiff
Signature · 1 line
2.7.0
#19 lore raw

PATCH 8/8 package/links: add --with/--without-libjpeg

Bernd, All,

On 2016-02-20 17:40 +0100, Bernd Kuhls spake thusly:

Quoted 1 line

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 package/links/links.mk | 3 +++
 1 file changed, 3 insertions(+)
package/links/links.mk +3 -0
index f42f21c..b62889f 100644
@@ -28,7 +28,10 @@ else
 LINKS_CONF_OPTS += --without-directfb
 endif
 ifeq ($(BR2_PACKAGE_JPEG),y)
+LINKS_CONF_OPTS += --with-libjpeg
 LINKS_DEPENDENCIES += jpeg
+else
+LINKS_CONF_OPTS += --without-libjpeg
 endif
 ifeq ($(BR2_PACKAGE_TIFF),y)
 LINKS_CONF_OPTS += --with-libtiff
Signature · 6 lines
2.7.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#20 lore raw

cover package/links: With or without you ;)

In reply to Bernd Kuhls

Bernds, All,

Aha, I see I'm not the only one providing little jokes in the commit logs/titles! Thanks for the good laugh! ;-)

On 2016-02-20 17:40 +0100, Bernd Kuhls spake thusly:

Quoted 5 lines

this patch series adds --with/--without to CONF_OPTS as requested by
Thomas: http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/140285

Regards, Bernd

Quoted 9 lines

Bernd Kuhls (8):
package/links: add --with/--without-zlib
package/links: add --with/--without-lzma
package/links: add --with/--without-ssl
package/links: add --with/--without-libevent
package/links: add --with/--without-bzip2
package/links: add --with/--without-libtiff
package/links: add --disable-graphics
package/links: add --with/--without-libjpeg

I'll be reviewing those in a moment...

Regards,
Yann E. MORIN.

Quoted 10 lines
 package/links/links.mk | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
Signature · 6 lines
2.7.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#21 lore raw

cover package/links: With or without you ;)

In reply to Bernd Kuhls

Dear Bernd Kuhls,

Quoted 3 lines · Bernd Kuhls

Bernd Kuhls (8):
package/links: add --with/--without-zlib
package/links: add --with/--without-lzma

Applied.

Quoted 1 line
  package/links: add --with/--without-ssl

Not yet applied (I'll apply v2)

Quoted 5 lines
  package/links: add --with/--without-libevent
  package/links: add --with/--without-bzip2
  package/links: add --with/--without-libtiff
  package/links: add --disable-graphics
  package/links: add --with/--without-libjpeg

Applied.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com