qt5tools: new package
PATCH v4 1/1 qt5tools: new package
- host programs: lconvert, lrelease and lupdate
- target programs: pixeltool, qtdiag, qtpath and qtplugininfo
---
Changes v3 -> v4:
- fix trailing whitespace
Changes v2 -> v3:
- rebased (update to qt-5.5.1)
- drop unneeded select libpng line (Thomas Petazzoni)
- drop unneeded line break (Thomas Petazzoni)
- pixeltool needs BR2_PACKAGE_QT5BASE_GUI and BR2_PACKAGE_QT5BASE_WIDGETS too
- use foreach instead of repetitive open coding (Thomas Petazzoni)
- install host tools to host directory instead of staging directory (Thomas Petazzoni)
- add more comment about linguist tools dependency on qt5declarative (Thomas Petazzoni)
Changes v1 -> v2:
- add target programs, reword commit message
--- package/qt5/Config.in | 1 + package/qt5/qt5tools/Config.in | 42 ++++++++++++++++++++++++ package/qt5/qt5tools/qt5tools.hash | 2 ++ package/qt5/qt5tools/qt5tools.mk | 67 ++++++++++++++++++++++++++++++++++++++ 4 files changed, 112 insertions(+) create mode 100644 package/qt5/qt5tools/Config.in create mode 100644 package/qt5/qt5tools/qt5tools.hash create mode 100644 package/qt5/qt5tools/qt5tools.mk
package/qt5/Config.in +1 -0
@@ -42,6 +42,7 @@ source "package/qt5/qt5quickcontrols/Config.in" source "package/qt5/qt5sensors/Config.in" source "package/qt5/qt5serialport/Config.in" source "package/qt5/qt5svg/Config.in" +source "package/qt5/qt5tools/Config.in" source "package/qt5/qt5webchannel/Config.in" source "package/qt5/qt5websockets/Config.in" source "package/qt5/qt5x11extras/Config.in"
package/qt5/qt5tools/Config.in new file +42 -0
42 lines not on this page · raw message
package/qt5/qt5tools/qt5tools.hash new file +2 -0
@@ -0,0 +1,2 @@ +# Hash from: http://download.qt.io/official_releases/qt/5.5/5.5.1/submodules/qttools-opensource-src-5.5.1.tar.xz.mirrorlist +sha256 4361f6ce49717058160908297841a18b94645cec593d1b48fb126c9d06c87bfd qttools-opensource-src-5.5.1.tar.xz
package/qt5/qt5tools/qt5tools.mk new file +67 -0
67 lines not on this page · raw message
Signature · 1 line
2.1.4
PATCH v4 1/1 qt5tools: new package
Hello Peter,
I tested your patch to build the QT5 Linguistic Tools, and it worked well :)
However I have one comment:
Review
Quoted 2 lines · Peter Seiderer
(quoted diff) +2
-0+ +define QT5TOOLS_INSTALL_STAGING_CMDS
I think you need to call the 'install' target here, to install the QT5 Tools cmake modules in the host directory:
$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install
package/qt5/qt5tools/qt5tools.mk line 60
Quoted 3 lines
package/qt5/qt5tools/qt5tools.mk new file +3
-0+ $(foreach p,$(QT5TOOLS_INSTALL_STAGING_y), \ + $(INSTALL) -D -m0755 $(@D)/bin/$(p) $(HOST_DIR)/usr/bin/$(p)$(sep)) +endef
Thanks,
Antoine
Signature · 10 lines
Antoine T?nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160219/08621b59/attachment.asc>
PATCH v4 1/1 qt5tools: new package
Hello Antoine Tenart,
Quoted 5 lines · Antoine Tenart
Hello Peter,
I tested your patch to build the QT5 Linguistic Tools, and it worked well :)
Thanks for testing...
Quoted 11 lines
However I have one comment:
Review
Quoted 2 lines · Peter Seiderer
(quoted diff) +2
-0+ +define QT5TOOLS_INSTALL_STAGING_CMDSI think you need to call the 'install' target here, to install the QT5 Tools cmake modules in the host directory:
$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install
Thanks for the hint, will send an updated patch soon, mind to give the cmake part a little test?
Regards,
Peter
Quoted 8 lines
package/qt5/qt5tools/qt5tools.mk line 60
Quoted 3 lines
package/qt5/qt5tools/qt5tools.mk new file +3
-0+ $(foreach p,$(QT5TOOLS_INSTALL_STAGING_y), \ + $(INSTALL) -D -m0755 $(@D)/bin/$(p) $(HOST_DIR)/usr/bin/$(p)$(sep)) +endefThanks,
Antoine