staging: rts5208: Removed unnecessary return variable

PATCH New Bhaktipriya Shridhar 1 participant 1 message Feb 21, 2016 Staging

lore

Share & tools

lore

Bhaktipriya Shridhar

author

2016-02-21 07:34 UTC #0 lore raw

PATCH 1/1 staging: rts5208: Removed unnecessary return variable

This patch removes unnecessary return variables in switch statements. This was done with Coccinelle:

@@ local idexpression ret; expression e1,e2; identifier label; @@
switch ( ... ) {
case label : ...
- ret = e1;
- break;
+ return e1;
... default: ...
- ret = e2;
+ return e2;
... }
... when != ret
- return ret;
@@ type T; identifier x; @@
- T x;
... when != x

Signed-off-by Bhaktipriya Shridhar <[email protected]>

---
 drivers/staging/rts5208/rtsx_scsi.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

drivers/staging/rts5208/rtsx_scsi.c +2 -7

index 60871f3..16284ca 100644
@@ -1931,20 +1931,15 @@ static int rw_mem_cmd_buf(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 
 static int suit_cmd(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 {
-	int result;
-
 	switch (srb->cmnd[3]) {
 	case INIT_BATCHCMD:
 	case ADD_BATCHCMD:
 	case SEND_BATCHCMD:
 	case GET_BATCHRSP:
-		result = rw_mem_cmd_buf(srb, chip);
-		break;
+		return rw_mem_cmd_buf(srb, chip);
 	default:
-		result = TRANSPORT_ERROR;
+		return TRANSPORT_ERROR;
 	}
-
-	return result;
 }
 
 static int read_phy_register(struct scsi_cmnd *srb, struct rtsx_chip *chip)

--
2.1.4