Skip to contentSkip to conversation

package/lftp: add optional support for expat

PATCH New Bernd Kuhls 2 participants 2 messages Feb 20, 2016 – Feb 21, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/lftp: add optional support for expat

When expat was compiled before, the proto-http module will use it as optional dependency:

$ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/lib/lftp/4.6.4/proto-http.so | grep NEEDED | sort
 0x0000000000000001 (NEEDED)             Shared library: [libcrypto.so.1.0.0]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libdl.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libexpat.so.1]
[...]

The build system offers no option to en-/disable expat support:
https://github.com/lavv17/lftp/blob/lftp-4.6-stable/configure.ac#L337

---
 package/lftp/lftp.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/lftp/lftp.mk +4 -0
index d2d58fd..5051f70 100644
@@ -17,6 +17,10 @@ ifneq ($(BR2_STATIC_LIBS),y)
 LFTP_CONF_OPTS += --with-modules
 endif
 
+ifeq ($(BR2_PACKAGE_EXPAT)$(BR2_PACKAGE_LFTP_PROTO_HTTP),yy)
+LFTP_DEPENDENCIES += expat
+endif
+
 ifeq ($(BR2_PACKAGE_GNUTLS),y)
 LFTP_DEPENDENCIES += gnutls
 LFTP_CONF_OPTS += --with-gnutls
Signature · 1 line
2.7.0
#1 lore raw

PATCH 1/1 package/lftp: add optional support for expat

Dear Bernd Kuhls,

Quoted 10 lines · Bernd Kuhls

When expat was compiled before, the proto-http module will use it as optional dependency:

$ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/lib/lftp/4.6.4/proto-http.so | grep NEEDED | sort
 0x0000000000000001 (NEEDED)             Shared library: [libcrypto.so.1.0.0]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libdl.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libexpat.so.1]
[...]
Quoted 7 lines

The build system offers no option to en-/disable expat support:
https://github.com/lavv17/lftp/blob/lftp-4.6-stable/configure.ac#L337

---
 package/lftp/lftp.mk | 4 ++++
 1 file changed, 4 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com