Skip to contentSkip to conversation

package/dhcp: bump version to 4.3.3-P1

PATCH New Doug Kehn 4 participants 4 messages Feb 17, 2016 – Feb 21, 2016

lore
Share & tools
lore

Doug Kehn

author
#0 lore raw

PATCH v9 1/1 package/dhcp: bump version to 4.3.3-P1

bind source tar-ball is now embedded into the dhcp source. The embedded bind tar-ball is extracted after the dhcp source so cross compiling patches can be applied to the dhcp and bind before the package is built.

The embedded bind configure is called as part of dhcp make instead of dhcp configure; therefore, needed configure parameters are set in the make env.

0001-dhcp-cross-compile.patch and 0002-bind-cross-compile.patch have been submitted upstream as part of a cross compiling enhancement suggestion to dhcp-suggest at isc.org. Reference ISC-Bugs #41502. 0003-bind-hos-cc.patch is already scheduled for the next dhcp release.

Buildroot thread

	http://lists.busybox.net/pipermail/buildroot/2016-January/149079.html

has related information.

Cc Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Cc Ricardo Martincoski <[email protected]>

---
Changes v8 -> v9
- change HOST_CXXFLAGS to HOST_CPPFLAGS (suggested by Ricardo)
Changes v7 -> v8
- add additional HOST defines (suggested by Arnout)
Changes v6 -> v7
- fix typo in hash (suggested by Ricardo)
Changes v5 -> v6
- patch configure.ac instead of configure/Makefile.in (suggested by Arnout)
- rework dhcp.mk for patch changes.
Changes v4 -> v5
- update hash reference (suggested by Arnout)
- expand comments (suggested by Arnout)
Changes v3 -> v4
- consolidate into single patch (suggested by Arnout)
- separate into POST_CONFIGURE_HOOK & PRE_BUILD_HOOK (suggested by Arnout)
Changes v2 -> v3
- removed RFC tag
- updated version from 4.3.3 to 4.3.3-P1 (suggested by Ricardo)
- external toolchain support (suggested by Ricardo)
Changes v1 -> v2
- removed DHCP_PRE_BUILD_HOOKS in favor of patch (suggested by Arnout)

---
 package/dhcp/0001-dhcp-cross-compile.patch | 34 +++++++++++++++++++++++++
 package/dhcp/0002-bind-cross-compile.patch | 24 ++++++++++++++++++
 package/dhcp/0003-bind-host-cc.patch       | 40 ++++++++++++++++++++++++++++++
 package/dhcp/dhcp.hash                     |  4 +--
 package/dhcp/dhcp.mk                       | 28 +++++++++++++++++++--
 5 files changed, 126 insertions(+), 4 deletions(-)
 create mode 100644 package/dhcp/0001-dhcp-cross-compile.patch
 create mode 100644 package/dhcp/0002-bind-cross-compile.patch
 create mode 100644 package/dhcp/0003-bind-host-cc.patch
package/dhcp/0001-dhcp-cross-compile.patch new file +34 -0
new file mode 100644
index 0000000..95b4689
@@ -0,0 +1,34 @@
+dhcp cross compile support integration
+
+Allow BINDCONFIG to be initialized in environment passed to configure.
+
+Allow archiver to be determined during configure.
+
+This patch is submitted upstream as part of a cross compiling enhancement
+suggestion to dhcp-suggest at isc.org. Reference ISC-Bugs #41502.
+
+Signed-off-by: Doug Kehn <[email protected]>
+
+Index: dhcp-4.3.3-P1/configure.ac
+===================================================================
+--- dhcp-4.3.3-P1.orig/configure.ac
++++ dhcp-4.3.3-P1/configure.ac
+@@ -33,7 +33,7 @@ if test "$GCC" = "yes"; then
+ fi
+ 
+ # We can have some flags to pass to bind configure
+-BINDCONFIG=
++BINDCONFIG="$BINDCONFIG"
+ AC_SUBST(BINDCONFIG)
+ 
+ # POSIX doesn't include the IPv6 Advanced Socket API and glibc hides
+@@ -43,6 +43,9 @@ AC_SUBST(BINDCONFIG)
+ # Use this to define _GNU_SOURCE to pull in the IPv6 Advanced Socket API.
+ AC_USE_SYSTEM_EXTENSIONS
+ 
++AC_CHECK_TOOL(AR,ar)
++AC_SUBST(AR)
++
+ AC_PROG_RANLIB
+ AC_CONFIG_HEADERS([includes/config.h])
+ 
package/dhcp/0002-bind-cross-compile.patch new file +24 -0
new file mode 100644
index 0000000..f7c42c6
@@ -0,0 +1,24 @@
+bind cross compile support integration
+
+Pass system types from dhcp configure to bind configure.
+
+This patch is submitted upstream as part of a cross compiling enhancement
+suggestion to dhcp-suggest at isc.org. Reference ISC-Bugs #41502.
+
+Signed-off-by: Doug Kehn <[email protected]>
+
+Index: dhcp-4.3.3-P1/bind/Makefile.in
+===================================================================
+--- dhcp-4.3.3-P1.orig/bind/Makefile.in
++++ dhcp-4.3.3-P1/bind/Makefile.in
+@@ -30,7 +30,9 @@ bindconfig = --disable-kqueue --disable-
+ 	--without-openssl --without-libxml2 --enable-exportlib \
+ 	--with-gssapi=no --enable-threads=no @BINDCONFIG@ \
+ 	--with-export-includedir=${binddir}/include \
+-	--with-export-libdir=${binddir}/lib
++	--with-export-libdir=${binddir}/lib \
++	--target=@target_alias@ --host=@host_alias@ \
++	--build=@build_alias@
+ 
+ @BIND_ATF_FALSE at cleandirs = ./lib ./include
+ @BIND_ATF_TRUE at cleandirs = ./lib ./include ./atf
package/dhcp/0003-bind-host-cc.patch new file +40 -0
new file mode 100644
index 0000000..96c144f
@@ -0,0 +1,40 @@
+ensure host compiler is used
+
+dns/Makefile.in patch is derived from:
+http://wiki.beyondlogic.org/patches/dhcp-4.3.0b1.bind_arm-linux-gnueabi.patch
+
+This patch is already accepted upstream and will be included in the next
+release:
+--[snip]--
+From Francis Dupont via RT <[email protected]>
+To   rdkehn at yahoo.com 
+
+Message body
+It was fixed on the master branch sometimes ago.
+Quoting master RELNOTES:
+
+- Made the embedded bind libraries able to be cross compiled
+  (please refer to the bind9 documentation to learn how to cross
+  compile DHCP and its bind library dependency).
+  [ISC-Bugs #38836]
+
+This is in the Changes since 4.3.3 so for the next release.
+--[snip]--
+
+Signed-off-by: Doug Kehn <[email protected]>
+
+Index: dhcp-4.3.3-P1/bind/bind-9.9.7-P3/lib/export/dns/Makefile.in
+===================================================================
+--- dhcp-4.3.3-P1.orig/bind/bind-9.9.7-P3/lib/export/dns/Makefile.in
++++ dhcp-4.3.3-P1/bind/bind-9.9.7-P3/lib/export/dns/Makefile.in
+@@ -168,7 +168,9 @@ code.h:	gen
+ 	./gen -s ${srcdir} > code.h
+ 
+ gen: ${srcdir}/gen.c
+-	${CC} ${ALL_CFLAGS} ${LDFLAGS} -o $@ ${srcdir}/gen.c ${LIBS}
++	${BUILD_CC} ${BUILD_CFLAGS} -I${top_srcdir}/lib/isc/include \
++		${BUILD_CPPFLAGS} ${BUILD_LDFLAGS} -o $@ ${srcdir}/gen.c \
++		${BUILD_LIBS}
+ 
+ #We don't need rbtdb64 for this library
+ #rbtdb64. at O@: rbtdb.c
package/dhcp/dhcp.hash +2 -2
index 84e3c63..fd9b24a 100644
@@ -1,2 +1,2 @@
-# Verified from ftp://ftp.isc.org/isc/dhcp/4.1-ESV-R12/dhcp-4.1-ESV-R12.tar.gz.sha256.asc
-sha256	53265d1bf5e2073379df03c73a1a34d38a904307609c0f9cb77223912e753e5f	dhcp-4.1-ESV-R12.tar.gz
+# Verified from https://ftp.isc.org/isc/dhcp/4.3.3-P1/dhcp-4.3.3-P1.tar.gz.sha256.asc
+sha256 c11e896dffa1bfbc49462965d3f6dec45534e34068603546d9a236f2aa669921 dhcp-4.3.3-P1.tar.gz
package/dhcp/dhcp.mk +26 -2
index c05e694..5cb6043 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-DHCP_VERSION = 4.1-ESV-R12
+DHCP_VERSION = 4.3.3-P1
 DHCP_SITE = http://ftp.isc.org/isc/dhcp/$(DHCP_VERSION)
 DHCP_INSTALL_STAGING = YES
 DHCP_LICENSE = ISC
@@ -12,7 +12,8 @@ DHCP_LICENSE_FILES = LICENSE
 DHCP_CONF_ENV = \
 	CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \
 		-D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \
-	ac_cv_file__dev_random=yes
+	ac_cv_file__dev_random=yes \
+	BINDCONFIG='--with-randomdev=/dev/random'
 DHCP_CONF_OPTS = \
 	--with-srv-lease-file=/var/lib/dhcp/dhcpd.leases \
 	--with-srv6-lease-file=/var/lib/dhcp/dhcpd6.leases \
@@ -25,6 +26,29 @@ DHCP_CONF_OPTS = \
 	--with-relay-pid-file=/var/run/dhcrelay.pid \
 	--with-relay6-pid-file=/var/run/dhcrelay6.pid
 
+# The source for the bind libraries used by dhcp are embedded in the dhcp source
+# as a tar-ball. Extract the bind source to allow any patches to be applied
+# during the patch phase.
+define DHCP_EXTRACT_BIND
+	cd $(@D)/bind; tar -xvf bind.tar.gz
+endef
+DHCP_POST_EXTRACT_HOOKS += DHCP_EXTRACT_BIND
+
+# The patchset requires configure et.al. to be regenerated.
+DHCP_AUTORECONF = YES
+
+# bind does not support parallel builds.
+DHCP_MAKE = $(MAKE1)
+
+# bind configure is called via dhcp make instead of dhcp configure. The make env
+# needs extra values for bind configure.
+DHCP_MAKE_ENV = \
+	$(TARGET_CONFIGURE_OPTS) \
+	BUILD_CC="$(HOSTCC)" \
+	BUILD_CFLAGS="$(HOST_CFLAGS)" \
+	BUILD_CPPFLAGS="$(HOST_CPPFLAGS)" \
+	BUILD_LDFLAGS="$(HOST_LDFLAGS)"
+
 ifeq ($(BR2_PACKAGE_DHCP_SERVER_DELAYED_ACK),y)
 DHCP_CONF_OPTS += --enable-delayed-ack
 endif
Signature · 1 line
2.7.1
#1 lore raw

PATCH v9 1/1 package/dhcp: bump version to 4.3.3-P1

Doug,

Quoted 13 lines · Doug Kehn

bind source tar-ball is now embedded into the dhcp source. The embedded bind tar-ball is extracted after the dhcp source so cross compiling patches can be applied to the dhcp and bind before the package is built.

The embedded bind configure is called as part of dhcp make instead of dhcp configure; therefore, needed configure parameters are set in the make env.

0001-dhcp-cross-compile.patch and 0002-bind-cross-compile.patch have been submitted upstream as part of a cross compiling enhancement suggestion to dhcp-suggest at isc.org. Reference ISC-Bugs #41502. 0003-bind-hos-cc.patch is already scheduled for the next dhcp release.

Quoted 6 lines

Buildroot thread

	http://lists.busybox.net/pipermail/buildroot/2016-January/149079.html

has related information.

Cc Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Using origin/next + [PATCH v9], I did a build test for arm with all package flags enabled (client, server, relay). Tested using arm toolchains external-glibc, external-musl and buildroot-uClibc. Basic run test (calling 'dhclient -v' gets an IPv4 address) using a qemu_arm_versatile target.

Regards,
Ricardo

#2 lore raw

PATCH v9 1/1 package/dhcp: bump version to 4.3.3-P1

In reply to Doug Kehn
Quoted 13 lines · Doug Kehn

bind source tar-ball is now embedded into the dhcp source. The embedded bind tar-ball is extracted after the dhcp source so cross compiling patches can be applied to the dhcp and bind before the package is built.

The embedded bind configure is called as part of dhcp make instead of dhcp configure; therefore, needed configure parameters are set in the make env.

0001-dhcp-cross-compile.patch and 0002-bind-cross-compile.patch have been submitted upstream as part of a cross compiling enhancement suggestion to dhcp-suggest at isc.org. Reference ISC-Bugs #41502. 0003-bind-hos-cc.patch is already scheduled for the next dhcp release.

Quoted 7 lines

Buildroot thread

	http://lists.busybox.net/pipermail/buildroot/2016-January/149079.html

has related information.

Cc Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Cc Ricardo Martincoski <[email protected]>

I'm still not sure if it wouldn't be better to call the bind configure in a
post-configure hook, but this is definitely simpler and anyway we do the same for e.g. gcc.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#3 lore raw

PATCH v9 1/1 package/dhcp: bump version to 4.3.3-P1

In reply to Doug Kehn

Dear Doug Kehn,

Quoted 42 lines · Doug Kehn

bind source tar-ball is now embedded into the dhcp source. The embedded bind tar-ball is extracted after the dhcp source so cross compiling patches can be applied to the dhcp and bind before the package is built.

The embedded bind configure is called as part of dhcp make instead of dhcp configure; therefore, needed configure parameters are set in the make env.

0001-dhcp-cross-compile.patch and 0002-bind-cross-compile.patch have been submitted upstream as part of a cross compiling enhancement suggestion to dhcp-suggest at isc.org. Reference ISC-Bugs #41502. 0003-bind-hos-cc.patch is already scheduled for the next dhcp release.

Buildroot thread

	http://lists.busybox.net/pipermail/buildroot/2016-January/149079.html

has related information.

Cc Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Cc Ricardo Martincoski <[email protected]>

---
Changes v8 -> v9
- change HOST_CXXFLAGS to HOST_CPPFLAGS (suggested by Ricardo)
Changes v7 -> v8
- add additional HOST defines (suggested by Arnout)
Changes v6 -> v7
- fix typo in hash (suggested by Ricardo)
Changes v5 -> v6
- patch configure.ac instead of configure/Makefile.in (suggested by Arnout)
- rework dhcp.mk for patch changes.
Changes v4 -> v5
- update hash reference (suggested by Arnout)
- expand comments (suggested by Arnout)
Changes v3 -> v4
- consolidate into single patch (suggested by Arnout)
- separate into POST_CONFIGURE_HOOK & PRE_BUILD_HOOK (suggested by Arnout)
Changes v2 -> v3
- removed RFC tag
- updated version from 4.3.3 to 4.3.3-P1 (suggested by Ricardo)
- external toolchain support (suggested by Ricardo)
Changes v1 -> v2
- removed DHCP_PRE_BUILD_HOOKS in favor of patch (suggested by Arnout)

Quoted 10 lines
---
 package/dhcp/0001-dhcp-cross-compile.patch | 34 +++++++++++++++++++++++++
 package/dhcp/0002-bind-cross-compile.patch | 24 ++++++++++++++++++
 package/dhcp/0003-bind-host-cc.patch       | 40 ++++++++++++++++++++++++++++++
 package/dhcp/dhcp.hash                     |  4 +--
 package/dhcp/dhcp.mk                       | 28 +++++++++++++++++++--
 5 files changed, 126 insertions(+), 4 deletions(-)
 create mode 100644 package/dhcp/0001-dhcp-cross-compile.patch
 create mode 100644 package/dhcp/0002-bind-cross-compile.patch
 create mode 100644 package/dhcp/0003-bind-host-cc.patch

Applied to next, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com