Skip to contentSkip to conversation

staging: rtl8712: Drop else after return

PATCH In review Bhaktipriya Shridhar 2 participants 2 messages Feb 21, 2016 – Feb 22, 2016 Staging

lore
Share & tools
lore

Bhaktipriya Shridhar

author
#0 lore raw

PATCH 1/1 staging: rtl8712: Drop else after return

Remove unnecessary else when there is a return statement in the corresponding if block.

The following Coccinelle patch used:

@@
expression e2;
statement s1;
@@
if(e2) { ... return ...; }
-else

         s1

@@
expression e1;
@@
if (e1) { ... return ...; }

-else{
	...

-}

Signed-off-by Bhaktipriya Shridhar <[email protected]>
---
 drivers/staging/rtl8712/xmit_linux.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8712/xmit_linux.c +1 -2
index f8866d7..adb51f0 100644
@@ -72,8 +72,7 @@ sint r8712_endofpktfile(struct pkt_file *pfile)
 {
 	if (pfile->pkt_len == 0)
 		return true;
-	else
-		return false;
+	return false;
 }

--
2.1.4

#1 lore raw
Quoted 31 lines · Bhaktipriya Shridhar

Remove unnecessary else when there is a return statement in the corresponding if block.

The following Coccinelle patch used:

@@
expression e2;
statement s1;
@@
if(e2) { ... return ...; }
-else

         s1

@@
expression e1;
@@
if (e1) { ... return ...; }

(quoted diff) +0 -2
-else{
...
-}
Signed-off-by Bhaktipriya Shridhar <[email protected]>
---
 drivers/staging/rtl8712/xmit_linux.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8712/xmit_linux.c +0 -0
index f8866d7..adb51f0 100644

drivers/staging/rtl8712/xmit_linux.c sint r8712_endofpktfile(struct pkt_file *pfile) · line 73

Quoted 2 lines
drivers/staging/rtl8712/xmit_linux.c +0 -0
@@ -72,8 +72,7 @@ sint r8712_endofpktfile(struct pkt_file *pfile)
 {
        if (pfile->pkt_len == 0)

Here we could just return pfile->pkt_len == 0;