Skip to contentSkip to conversation

package/spice: depend on libglib2

PATCH New Bernd Kuhls 3 participants 5 messages Feb 21, 2016

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH 1/1 package/spice: depend on libglib2

The package selects BR2_PACKAGE_LIBGLIB2 but did not depend on it.

The buildsystem treats libglib2 as a hard-dependency:
https://cgit.freedesktop.org/spice/spice/tree/configure.ac?h=0.12#n117

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/spice/spice.mk | 1 +
 1 file changed, 1 insertion(+)
package/spice/spice.mk +1 -0
index a31d78d..61a9772 100644
@@ -14,6 +14,7 @@ SPICE_DEPENDENCIES =        \
 	alsa-lib            \
 	celt051             \
 	jpeg                \
+	libglib2            \
 	openssl             \
 	pixman              \
 	python-pyparsing    \
Signature · 1 line
2.7.0
#1 lore raw

PATCH 1/1 package/spice: depend on libglib2

Dear Bernd Kuhls,

Quoted 6 lines · Bernd Kuhls

The package selects BR2_PACKAGE_LIBGLIB2 but did not depend on it.

The buildsystem treats libglib2 as a hard-dependency:
https://cgit.freedesktop.org/spice/spice/tree/configure.ac?h=0.12#n117

Signed-off-by Bernd Kuhls <[email protected]>

I am not sure in fact. The part of configure.ac you're pointing to simply adds libglib2 to SPICE_REQUIRES, which is *only* used in the spice build system to fill in the Requires.private field of spice-server.pc. I.e, it seems like libglib2 is only an indirect dependency of spice, and a reference to libglib2 only needed when static linking.

This clearly needs more investigation, as other dependencies of spice are handled in the same way.

Yann, you originally added the spice package, maybe you can have a look?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 package/spice: depend on libglib2

Thomas, Bernd, All,

On 2016-02-21 21:12 +0100, Thomas Petazzoni spake thusly:

Quoted 8 lines

Dear Bernd Kuhls,

Quoted 5 lines · Bernd Kuhls

The package selects BR2_PACKAGE_LIBGLIB2 but did not depend on it.

The buildsystem treats libglib2 as a hard-dependency:
https://cgit.freedesktop.org/spice/spice/tree/configure.ac?h=0.12#n117

Quoted 8 lines
Quoted 1 line
Signed-off-by Bernd Kuhls <[email protected]>

I am not sure in fact. The part of configure.ac you're pointing to simply adds libglib2 to SPICE_REQUIRES, which is *only* used in the spice build system to fill in the Requires.private field of spice-server.pc. I.e, it seems like libglib2 is only an indirect dependency of spice, and a reference to libglib2 only needed when static linking.

    $ git grep -E '\<glib.h\>'
    server/reds.c:#include <glib.h>

The server is not optional (only the client is), and reds.c is not conditoinal in server/Makefile.am.

So it looks like it really requires glib for itself.

Quoted 2 lines

This clearly needs more investigation, as other dependencies of spice are handled in the same way.

Not sure I'm following... Except for libglib2, for each select or depends on, we have the corresponding entry in _DEPENDENCIES.

Unless you're referring to how spice internally treats its depednencies?

Quoted 1 line

Yann, you originally added the spice package, maybe you can have a look?

Are you kidding? That was more than three years ago! Hehe! ;-)

And by the way, a bump would be welcome (after the release, I mean). ;-)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/spice: depend on libglib2

Yann,

Quoted 5 lines · Yann E. MORIN
    $ git grep -E '\<glib.h\>'
    server/reds.c:#include <glib.h>

The server is not optional (only the client is), and reds.c is not conditoinal in server/Makefile.am.

Aaah, I missed the PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.22]) line.

Since I believe Bernd's patch was pointing to:

SPICE_REQUIRES+=" glib-2.0 >= 2.22"

I thought he was referring to this line as the justification for the glib dependency.

But OK, it really needs glib. I'll apply Bernd's patch. Thanks for confirming!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Applied
#4 lore raw

PATCH 1/1 package/spice: depend on libglib2

In reply to Bernd Kuhls

Dear Bernd Kuhls,

Quoted 9 lines · Bernd Kuhls

The package selects BR2_PACKAGE_LIBGLIB2 but did not depend on it.

The buildsystem treats libglib2 as a hard-dependency:
https://cgit.freedesktop.org/spice/spice/tree/configure.ac?h=0.12#n117

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/spice/spice.mk | 1 +
 1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com