Skip to contentSkip to conversation

ARM: dts: sun4i: Enable USB DRC on Hyundai-a7hd

PATCH New Peter Korsgaard 3 participants 5 messages Feb 16, 2016 – Feb 23, 2016

Subsystems (2)
Device tree bindings Arm/Allwinner sunXi SoC support
lore
Share & tools
lore

Peter Korsgaard

author
#0 lore raw

PATCH 1/1 ARM: dts: sun4i: Enable USB DRC on Hyundai-a7hd

Enable the OTG USB controller on the A7HD.

Signed-off-by Peter Korsgaard <[email protected]>
---
 arch/arm/boot/dts/sun4i-a10-hyundai-a7hd.dts | 34 ++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)
arch/arm/boot/dts/sun4i-a10-hyundai-a7hd.dts +34 -0
index 43f58fb..9103864 100644
@@ -87,6 +87,30 @@
 	status = "okay";
 };
 
+&otg_sram {
+	status = "okay";
+};
+
+&pio {
+	usb0_id_detect_pin: usb0_id_detect_pin at 0 {
+		allwinner,pins = "PH4";
+		allwinner,function = "gpio_in";
+		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+		allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
+	};
+
+	usb0_vbus_detect_pin: usb0_vbus_detect_pin at 0 {
+		allwinner,pins = "PH5";
+		allwinner,function = "gpio_in";
+		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+		allwinner,pull = <SUN4I_PINCTRL_PULL_DOWN>;
+	};
+};
+
+&reg_usb0_vbus {
+	status = "okay";
+};
+
 &reg_usb2_vbus {
 	gpio = <&pio 7 6 GPIO_ACTIVE_HIGH>; /* PH6 */
 	status = "okay";

@@ -102,7 +126,17 @@
 	allwinner,pins = "PH6";
 };
 
+&usb_otg {
+	dr_mode = "otg";
+	status = "okay";
+};
+
 &usbphy {
+	pinctrl-names = "default";
+	pinctrl-0 = <&usb0_id_detect_pin>, <&usb0_vbus_detect_pin>;
+	usb0_id_det-gpio = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
+	usb0_vbus_det-gpio = <&pio 7 5 GPIO_ACTIVE_HIGH>; /* PH5 */
+	usb0_vbus-supply = <&reg_usb0_vbus>;
 	usb2_vbus-supply = <&reg_usb2_vbus>;
 	status = "okay";
 };
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 ARM: dts: sun4i: Enable USB DRC on Hyundai-a7hd

Hi,

Quoted 3 lines · Peter Korsgaard

Enable the OTG USB controller on the A7HD.

Signed-off-by Peter Korsgaard <[email protected]>

Looks good to me:

Reviewed-by Hans de Goede <[email protected]>

Regards,

Hans

Quoted 58 lines
---
  arch/arm/boot/dts/sun4i-a10-hyundai-a7hd.dts | 34 ++++++++++++++++++++++++++++
  1 file changed, 34 insertions(+)
arch/arm/boot/dts/sun4i-a10-hyundai-a7hd.dts +34 -0
index 43f58fb..9103864 100644
@@ -87,6 +87,30 @@
  	status = "okay";
  };
 
+&otg_sram {
+	status = "okay";
+};
+
+&pio {
+	usb0_id_detect_pin: usb0_id_detect_pin at 0 {
+		allwinner,pins = "PH4";
+		allwinner,function = "gpio_in";
+		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+		allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
+	};
+
+	usb0_vbus_detect_pin: usb0_vbus_detect_pin at 0 {
+		allwinner,pins = "PH5";
+		allwinner,function = "gpio_in";
+		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+		allwinner,pull = <SUN4I_PINCTRL_PULL_DOWN>;
+	};
+};
+
+&reg_usb0_vbus {
+	status = "okay";
+};
+
  &reg_usb2_vbus {
  	gpio = <&pio 7 6 GPIO_ACTIVE_HIGH>; /* PH6 */
  	status = "okay";

@@ -102,7 +126,17 @@
  	allwinner,pins = "PH6";
  };
 
+&usb_otg {
+	dr_mode = "otg";
+	status = "okay";
+};
+
  &usbphy {
+	pinctrl-names = "default";
+	pinctrl-0 = <&usb0_id_detect_pin>, <&usb0_vbus_detect_pin>;
+	usb0_id_det-gpio = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
+	usb0_vbus_det-gpio = <&pio 7 5 GPIO_ACTIVE_HIGH>; /* PH5 */
+	usb0_vbus-supply = <&reg_usb0_vbus>;
  	usb2_vbus-supply = <&reg_usb2_vbus>;
  	status = "okay";
  };
Applied
#2 lore raw

PATCH 1/1 ARM: dts: sun4i: Enable USB DRC on Hyundai-a7hd

In reply to Peter Korsgaard

Hi Peter,

Quoted 3 lines · Peter Korsgaard

Enable the OTG USB controller on the A7HD.

Signed-off-by Peter Korsgaard <[email protected]>

Applied, thanks!
Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160221/97797048/attachment-0001.sig>
#3 lore raw

PATCH 1/1 ARM: dts: sun4i: Enable USB DRC on Hyundai-a7hd

In reply to Peter Korsgaard

Hi,

Quoted 3 lines · Peter Korsgaard

Enable the OTG USB controller on the A7HD.

Signed-off-by Peter Korsgaard <[email protected]>

Patch looks good to me:

Reviewed-by Hans de Goede <[email protected]>

Regards,

Hans

Quoted 58 lines
---
  arch/arm/boot/dts/sun4i-a10-hyundai-a7hd.dts | 34 ++++++++++++++++++++++++++++
  1 file changed, 34 insertions(+)
arch/arm/boot/dts/sun4i-a10-hyundai-a7hd.dts +34 -0
index 43f58fb..9103864 100644
@@ -87,6 +87,30 @@
  	status = "okay";
  };
 
+&otg_sram {
+	status = "okay";
+};
+
+&pio {
+	usb0_id_detect_pin: usb0_id_detect_pin at 0 {
+		allwinner,pins = "PH4";
+		allwinner,function = "gpio_in";
+		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+		allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
+	};
+
+	usb0_vbus_detect_pin: usb0_vbus_detect_pin at 0 {
+		allwinner,pins = "PH5";
+		allwinner,function = "gpio_in";
+		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+		allwinner,pull = <SUN4I_PINCTRL_PULL_DOWN>;
+	};
+};
+
+&reg_usb0_vbus {
+	status = "okay";
+};
+
  &reg_usb2_vbus {
  	gpio = <&pio 7 6 GPIO_ACTIVE_HIGH>; /* PH6 */
  	status = "okay";

@@ -102,7 +126,17 @@
  	allwinner,pins = "PH6";
  };
 
+&usb_otg {
+	dr_mode = "otg";
+	status = "okay";
+};
+
  &usbphy {
+	pinctrl-names = "default";
+	pinctrl-0 = <&usb0_id_detect_pin>, <&usb0_vbus_detect_pin>;
+	usb0_id_det-gpio = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
+	usb0_vbus_det-gpio = <&pio 7 5 GPIO_ACTIVE_HIGH>; /* PH5 */
+	usb0_vbus-supply = <&reg_usb0_vbus>;
  	usb2_vbus-supply = <&reg_usb2_vbus>;
  	status = "okay";
  };
author
#4 lore raw

PATCH 1/1 ARM: dts: sun4i: Enable USB DRC on Hyundai-a7hd

Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Hans" == Hans de Goede <[email protected]> writes:

Hi,

Quoted 3 lines · Peter Korsgaard

Enable the OTG USB controller on the A7HD.

Signed-off-by Peter Korsgaard <[email protected]>

Patch looks good to me:

Reviewed-by Hans de Goede <[email protected]>

Thanks, but you already sent your review-by on the 17th - And Maxime said he applied it (but he apparently hasn't pushed his tree yet).

Signature · 2 lines
Venlig hilsen,
Peter Korsgaard