staging: rdma: hfi1: Compress return logic

PATCH New Bhaktipriya Shridhar 1 participant 1 message Feb 22, 2016 Staging

lore

Share & tools

lore

Bhaktipriya Shridhar

author

2016-02-22 17:03 UTC #0 lore raw

PATCH 1/1 staging: rdma: hfi1: Compress return logic

Simplified function return by merging assignment and return into one line.

Found with Coccinelle.

@@
expression e;
local idexpression ret;
@@
- ret =
+ return
e;
- return ret;

@@ type T; identifier x; @@
- T x;
... when != x

Signed-off-by Bhaktipriya Shridhar <[email protected]>

---
 drivers/staging/rdma/hfi1/user_pages.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

drivers/staging/rdma/hfi1/user_pages.c +1 -5

index 692de65..8ebfe9e 100644
@@ -61,11 +61,7 @@
 dma_addr_t hfi1_map_page(struct pci_dev *hwdev, struct page *page,
 			 unsigned long offset, size_t size, int direction)
 {
-	dma_addr_t phys;
-
-	phys = pci_map_page(hwdev, page, offset, size, direction);
-
-	return phys;
+	return pci_map_page(hwdev, page, offset, size, direction);
 }
 
 int hfi1_acquire_user_pages(unsigned long vaddr, size_t npages, bool writable,

--
2.1.4