Skip to contentSkip to conversation

base: isa: Remove X86_32 dependency

PATCH In review William Breathitt Gray 3 participants 5 messages Jan 22, 2016 – Feb 22, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 base: isa: Remove X86_32 dependency

Many motherboards utilize a LPC to ISA bridge in order to decode ISA-style port-mapped I/O addresses. This is particularly true for embedded motherboards supporting the PC/104 bus (a bus specification derived from ISA).

These motherboards are now commonly running 64-bit x86 processors. The X86_32 dependency should be removed from the ISA bus configuration option in order to support these newer motherboards.

A new config option, CONFIG_ISA_BUS, is introduced to allow for the compilation of the ISA bus driver independent of the CONFIG_ISA option. Devices which communicate via ISA-compatible buses can now be supported independent of the dependencies of the CONFIG_ISA option.

---
 arch/x86/Kconfig      | 6 ++++++
 drivers/base/Makefile | 2 +-
 include/linux/isa.h   | 2 +-
 3 files changed, 8 insertions(+), 2 deletions(-)
arch/x86/Kconfig +6 -0
index 4a10ba9..c85073d 100644
@@ -2443,10 +2443,16 @@ config ISA_DMA_API
 	  Enables ISA-style DMA support for devices requiring such controllers.
 	  If unsure, say Y.
 
+config ISA_BUS
+	bool "ISA bus support"
+	help
+	  Enables ISA bus support for devices requiring such controllers.
+
 if X86_32
 
 config ISA
 	bool "ISA support"
+	depends on ISA_BUS
 	---help---
 	  Find out whether you have ISA slots on your motherboard.  ISA is the
 	  name of a bus system, i.e. the way the CPU talks to the other stuff
drivers/base/Makefile +1 -1
index 6b2a84e..4ebfb81 100644
@@ -10,7 +10,7 @@ obj-$(CONFIG_DMA_CMA) += dma-contiguous.o
 obj-y			+= power/
 obj-$(CONFIG_HAS_DMA)	+= dma-mapping.o
 obj-$(CONFIG_HAVE_GENERIC_DMA_COHERENT) += dma-coherent.o
-obj-$(CONFIG_ISA)	+= isa.o
+obj-$(CONFIG_ISA_BUS)	+= isa.o
 obj-$(CONFIG_FW_LOADER)	+= firmware_class.o
 obj-$(CONFIG_NUMA)	+= node.o
 obj-$(CONFIG_MEMORY_HOTPLUG_SPARSE) += memory.o
include/linux/isa.h +1 -1
index b0270e3..2a02862 100644
@@ -22,7 +22,7 @@ struct isa_driver {
 
 #define to_isa_driver(x) container_of((x), struct isa_driver, driver)
 
-#ifdef CONFIG_ISA
+#ifdef CONFIG_ISA_BUS
 int isa_register_driver(struct isa_driver *, unsigned int);
 void isa_unregister_driver(struct isa_driver *);
 #else
Signature · 1 line
2.4.10
Reviewed-by on v2 1/1
#1 lore raw
Quoted 9 lines · William Breathitt Gray

Many motherboards utilize a LPC to ISA bridge in order to decode ISA-style port-mapped I/O addresses. This is particularly true for embedded motherboards supporting the PC/104 bus (a bus specification derived from ISA).

These motherboards are now commonly running 64-bit x86 processors. The X86_32 dependency should be removed from the ISA bus configuration option in order to support these newer motherboards.

Quoted 6 lines

A new config option, CONFIG_ISA_BUS, is introduced to allow for the compilation of the ISA bus driver independent of the CONFIG_ISA option. Devices which communicate via ISA-compatible buses can now be supported independent of the dependencies of the CONFIG_ISA option.

#2 lore raw
Quoted 10 lines · Thomas Gleixner
Quoted 9 lines · William Breathitt Gray

Many motherboards utilize a LPC to ISA bridge in order to decode ISA-style port-mapped I/O addresses. This is particularly true for embedded motherboards supporting the PC/104 bus (a bus specification derived from ISA).

These motherboards are now commonly running 64-bit x86 processors. The X86_32 dependency should be removed from the ISA bus configuration option in order to support these newer motherboards.

Quoted 8 lines
Quoted 6 lines

A new config option, CONFIG_ISA_BUS, is introduced to allow for the compilation of the ISA bus driver independent of the CONFIG_ISA option. Devices which communicate via ISA-compatible buses can now be supported independent of the dependencies of the CONFIG_ISA option.

What more can I do to help get this patch pulled in for the merge window?

William Breathitt Gray

#3 lore raw
Quoted 16 lines · William Breathitt Gray
Quoted 15 lines · Thomas Gleixner
Quoted 14 lines · William Breathitt Gray

Many motherboards utilize a LPC to ISA bridge in order to decode ISA-style port-mapped I/O addresses. This is particularly true for embedded motherboards supporting the PC/104 bus (a bus specification derived from ISA).

These motherboards are now commonly running 64-bit x86 processors. The X86_32 dependency should be removed from the ISA bus configuration option in order to support these newer motherboards.

A new config option, CONFIG_ISA_BUS, is introduced to allow for the compilation of the ISA bus driver independent of the CONFIG_ISA option. Devices which communicate via ISA-compatible buses can now be supported independent of the dependencies of the CONFIG_ISA option.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

What more can I do to help get this patch pulled in for the merge window?

If Greg doesn't pick it up, I'll pull it into x86 later this week

Thanks,

tglx

maintainer
#4 lore raw
Quoted 18 lines · Thomas Gleixner
Quoted 16 lines · William Breathitt Gray
Quoted 15 lines · Thomas Gleixner
Quoted 14 lines · William Breathitt Gray

Many motherboards utilize a LPC to ISA bridge in order to decode ISA-style port-mapped I/O addresses. This is particularly true for embedded motherboards supporting the PC/104 bus (a bus specification derived from ISA).

These motherboards are now commonly running 64-bit x86 processors. The X86_32 dependency should be removed from the ISA bus configuration option in order to support these newer motherboards.

A new config option, CONFIG_ISA_BUS, is introduced to allow for the compilation of the ISA bus driver independent of the CONFIG_ISA option. Devices which communicate via ISA-compatible buses can now be supported independent of the dependencies of the CONFIG_ISA option.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

What more can I do to help get this patch pulled in for the merge window?

If Greg doesn't pick it up, I'll pull it into x86 later this week

It's not in my queue so I don't even have it here to pick up :(