rocker: fix rocker_world_port_obj_vlan_add()

PATCH Applied Dan Carpenter 3 participants 3 messages Feb 23, 2016

Subsystems (4)

Networking Network drivers Kernel janitors Rocker driver

lore

Share & tools

lore

Dan Carpenter

author

2016-02-23 09:37 UTC #0 lore raw

PATCH 1/1 rocker: fix rocker_world_port_obj_vlan_add()

We were changing return values and accidentally made rocker_world_port_obj_vlan_add() into a no-op.

Fixes fccd84d44912 ('rocker: return -EOPNOTSUPP for undefined world ops')

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/ethernet/rocker/rocker_main.c +0 -1

index acafbf8..28b775e 100644
@@ -1598,7 +1598,6 @@ rocker_world_port_obj_vlan_add(struct rocker_port *rocker_port,
 
 	if (!wops->port_obj_vlan_add)
 		return -EOPNOTSUPP;
-		return 0;
 	return wops->port_obj_vlan_add(rocker_port, vlan, trans);
 }

Jiri Pirko

maintainer Acked-by on v1 1/1

2016-02-23 09:39 UTC #1 lore raw

Quoted 5 lines · Tue, Feb 23, 2016 at 10:37:52AM CET, [email protected] wrote:

We were changing return values and accidentally made rocker_world_port_obj_vlan_add() into a no-op.
Fixes fccd84d44912 ('rocker: return -EOPNOTSUPP for undefined world ops')
Signed-off-by Dan Carpenter <[email protected]>

Oops. Thanks for the fix.

Acked-by Jiri Pirko <[email protected]>

David Miller

maintainer Applied

2016-02-23 18:12 UTC #2 lore raw

In reply to Dan Carpenter

From: Dan Carpenter <[email protected]>
Date: Tue, 23 Feb 2016 12:37:52 +0300

Quoted 5 lines

We were changing return values and accidentally made rocker_world_port_obj_vlan_add() into a no-op.
Fixes fccd84d44912 ('rocker: return -EOPNOTSUPP for undefined world ops')
Signed-off-by Dan Carpenter <[email protected]>

Applied, thanks.