configs: atmel: ensure EABIhf is selected for sama5d*
PATCH 1/1 configs: atmel: ensure EABIhf is selected for sama5d*
The recent changes in Config.in.arm regarding the VFP selection broke the atmel_sama5d* defconfigs. Ensure EABIhf is selected as all the sama5 have a vfp.
--- configs/atmel_sama5d3_xplained_defconfig | 3 +-- configs/atmel_sama5d3xek_defconfig | 3 +-- configs/atmel_sama5d4_xplained_defconfig | 3 +-- configs/atmel_sama5d4ek_defconfig | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-)
configs/atmel_sama5d3_xplained_defconfig +1 -2
@@ -1,7 +1,6 @@ BR2_arm=y BR2_cortex_a5=y -BR2_ARM_EABIHF=y -BR2_ARM_FPU_VFPV4D16=y +BR2_ARM_ENABLE_VFP=y BR2_ARM_INSTRUCTIONS_THUMB2=y # Linux headers same as kernel, a 3.18 series BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_18=y
configs/atmel_sama5d3xek_defconfig +1 -2
@@ -1,7 +1,6 @@ BR2_arm=y BR2_cortex_a5=y -BR2_ARM_EABIHF=y -BR2_ARM_FPU_VFPV4D16=y +BR2_ARM_ENABLE_VFP=y BR2_ARM_INSTRUCTIONS_THUMB2=y # Linux headers same as kernel, a 3.18 series BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_18=y
configs/atmel_sama5d4_xplained_defconfig +1 -2
@@ -1,8 +1,7 @@ BR2_arm=y BR2_cortex_a5=y -BR2_ARM_EABIHF=y BR2_ARM_ENABLE_NEON=y -BR2_ARM_FPU_VFPV4D16=y +BR2_ARM_ENABLE_VFP=y BR2_ARM_INSTRUCTIONS_THUMB2=y # Linux headers same as kernel, a 3.18 series BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_18=y
configs/atmel_sama5d4ek_defconfig +1 -2
@@ -1,8 +1,7 @@ BR2_arm=y BR2_cortex_a5=y -BR2_ARM_EABIHF=y BR2_ARM_ENABLE_NEON=y -BR2_ARM_FPU_VFPV4D16=y +BR2_ARM_ENABLE_VFP=y BR2_ARM_INSTRUCTIONS_THUMB2=y # Linux headers same as kernel, a 3.18 series BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_18=y
Signature · 1 line
2.7.0
PATCH 1/1 configs: atmel: ensure EABIhf is selected for sama5d*
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Alexandre" == Alexandre Belloni <[email protected]> writes:
The recent changes in Config.in.arm regarding the VFP selection broke the atmel_sama5d* defconfigs. Ensure EABIhf is selected as all the sama5 have a vfp.
They are not really broken in the sense that they don't build or boot, they are just less optimal, right?
Quoted 5 lines
Signed-off-by Alexandre Belloni <[email protected]>--- configs/atmel_sama5d3_xplained_defconfig | 3 +-- configs/atmel_sama5d3xek_defconfig | 3 +-- configs/atmel_sama5d4_xplained_defconfig | 3 +--
We also have a atmel_sama5d3_xplained_mmc_defconfig that you forgot. Committed with that fixed, thanks.
It seems like we need to fixup the other defconfigs using EABIHF as well :/ In hindsight, maybe BR2_ARM_ENABLE_VFP should have defaulted to 'y' instead.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 configs: atmel: ensure EABIhf is selected for sama5d*
Quoted 9 lines · Peter Korsgaard
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Alexandre" == Alexandre Belloni <[email protected]> writes:
The recent changes in Config.in.arm regarding the VFP selection broke the atmel_sama5d* defconfigs. Ensure EABIhf is selected as all the sama5 have a vfp.
They are not really broken in the sense that they don't build or boot, they are just less optimal, right?
Indeed.
Quoted 9 lines
Quoted 5 lines
Signed-off-by Alexandre Belloni <[email protected]>--- configs/atmel_sama5d3_xplained_defconfig | 3 +-- configs/atmel_sama5d3xek_defconfig | 3 +-- configs/atmel_sama5d4_xplained_defconfig | 3 +--We also have a
atmel_sama5d3_xplained_mmc_defconfigthat you forgot. Committed with that fixed, thanks.
I changed it and I forgot to amend my commit, thanks for fixing that.
Quoted 4 lines
It seems like we need to fixup the other defconfigs using EABIHF as well :/ In hindsight, maybe
BR2_ARM_ENABLE_VFPshould have defaulted to 'y' instead.
Off list, I was suggesting to Thomas add BR2_ARM_ENABLE_VFP = y to all defconfigs with a BR2_ARM_FPU_VFP* but it only catches four more defconfigs. However, there are a lot more, like beaglebone, the allwiner based boards, most of the freescale ones, etc...
Signature · 3 lines
Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 configs: atmel: ensure EABIhf is selected for sama5d*
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Alexandre" == Alexandre Belloni <[email protected]> writes:
Hi,
Quoted 4 lines
Quoted 2 lines
We also have a
atmel_sama5d3_xplained_mmc_defconfigthat you forgot. Committed with that fixed, thanks.I changed it and I forgot to amend my commit, thanks for fixing that.
You're welcome.
Quoted 9 lines
Quoted 4 lines
It seems like we need to fixup the other defconfigs using EABIHF as well :/ In hindsight, maybe
BR2_ARM_ENABLE_VFPshould have defaulted to 'y' instead.Off list, I was suggesting to Thomas add
BR2_ARM_ENABLE_VFP= y to all defconfigs with a BR2_ARM_FPU_VFP* but it only catches four more defconfigs. However, there are a lot more, like beaglebone, the allwiner based boards, most of the freescale ones, etc...
This is only a problem for CPU cores where the VFP is optional like arm926/A5/A9, and I've fixed up our A9 configs now so I believe it is ok.
Signature · 2 lines
Venlig hilsen, Peter Korsgaard