qt: add font license information

PATCH New Peter Seiderer 3 participants 6 messages Jun 12, 2015 – Feb 23, 2016

lore

Share & tools

lore

Peter Seiderer

author

2015-06-12 20:22 UTC #0 lore raw

PATCH 1/1 qt: add font license information

Signed-off-by Peter Seiderer <[email protected]>

---
Not sure about the japanese font and about MIT or MIT-like licenses (no exact match of the wording to other MIT licenses).

---
 package/qt/qt.mk | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

package/qt/qt.mk +30 -0

index a7bbe5f..3fbb3e1 100644
@@ -656,6 +656,32 @@ define QT_INSTALL_TARGET_FONTS
 	mkdir -p $(TARGET_DIR)/usr/lib/fonts
 	cp -dpf $(QT_FONTS) $(TARGET_DIR)/usr/lib/fonts
 endef
+ifeq ($(BR2_PACKAGE_QT_FONT_MICRO),y)
+QT_LICENSE += Public Domain (Micro font)
+# disabled because this file (containing the Public Domain notice) is
+# the font source file too...
+#QT_LICENSE_FILES += src/3rdparty/fonts/micro.bdf
+endif
+ifeq ($(BR2_PACKAGE_QT_FONT_FIXED),y)
+# according to https://launchpad.net/ubuntu/vivid/+source/qtbase-opensource-src/+copyright
+QT_LICENSE += Public Domain (Fixed font)
+endif
+ifeq ($(BR2_PACKAGE_QT_FONT_HELVETICA),y)
+QT_LICENSE += MIT-like (Helvetica fonts)
+QT_LICENSE_FILES += src/3rdparty/fonts/COPYING.Helvetica
+endif
+ifeq ($(BR2_PACKAGE_QT_FONT_JAPANESE),y)
+# according to https://launchpad.net/ubuntu/vivid/+source/qtbase-opensource-src/+copyright
+# Public Domain
+QT_LICENSE += Public Domain (Japanese font)
+# according to lib/fonts/README same as Helvetica fonts?
+#QT_LICENSE += MIT-like (Japanese fonts)
+#QT_LICENSE_FILES += src/3rdparty/fonts/COPYING.Helvetica
+endif
+ifeq ($(BR2_PACKAGE_QT_FONT_UNIFONT),y)
+QT_LICENSE += Freeware (Unifont font)
+QT_LICENSE_FILES += src/3rdparty/fonts/COPYRIGHT.Unifont
+endif
 endif
 
 ifeq ($(BR2_PACKAGE_QT_QTFREETYPE)$(BR2_PACKAGE_QT_SYSTEMFREETYPE),y)

@@ -663,6 +689,10 @@ define QT_INSTALL_TARGET_FONTS_TTF
 	mkdir -p $(TARGET_DIR)/usr/lib/fonts
 	cp -dpf $(STAGING_DIR)/usr/lib/fonts/*.ttf $(TARGET_DIR)/usr/lib/fonts
 endef
+QT_LICENSE += MIT-like (DejaVu/Vera TrueType fonts)
+QT_LICENSE_FILES += src/3rdparty/fonts/COPYRIGHT.DejaVu \
+	src/3rdparty/fonts/README.DejaVu \
+	src/3rdparty/fonts/COPYRIGHT.Vera
 endif
 endif # BR2_PACKAGE_QT_EMBEDDED

Signature · 1 line

2.1.4

Arnout Vandecappelle

2016-02-22 23:09 UTC #1 lore raw

PATCH 1/1 qt: add font license information

Quoted 13 lines · Peter Seiderer

Signed-off-by Peter Seiderer <[email protected]>
---
Not sure about the japanese font and about MIT or MIT-like licenses (no exact match of the wording to other MIT licenses).
---
 package/qt/qt.mk | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
package/qt/qt.mk +0 -0
index a7bbe5f..3fbb3e1 100644

package/qt/qt.mk define QT_INSTALL_TARGET_FONTS · line 663

Quoted 8 lines

package/qt/qt.mk +5 -0

@@ -656,6 +656,32 @@ define QT_INSTALL_TARGET_FONTS
 	mkdir -p $(TARGET_DIR)/usr/lib/fonts
 	cp -dpf $(QT_FONTS) $(TARGET_DIR)/usr/lib/fonts
 endef
+ifeq ($(BR2_PACKAGE_QT_FONT_MICRO),y)
+QT_LICENSE += Public Domain (Micro font)
+# disabled because this file (containing the Public Domain notice) is
+# the font source file too...
+#QT_LICENSE_FILES += src/3rdparty/fonts/micro.bdf

IMHO LICENSE_FILES are not needed for Public Domain. The point of the license
file is to offer the complete license text, not to prove that the license is right. For public domain, a complete license text is not needed.

It is useful to have a comment of where you found this license, but if it is
just in the file itself, that's not really relevant.

package/qt/qt.mk define QT_INSTALL_TARGET_FONTS · line 670

Quoted 7 lines

package/qt/qt.mk +7 -0

+endif
+ifeq ($(BR2_PACKAGE_QT_FONT_FIXED),y)
+# according to https://launchpad.net/ubuntu/vivid/+source/qtbase-opensource-src/+copyright
+QT_LICENSE += Public Domain (Fixed font)
+endif
+ifeq ($(BR2_PACKAGE_QT_FONT_HELVETICA),y)
+QT_LICENSE += MIT-like (Helvetica fonts)

Hm, doesn't look that MIT-like to me. I'd call it 'Adobe Helvetica license'.

package/qt/qt.mk define QT_INSTALL_TARGET_FONTS · line 675

Quoted 5 lines

package/qt/qt.mk +5 -0

+QT_LICENSE_FILES += src/3rdparty/fonts/COPYING.Helvetica
+endif
+ifeq ($(BR2_PACKAGE_QT_FONT_JAPANESE),y)
+# according to https://launchpad.net/ubuntu/vivid/+source/qtbase-opensource-src/+copyright
+# Public Domain

I think that's a mistake... I submitted bug #815616 to debian.

package/qt/qt.mk define QT_INSTALL_TARGET_FONTS · line 677

Quoted 2 lines

package/qt/qt.mk +2 -0

+QT_LICENSE += Public Domain (Japanese font)
+# according to lib/fonts/README same as Helvetica fonts?

Yep, it's from the same source.

It's a bit annoying that you'd have

Adobe Helvetica license (Helvetica fonts) Adobe Helvetica license (Japanese font)

i.e. the same thing twice. So I'd make it:

ifneq ($(BR2_PACKAGE_QT_FONT_HELVETICA)$(BR2_PACKAGE_QT_FONT_JAPANESE),) QT_LICENSE += Adobe Helvetica license (Helvetica/Japanese fonts) QT_LICENSE_FILES += src/3rdparty/fonts/COPYING.Helvetica endif

Quoted 11 lines

package/qt/qt.mk +7 -0

+#QT_LICENSE += MIT-like (Japanese fonts)
+#QT_LICENSE_FILES += src/3rdparty/fonts/COPYING.Helvetica
+endif
+ifeq ($(BR2_PACKAGE_QT_FONT_UNIFONT),y)
+QT_LICENSE += Freeware (Unifont font)
+QT_LICENSE_FILES += src/3rdparty/fonts/COPYRIGHT.Unifont
+endif
 endif
 
 ifeq ($(BR2_PACKAGE_QT_QTFREETYPE)$(BR2_PACKAGE_QT_SYSTEMFREETYPE),y)

package/qt/qt.mk define QT_INSTALL_TARGET_FONTS_TTF · line 692

Quoted 4 lines

package/qt/qt.mk +1 -0

@@ -663,6 +689,10 @@ define QT_INSTALL_TARGET_FONTS_TTF
 	mkdir -p $(TARGET_DIR)/usr/lib/fonts
 	cp -dpf $(STAGING_DIR)/usr/lib/fonts/*.ttf $(TARGET_DIR)/usr/lib/fonts
 endef
+QT_LICENSE += MIT-like (DejaVu/Vera TrueType fonts)

Also not that MIT-like, so make it 'Bitstream license'.

The problem with the way that it's done now is that the different licenses will
not be comma-separated while they usually are. But adding commas is difficult in this case, so OK.

Regards,
Arnout

Quoted 7 lines

package/qt/qt.mk +3 -0

+QT_LICENSE_FILES += src/3rdparty/fonts/COPYRIGHT.DejaVu \
+	src/3rdparty/fonts/README.DejaVu \
+	src/3rdparty/fonts/COPYRIGHT.Vera
 endif
 endif # BR2_PACKAGE_QT_EMBEDDED

Signature · 6 lines

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

Thomas Petazzoni

2016-02-23 12:51 UTC #2 lore raw

PATCH 1/1 qt: add font license information

Arnout,

Thanks a lot for having reviewed this patch, which is not very simple in terms of licensing details.

Quoted 3 lines · Arnout Vandecappelle

The problem with the way that it's done now is that the different licenses will
not be comma-separated while they usually are. But adding commas is difficult in this case, so OK.

I thought we could do something such as:

QT_LICENSE += Foo (bar),
QT_LICENSE += Bar (foo),
QT_LICENSE += Baz (boz),
QT_LICENSE := $(patsubst %$(comma),%,$(QT_LICENSE))

But it unfortunately seems to remove all commas. We could then do:

QT_FINAL_LICENSE = $(shell echo "$(QT_LICENSE)" | sed 's:$.*$,:\1:')

Not super pretty, but it's just one line of crap.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Arnout Vandecappelle

2016-02-23 19:39 UTC #3 lore raw

PATCH 1/1 qt: add font license information

Quoted 18 lines · Thomas Petazzoni

Arnout,
Thanks a lot for having reviewed this patch, which is not very simple in terms of licensing details.
Quoted 3 lines · Arnout Vandecappelle
The problem with the way that it's done now is that the different licenses will
not be comma-separated while they usually are. But adding commas is difficult in this case, so OK.
I thought we could do something such as:
QT_LICENSE += Foo (bar),
QT_LICENSE += Bar (foo),
QT_LICENSE += Baz (boz),
QT_LICENSE := $(patsubst %$(comma),%,$(QT_LICENSE))

Quoted 5 lines

But it unfortunately seems to remove all commas. We could then do:
QT_FINAL_LICENSE = $(shell echo "$(QT_LICENSE)" | sed 's:$.*$,:\1:')
Not super pretty, but it's just one line of crap.

Actually, that last bit could be moved to the legal-info infra itself, e.g. in
the legal-manifest function.

But that's for another patch :-)

Regards,
Arnout

Quoted 3 lines

Thomas

Signature · 6 lines

Arnout Vandecappelle      arnout dot vandecappelle at essensium dot com
Senior Embedded Software Architect . . . . . . +32-478-010353 (mobile)
Essensium, Mind division . . . . . . . . . . . . . . http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium . . . . . BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

Peter Seiderer

author

2016-02-23 20:19 UTC #4 lore raw

PATCH 1/1 qt: add font license information

In reply to Thomas Petazzoni

Hello Thomas,

Quoted 18 lines · Thomas Petazzoni

Arnout,
Thanks a lot for having reviewed this patch, which is not very simple in terms of licensing details.
Quoted 3 lines · Arnout Vandecappelle
The problem with the way that it's done now is that the different licenses will
not be comma-separated while they usually are. But adding commas is difficult in this case, so OK.
I thought we could do something such as:
QT_LICENSE += Foo (bar),
QT_LICENSE += Bar (foo),
QT_LICENSE += Baz (boz),
QT_LICENSE := $(patsubst %$(comma),%,$(QT_LICENSE))

Quoted 5 lines

But it unfortunately seems to remove all commas. We could then do:
QT_FINAL_LICENSE = $(shell echo "$(QT_LICENSE)" | sed 's:$.*$,:\1:')
Not super pretty, but it's just one line of crap.

O.k. will take it for the next patch version...

Regards,
Peter

Quoted 2 lines

Thomas

Peter Seiderer

author

2016-02-23 20:02 UTC #5 lore raw

PATCH 1/1 qt: add font license information

In reply to Arnout Vandecappelle

Hello Arnout,

Quoted 18 lines · Arnout Vandecappelle

Quoted 17 lines · Peter Seiderer
Signed-off-by Peter Seiderer <[email protected]>
---
Not sure about the japanese font and about MIT or MIT-like licenses (no exact match of the wording to other MIT licenses).
---
 package/qt/qt.mk | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
package/qt/qt.mk +1 -0
index a7bbe5f..3fbb3e1 100644
@@ -656,6 +656,32 @@ define QT_INSTALL_TARGET_FONTS
 	mkdir -p $(TARGET_DIR)/usr/lib/fonts
 	cp -dpf $(QT_FONTS) $(TARGET_DIR)/usr/lib/fonts
 endef
+ifeq ($(BR2_PACKAGE_QT_FONT_MICRO),y)

Quoted 9 lines

package/qt/qt.mk define QT_INSTALL_TARGET_FONTS · line 663
Quoted 4 lines
package/qt/qt.mk +4 -0
+QT_LICENSE += Public Domain (Micro font)
+# disabled because this file (containing the Public Domain notice) is
+# the font source file too...
+#QT_LICENSE_FILES += src/3rdparty/fonts/micro.bdf
IMHO LICENSE_FILES are not needed for Public Domain. The point of the license
file is to offer the complete license text, not to prove that the license is right. For public domain, a complete license text is not needed.

O.k, if no proof for Public Domain via a license file is necessary...

Quoted 3 lines

It is useful to have a comment of where you found this license, but if it is
just in the file itself, that's not really relevant.

Will just add a little comment...

Quoted 10 lines

package/qt/qt.mk define QT_INSTALL_TARGET_FONTS · line 670
Quoted 7 lines
package/qt/qt.mk +7 -0
+endif
+ifeq ($(BR2_PACKAGE_QT_FONT_FIXED),y)
+# according to https://launchpad.net/ubuntu/vivid/+source/qtbase-opensource-src/+copyright
+QT_LICENSE += Public Domain (Fixed font)
+endif
+ifeq ($(BR2_PACKAGE_QT_FONT_HELVETICA),y)
+QT_LICENSE += MIT-like (Helvetica fonts)
Hm, doesn't look that MIT-like to me. I'd call it 'Adobe Helvetica license'.

O.k.

Quoted 8 lines

package/qt/qt.mk define QT_INSTALL_TARGET_FONTS · line 675
Quoted 5 lines
package/qt/qt.mk +5 -0
+QT_LICENSE_FILES += src/3rdparty/fonts/COPYING.Helvetica
+endif
+ifeq ($(BR2_PACKAGE_QT_FONT_JAPANESE),y)
+# according to https://launchpad.net/ubuntu/vivid/+source/qtbase-opensource-src/+copyright
+# Public Domain
I think that's a mistake... I submitted bug #815616 to debian.

Quoted 5 lines

package/qt/qt.mk define QT_INSTALL_TARGET_FONTS · line 677
Quoted 2 lines
package/qt/qt.mk +2 -0
+QT_LICENSE += Public Domain (Japanese font)
+# according to lib/fonts/README same as Helvetica fonts?
Yep, it's from the same source.

Thanks for investigation...

Quoted 10 lines

It's a bit annoying that you'd have
Adobe Helvetica license (Helvetica fonts) Adobe Helvetica license (Japanese font)
i.e. the same thing twice. So I'd make it:
ifneq ($(BR2_PACKAGE_QT_FONT_HELVETICA)$(BR2_PACKAGE_QT_FONT_JAPANESE),) QT_LICENSE += Adobe Helvetica license (Helvetica/Japanese fonts) QT_LICENSE_FILES += src/3rdparty/fonts/COPYING.Helvetica endif

O.k.

Quoted 10 lines

package/qt/qt.mk +7 -0

+#QT_LICENSE += MIT-like (Japanese fonts)
+#QT_LICENSE_FILES += src/3rdparty/fonts/COPYING.Helvetica
+endif
+ifeq ($(BR2_PACKAGE_QT_FONT_UNIFONT),y)
+QT_LICENSE += Freeware (Unifont font)
+QT_LICENSE_FILES += src/3rdparty/fonts/COPYRIGHT.Unifont
+endif
 endif

Quoted 9 lines

package/qt/qt.mk define QT_INSTALL_TARGET_FONTS_TTF · line 692
Quoted 6 lines
package/qt/qt.mk +1 -0
 ifeq ($(BR2_PACKAGE_QT_QTFREETYPE)$(BR2_PACKAGE_QT_SYSTEMFREETYPE),y)
@@ -663,6 +689,10 @@ define QT_INSTALL_TARGET_FONTS_TTF
 	mkdir -p $(TARGET_DIR)/usr/lib/fonts
 	cp -dpf $(STAGING_DIR)/usr/lib/fonts/*.ttf $(TARGET_DIR)/usr/lib/fonts
 endef
+QT_LICENSE += MIT-like (DejaVu/Vera TrueType fonts)
Also not that MIT-like, so make it 'Bitstream license'.

O.k.

Quoted 5 lines

The problem with the way that it's done now is that the different licenses will
not be comma-separated while they usually are. But adding commas is difficult in this case, so OK.

Will try Thomas suggestion for adding commas....

Wanted to do a similar patch for qt5base, but did not find the license files, see QTBUG-46655 ([1]), after some discussion on the mailing list ([2]) the decision was to drop the bundled fonts (abandoned: [3], [4], merged: [5], [6])...

Regards,
Peter

[1] https://bugreports.qt.io/browse/QTBUG-46655
[2] http://lists.qt-project.org/pipermail/development/2015-June/021924.html
[3] https://codereview.qt-project.org/#/c/114503/
[4] https://codereview.qt-project.org/#/c/114512/
[5] https://codereview.qt-project.org/#/c/123568/
[6] https://codereview.qt-project.org/#/c/123567/

Quoted 14 lines

Regards,
Arnout

Quoted 7 lines

package/qt/qt.mk +3 -0

+QT_LICENSE_FILES += src/3rdparty/fonts/COPYRIGHT.DejaVu \
+	src/3rdparty/fonts/README.DejaVu \
+	src/3rdparty/fonts/COPYRIGHT.Vera
 endif
 endif # BR2_PACKAGE_QT_EMBEDDED