Skip to contentSkip to conversation

i2c: sort includes for the core

PATCH Applied Wolfram Sang 1 participant 8 messages Feb 20, 2016 – Feb 24, 2016

Subsystems (4)
I2C subsystem host drivers I2C I2C muxes I2C/smbus stub driver
lore
Share & tools
lore

Wolfram Sang

author
#0 lore raw

cover i2c: sort includes for the core

If drivers must do it, the core should do it as well: keep the includes sorted to make it hard to duplicate entries :)

Plain sorting, nothing has been added or removed.

Wolfram Sang (6):
i2c: i2c-boardinfo: sort includes
i2c: i2c-core: sort includes
i2c: i2c-dev: sort includes
i2c: i2c-mux: sort includes
i2c: i2c-smbus: sort includes
i2c: i2c-stub: sort includes

 drivers/i2c/i2c-boardinfo.c |  6 +++---
 drivers/i2c/i2c-core.c      | 30 +++++++++++++++---------------
 drivers/i2c/i2c-dev.c       | 14 +++++++-------
 drivers/i2c/i2c-mux.c       |  8 ++++----
 drivers/i2c/i2c-smbus.c     |  8 ++++----
 drivers/i2c/i2c-stub.c      |  8 ++++----
 6 files changed, 37 insertions(+), 37 deletions(-)
Signature · 1 line
2.7.0
author
#1 lore raw

PATCH 1/6 i2c: i2c-boardinfo: sort includes

I request this for drivers, so the core should adhere to sorted includes as well.

Signed-off-by Wolfram Sang <[email protected]>
---
 drivers/i2c/i2c-boardinfo.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/i2c/i2c-boardinfo.c +3 -3
index 90e32295930332..e33022e2d459f1 100644
@@ -12,11 +12,11 @@
  * GNU General Public License for more details.
  */
 
-#include <linux/kernel.h>
-#include <linux/i2c.h>
-#include <linux/slab.h>
 #include <linux/export.h>
+#include <linux/i2c.h>
+#include <linux/kernel.h>
 #include <linux/rwsem.h>
+#include <linux/slab.h>
 
 #include "i2c-core.h"
Signature · 1 line
2.7.0
author
#2 lore raw

PATCH 2/6 i2c: i2c-core: sort includes

In reply to Wolfram Sang

I request this for drivers, so the core should adhere to sorted includes as well.

Signed-off-by Wolfram Sang <[email protected]>
---
 drivers/i2c/i2c-core.c | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)
drivers/i2c/i2c-core.c +15 -15
index ffe715d346d884..2949ab3c2293ad 100644
@@ -28,32 +28,32 @@
  */
 
 #include <dt-bindings/i2c/i2c.h>
-#include <linux/module.h>
-#include <linux/kernel.h>
+#include <asm/uaccess.h>
+#include <linux/acpi.h>
+#include <linux/clk/clk-conf.h>
+#include <linux/completion.h>
 #include <linux/delay.h>
+#include <linux/err.h>
 #include <linux/errno.h>
 #include <linux/gpio.h>
-#include <linux/slab.h>
+#include <linux/hardirq.h>
 #include <linux/i2c.h>
-#include <linux/init.h>
 #include <linux/idr.h>
+#include <linux/init.h>
+#include <linux/irqflags.h>
+#include <linux/jump_label.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
 #include <linux/mutex.h>
-#include <linux/of.h>
 #include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/of_irq.h>
-#include <linux/clk/clk-conf.h>
-#include <linux/completion.h>
-#include <linux/hardirq.h>
-#include <linux/irqflags.h>
-#include <linux/rwsem.h>
-#include <linux/pm_runtime.h>
 #include <linux/pm_domain.h>
+#include <linux/pm_runtime.h>
 #include <linux/pm_wakeirq.h>
-#include <linux/acpi.h>
-#include <linux/jump_label.h>
-#include <asm/uaccess.h>
-#include <linux/err.h>
 #include <linux/property.h>
+#include <linux/rwsem.h>
+#include <linux/slab.h>
 
 #include "i2c-core.h"
Signature · 1 line
2.7.0
author
#3 lore raw

PATCH 3/6 i2c: i2c-dev: sort includes

In reply to Wolfram Sang

I request this for drivers, so the core should adhere to sorted includes as well.

Signed-off-by Wolfram Sang <[email protected]>
---
 drivers/i2c/i2c-dev.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/i2c/i2c-dev.c +7 -7
index 2413ec9f8207ee..0b1108d3c2f397 100644
@@ -22,17 +22,17 @@
 
 /* The I2C_RDWR ioctl code is written by Kolja Waschk <[email protected]> */
 
-#include <linux/kernel.h>
-#include <linux/module.h>
 #include <linux/device.h>
-#include <linux/notifier.h>
 #include <linux/fs.h>
-#include <linux/slab.h>
-#include <linux/init.h>
-#include <linux/list.h>
-#include <linux/i2c.h>
 #include <linux/i2c-dev.h>
+#include <linux/i2c.h>
+#include <linux/init.h>
 #include <linux/jiffies.h>
+#include <linux/kernel.h>
+#include <linux/list.h>
+#include <linux/module.h>
+#include <linux/notifier.h>
+#include <linux/slab.h>
 #include <linux/uaccess.h>
 
 /*
Signature · 1 line
2.7.0
author
#4 lore raw

PATCH 4/6 i2c: i2c-mux: sort includes

In reply to Wolfram Sang

I request this for drivers, so the core should adhere to sorted includes as well.

Signed-off-by Wolfram Sang <[email protected]>
---
 drivers/i2c/i2c-mux.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/i2c/i2c-mux.c +4 -4
index 00fc5b1c7b66bb..d4022878b2f0b6 100644
@@ -19,13 +19,13 @@
  * warranty of any kind, whether express or implied.
  */
 
-#include <linux/kernel.h>
-#include <linux/module.h>
-#include <linux/slab.h>
+#include <linux/acpi.h>
 #include <linux/i2c.h>
 #include <linux/i2c-mux.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
 #include <linux/of.h>
-#include <linux/acpi.h>
+#include <linux/slab.h>
 
 /* multiplexer per channel data */
 struct i2c_mux_priv {
Signature · 1 line
2.7.0
author
#5 lore raw

PATCH 5/6 i2c: i2c-smbus: sort includes

In reply to Wolfram Sang

I request this for drivers, so the core should adhere to sorted includes as well.

Signed-off-by Wolfram Sang <[email protected]>
---
 drivers/i2c/i2c-smbus.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/i2c/i2c-smbus.c +4 -4
index 94765a81970d8c..abb55d3e76f33a 100644
@@ -15,14 +15,14 @@
  * GNU General Public License for more details.
  */
 
-#include <linux/kernel.h>
-#include <linux/module.h>
 #include <linux/device.h>
-#include <linux/interrupt.h>
-#include <linux/workqueue.h>
 #include <linux/i2c.h>
 #include <linux/i2c-smbus.h>
+#include <linux/interrupt.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
 #include <linux/slab.h>
+#include <linux/workqueue.h>
 
 struct i2c_smbus_alert {
 	unsigned int		alert_edge_triggered:1;
Signature · 1 line
2.7.0
author
#6 lore raw

PATCH 6/6 i2c: i2c-stub: sort includes

In reply to Wolfram Sang

I request this for drivers, so the core should adhere to sorted includes as well.

Signed-off-by Wolfram Sang <[email protected]>
---
 drivers/i2c/i2c-stub.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/i2c/i2c-stub.c +4 -4
index af2a94e1140ba0..06af583d510150 100644
@@ -17,13 +17,13 @@
 
 #define DEBUG 1
 
-#include <linux/init.h>
-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/slab.h>
 #include <linux/errno.h>
 #include <linux/i2c.h>
+#include <linux/init.h>
+#include <linux/kernel.h>
 #include <linux/list.h>
+#include <linux/module.h>
+#include <linux/slab.h>
 
 #define MAX_CHIPS 10
Signature · 1 line
2.7.0
author Applied
#7 lore raw
In reply to Wolfram Sang
Quoted 6 lines · Wolfram Sang

If drivers must do it, the core should do it as well: keep the includes sorted to make it hard to duplicate entries :)

Plain sorting, nothing has been added or removed.

Quoted 8 lines

Wolfram Sang (6):
i2c: i2c-boardinfo: sort includes
i2c: i2c-core: sort includes
i2c: i2c-dev: sort includes
i2c: i2c-mux: sort includes
i2c: i2c-smbus: sort includes
i2c: i2c-stub: sort includes

Applied to for-next, thanks!