watchdog: Add hardware dependency to BCM7038 driver

PATCH In review Jean Delvare 4 participants 4 messages Feb 24, 2016 – Mar 4, 2016 Watchdog device drivers

Share & tools

Jean Delvare

author

2016-02-24 15:17 UTC #0 lore raw

PATCH v2 1/1 watchdog: Add hardware dependency to BCM7038 driver

The BCM7038 watchdog driver is specific to Broadcom ARM and MIPS SoCs so do not present it on other architectures, unless build-testing.

Signed-off-by Jean Delvare <[email protected]>

Cc Guenter Roeck <[email protected]>

Cc Justin Chen <[email protected]>

Cc Wim Van Sebroeck <[email protected]>

---
Changes since v1:
* Better dependencies, suggested by Justin, and updated the description accordingly.
* Better option description, provided by Justin.

 drivers/watchdog/Kconfig |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

drivers/watchdog/Kconfig +5 -3

@@ -1377,10 +1377,12 @@ config BCM7038_WDT
 	tristate "BCM7038 Watchdog"
 	select WATCHDOG_CORE
 	depends on HAS_IOMEM
+	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
 	help
-	 Watchdog driver for the built-in hardware in Broadcom 7038 SoCs.
-
-	 Say 'Y or 'M' here to enable the driver.
+	 Watchdog driver for the built-in hardware in Broadcom 7038 and
+	 later SoCs used in set-top boxes.  BCM7038 was made public
+	 during the 2004 CES, and since then, many Broadcom chips use this
+	 watchdog block, including some cable modem chips.
 
 config IMGPDC_WDT
 	tristate "Imagination Technologies PDC Watchdog Timer"

Signature · 2 lines

Jean Delvare
SUSE L3 Support

Guenter Roeck

maintainer Reviewed-by on v2 1/1

2016-02-24 15:31 UTC #1 lore raw

Quoted 8 lines · Jean Delvare

The BCM7038 watchdog driver is specific to Broadcom ARM and MIPS SoCs so do not present it on other architectures, unless build-testing.
Signed-off-by Jean Delvare <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Justin Chen <[email protected]>
Cc Wim Van Sebroeck <[email protected]>

Reviewed-by Guenter Roeck <[email protected]>

Quoted 28 lines

---
Changes since v1:
* Better dependencies, suggested by Justin, and updated the description accordingly.
* Better option description, provided by Justin.

  drivers/watchdog/Kconfig |    8 +++++---
  1 file changed, 5 insertions(+), 3 deletions(-)

drivers/watchdog/Kconfig +5 -3

@@ -1377,10 +1377,12 @@ config BCM7038_WDT
  	tristate "BCM7038 Watchdog"
  	select WATCHDOG_CORE
  	depends on HAS_IOMEM
+	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
  	help
-	 Watchdog driver for the built-in hardware in Broadcom 7038 SoCs.
-
-	 Say 'Y or 'M' here to enable the driver.
+	 Watchdog driver for the built-in hardware in Broadcom 7038 and
+	 later SoCs used in set-top boxes.  BCM7038 was made public
+	 during the 2004 CES, and since then, many Broadcom chips use this
+	 watchdog block, including some cable modem chips.
 
  config IMGPDC_WDT
  	tristate "Imagination Technologies PDC Watchdog Timer"

Justin Chen

Reviewed-by

2016-02-24 17:08 UTC #2 lore raw

Quoted 6 lines · Guenter Roeck

Quoted 5 lines · Jean Delvare
The BCM7038 watchdog driver is specific to Broadcom ARM and MIPS SoCs so do not present it on other architectures, unless build-testing.

Quoted 7 lines

Quoted 4 lines
Signed-off-by Jean Delvare <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Justin Chen <[email protected]>
Cc Wim Van Sebroeck <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>

Reviewed-by Justin Chen <[email protected]>

Quoted 33 lines

Quoted 32 lines

---
Changes since v1:
* Better dependencies, suggested by Justin, and updated the description accordingly.
* Better option description, provided by Justin.

  drivers/watchdog/Kconfig |    8 +++++---
  1 file changed, 5 insertions(+), 3 deletions(-)

--- linux-4.5-rc5.orig/drivers/watchdog/Kconfig 2016-02-24 14:43:18.943460233 +0100
+++ linux-4.5-rc5/drivers/watchdog/Kconfig 2016-02-24
15:42:49.756057691 +0100

drivers/watchdog/Kconfig +5 -3

@@ -1377,10 +1377,12 @@ config BCM7038_WDT
        tristate "BCM7038 Watchdog"
        select WATCHDOG_CORE
        depends on HAS_IOMEM
+       depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
        help
-        Watchdog driver for the built-in hardware in Broadcom 7038 SoCs.
-
-        Say 'Y or 'M' here to enable the driver.
+        Watchdog driver for the built-in hardware in Broadcom 7038 and
+        later SoCs used in set-top boxes.  BCM7038 was made public
+        during the 2004 CES, and since then, many Broadcom chips use this
+        watchdog block, including some cable modem chips.
 
  config IMGPDC_WDT
        tristate "Imagination Technologies PDC Watchdog Timer"

Wim Van Sebroeck

2016-03-04 19:37 UTC #3 lore raw

In reply to Jean Delvare

Hi Jean,

Quoted 39 lines

The BCM7038 watchdog driver is specific to Broadcom ARM and MIPS SoCs so do not present it on other architectures, unless build-testing.
Signed-off-by Jean Delvare <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Justin Chen <[email protected]>
Cc Wim Van Sebroeck <[email protected]>
---
Changes since v1:
* Better dependencies, suggested by Justin, and updated the description accordingly.
* Better option description, provided by Justin.
 drivers/watchdog/Kconfig |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/watchdog/Kconfig +5 -3
@@ -1377,10 +1377,12 @@ config BCM7038_WDT
 	tristate "BCM7038 Watchdog"
 	select WATCHDOG_CORE
 	depends on HAS_IOMEM
+	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
 	help
-	 Watchdog driver for the built-in hardware in Broadcom 7038 SoCs.
-
-	 Say 'Y or 'M' here to enable the driver.
+	 Watchdog driver for the built-in hardware in Broadcom 7038 and
+	 later SoCs used in set-top boxes.  BCM7038 was made public
+	 during the 2004 CES, and since then, many Broadcom chips use this
+	 watchdog block, including some cable modem chips.
 
 config IMGPDC_WDT
 	tristate "Imagination Technologies PDC Watchdog Timer"
Signature · 3 lines
-- 
Jean Delvare
SUSE L3 Support

Patch has been added to linux-watchdog-next.

Kind regards,
Wim.