ARM: dts: spear: replace gpio-key, wakeup with wakeup-source property
PATCH 1/1 ARM: dts: spear: replace gpio-key, wakeup with wakeup-source property
Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup source.
Few dts files assign value "1" to gpio-key,wakeup which is incorrect. Since the presence of the boolean property indicates it is enabled, value of "0" or "1" have no significance.
This patch replaces the legacy "gpio-key,wakeup" with the unified "wakeup-source" property which inturn fixes the above mentioned issue.
--- arch/arm/boot/dts/spear1310-evb.dts | 2 +- arch/arm/boot/dts/spear1340-evb.dts | 2 +- arch/arm/boot/dts/spear320-hmi.dts | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-)
Hi ARM-SoC guys,
This is the only platform which doesn't have regular pull request, Viresh has acked it already. Can you pick this up directly for v4.6 ?
Regards,
Sudeep
arch/arm/boot/dts/spear1310-evb.dts +1 -1
@@ -161,7 +161,7 @@ linux,code = <0x100>; gpios = <&gpio0 7 0x4>; debounce-interval = <20>; - gpio-key,wakeup = <1>; + wakeup-source; }; };
arch/arm/boot/dts/spear1340-evb.dts +1 -1
@@ -223,7 +223,7 @@ linux,code = <0x100>; gpios = <&gpio1 1 0x4>; debounce-interval = <20>; - gpio-key,wakeup = <1>; + wakeup-source; }; };
arch/arm/boot/dts/spear320-hmi.dts +2 -2
@@ -141,7 +141,7 @@ linux,code = <0x100>; gpios = <&stmpegpio 3 0x4>; debounce-interval = <20>; - gpio-key,wakeup = <1>; + wakeup-source; }; button at 2 {
@@ -149,7 +149,7 @@ linux,code = <0x200>; gpios = <&stmpegpio 2 0x4>; debounce-interval = <20>; - gpio-key,wakeup = <1>; + wakeup-source; }; };
Signature · 1 line
1.9.1
PATCH 1/1 ARM: dts: spear: replace gpio-key, wakeup with wakeup-source property
Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup source.
Few dts files assign value "1" to gpio-key,wakeup which is incorrect. Since the presence of the boolean property indicates it is enabled, value of "0" or "1" have no significance.
This patch replaces the legacy "gpio-key,wakeup" with the unified "wakeup-source" property which inturn fixes the above mentioned issue.
--- arch/arm/boot/dts/spear1310-evb.dts | 2 +- arch/arm/boot/dts/spear1340-evb.dts | 2 +- arch/arm/boot/dts/spear320-hmi.dts | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-)
(this time adding arm at kernel.org correctly)
Hi ARM-SoC guys,
This is the only platform which doesn't have regular pull request, Viresh has acked it already. Can you pick this up directly for v4.6 ?
Regards,
Sudeep
arch/arm/boot/dts/spear1310-evb.dts +1 -1
@@ -161,7 +161,7 @@ linux,code = <0x100>; gpios = <&gpio0 7 0x4>; debounce-interval = <20>; - gpio-key,wakeup = <1>; + wakeup-source; }; };
arch/arm/boot/dts/spear1340-evb.dts +1 -1
@@ -223,7 +223,7 @@ linux,code = <0x100>; gpios = <&gpio1 1 0x4>; debounce-interval = <20>; - gpio-key,wakeup = <1>; + wakeup-source; }; };
arch/arm/boot/dts/spear320-hmi.dts +2 -2
@@ -141,7 +141,7 @@ linux,code = <0x100>; gpios = <&stmpegpio 3 0x4>; debounce-interval = <20>; - gpio-key,wakeup = <1>; + wakeup-source; }; button at 2 {
@@ -149,7 +149,7 @@ linux,code = <0x200>; gpios = <&stmpegpio 2 0x4>; debounce-interval = <20>; - gpio-key,wakeup = <1>; + wakeup-source; }; };
Signature · 1 line
1.9.1
Olof Johansson
AppliedPATCH 1/1 ARM: dts: spear: replace gpio-key,wakeup with wakeup-source property
Quoted 19 lines · Sudeep Holla
Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup source.
Few dts files assign value "1" to gpio-key,wakeup which is incorrect. Since the presence of the boolean property indicates it is enabled, value of "0" or "1" have no significance.
This patch replaces the legacy "gpio-key,wakeup" with the unified "wakeup-source" property which inturn fixes the above mentioned issue.
Reviewed-by Viresh Kumar <[email protected]>Signed-off-by Sudeep Holla <[email protected]>--- arch/arm/boot/dts/spear1310-evb.dts | 2 +- arch/arm/boot/dts/spear1340-evb.dts | 2 +- arch/arm/boot/dts/spear320-hmi.dts | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-)
Quoted 6 lines
(this time adding arm at kernel.org correctly)
Hi ARM-SoC guys,
This is the only platform which doesn't have regular pull request, Viresh has acked it already. Can you pick this up directly for v4.6 ?
Thanks, applied.
-Olof