staging: dgnc: Use trailing */ on separate line
PATCH 1/1 staging: dgnc: Use trailing */ on separate line
This patch fixes the following checkpatch.pl warning:
Block comments use a trailing */ on a separate line.
Signed-off-by Rehas Sachdeva <[email protected]>
--- drivers/staging/dgnc/dgnc_tty.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/dgnc/dgnc_tty.c +4 -2
@@ -451,7 +451,8 @@ void dgnc_tty_uninit(struct dgnc_board *brd)* buf - Pointer to characters to be moved. * n - Number of characters to move. * -*=======================================================================*/ +*======================================================================= +*/ static void dgnc_wmove (struct channel_t *ch,char *buf,uint n) {int remain;
@@ -495,7 +496,8 @@ static void dgnc_wmove(struct channel_t *ch, char *buf, uint n)* * ch - Pointer to channel structure. * -*=======================================================================*/ +*======================================================================= +*/ void dgnc_input (struct channel_t *ch) {struct dgnc_board *bd;
Signature · 1 line
2.1.4
Quoted 13 lines · Rehas Sachdeva
This patch fixes the following checkpatch.pl warning:
Block comments use a trailing */ on a separate line.Signed-off-by Rehas Sachdeva <[email protected]>--- drivers/staging/dgnc/dgnc_tty.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/staging/dgnc/dgnc_tty.c +0
-0
drivers/staging/dgnc/dgnc_tty.c void dgnc_tty_uninit(struct dgnc_board *brd) · line 455
Quoted 6 lines
drivers/staging/dgnc/dgnc_tty.c +2
-1@@ -451,7 +451,8 @@ void dgnc_tty_uninit(struct dgnc_board *brd)* buf - Pointer to characters to be moved. * n - Number of characters to move. * -*=======================================================================*/ +*======================================================================= +*/
Maybe the ============ line is not needed at all. There are lots of other examples of comments about the parameters in the Linux kernel, and they don't have such a separator.
julia
Quoted 23 lines
drivers/staging/dgnc/dgnc_tty.c +2
-1static void dgnc_wmove (struct channel_t *ch,char *buf,uint n) {int remain;@@ -495,7 +496,8 @@ static void dgnc_wmove(struct channel_t *ch, char *buf, uint n)* * ch - Pointer to channel structure. * -*=======================================================================*/ +*======================================================================= +*/ void dgnc_input (struct channel_t *ch) {struct dgnc_board *bd;Signature · 8 lines
2.1.4 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160225204356.GA29816%40Toblerone. For more options, visit https://groups.google.com/d/optout.
Quoted 6 lines · Rehas Sachdeva
This patch fixes the following checkpatch.pl warning:
Block comments use a trailing */ on a separate line.Signed-off-by Rehas Sachdeva <[email protected]>--- drivers/staging/dgnc/dgnc_tty.c | 6 ++++--
This one touches a file that was touched in another one. In that case you have to make a patch series.
http://kernelnewbies.org/Outreachyfirstpatch#head-e0c4dbf8c60d25ca8e3ae133b6b65560f3c84c09
julia
Quoted 36 lines
1 file changed, 4 insertions(+), 2 deletions(-)drivers/staging/dgnc/dgnc_tty.c +4
-2@@ -451,7 +451,8 @@ void dgnc_tty_uninit(struct dgnc_board *brd)* buf - Pointer to characters to be moved. * n - Number of characters to move. * -*=======================================================================*/ +*======================================================================= +*/ static void dgnc_wmove (struct channel_t *ch,char *buf,uint n) {int remain;@@ -495,7 +496,8 @@ static void dgnc_wmove(struct channel_t *ch, char *buf, uint n)* * ch - Pointer to channel structure. * -*=======================================================================*/ +*======================================================================= +*/ void dgnc_input (struct channel_t *ch) {struct dgnc_board *bd;Signature · 8 lines
2.1.4 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160225204356.GA29816%40Toblerone. For more options, visit https://groups.google.com/d/optout.