uboot-tools: add option for dumpimage

PATCH New Paulo Zaneti 3 participants 5 messages Feb 25, 2016

Share & tools

Paulo Zaneti

author

2016-02-25 14:19 UTC #0 lore raw

PATCH 1/1 uboot-tools: add option for dumpimage

The tool dumpimage extracts data from U-Boot images. U-Boot added dumpimage tool on release 2014.01. This commit allows installation on target and host.

Signed-off-by Paulo Zaneti <[email protected]>

---
 package/uboot-tools/Config.in      | 6 ++++++
 package/uboot-tools/uboot-tools.mk | 8 ++++++++
 2 files changed, 14 insertions(+)

package/uboot-tools/Config.in +6 -0

index e2c621c..aca310b 100644
@@ -53,4 +53,10 @@ config BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV
 	  bootloader, which allows access to the U-Boot environment
 	  from Linux.
 
+config BR2_PACKAGE_UBOOT_TOOLS_DUMPIMAGE
+	bool "dumpimage"
+	help
+	  The dumpimage tool from Das U-Boot bootloader, which allows
+	  extraction of data from U-Boot images.
+
 endif

package/uboot-tools/uboot-tools.mk +8 -0

index 3150279..264e9dd 100644
@@ -52,10 +52,17 @@ define UBOOT_TOOLS_INSTALL_FWPRINTENV
 endef
 endif
 
+ifeq ($(BR2_PACKAGE_UBOOT_TOOLS_DUMPIMAGE),y)
+define UBOOT_TOOLS_INSTALL_DUMPIMAGE
+	$(INSTALL) -m 0755 -D $(@D)/tools/dumpimage $(TARGET_DIR)/usr/sbin/dumpimage
+endef
+endif
+
 define UBOOT_TOOLS_INSTALL_TARGET_CMDS
 	$(UBOOT_TOOLS_INSTALL_MKIMAGE)
 	$(UBOOT_TOOLS_INSTALL_MKENVIMAGE)
 	$(UBOOT_TOOLS_INSTALL_FWPRINTENV)
+	$(UBOOT_TOOLS_INSTALL_DUMPIMAGE)
 endef
 
 ifeq ($(BR2_PACKAGE_HOST_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT),y)

@@ -79,6 +86,7 @@ endef
 define HOST_UBOOT_TOOLS_INSTALL_CMDS
 	$(INSTALL) -m 0755 -D $(@D)/tools/mkimage $(HOST_DIR)/usr/bin/mkimage
 	$(INSTALL) -m 0755 -D $(@D)/tools/mkenvimage $(HOST_DIR)/usr/bin/mkenvimage
+	$(INSTALL) -m 0755 -D $(@D)/tools/dumpimage $(HOST_DIR)/usr/bin/dumpimage
 endef
 
 $(eval $(generic-package))

Signature · 1 line

1.9.1

Carlos Santos

2016-02-25 17:08 UTC #1 lore raw

PATCH 1/1 uboot-tools: add option for dumpimage

From: Paulo Zaneti <[email protected]>

The tool dumpimage extracts data from U-Boot images. U-Boot added dumpimage tool on release 2014.01. This commit allows installation on target and host.

Signed-off-by Paulo Zaneti <[email protected]>

Tested-by Carlos Santos <[email protected]>

Built host (x86_64) and target (PowerPC) packages and verified that both are compiled and installed properly.

Signed-off-by Carlos Santos <[email protected]>

---
 package/uboot-tools/Config.in      | 6 ++++++
 package/uboot-tools/uboot-tools.mk | 8 ++++++++
 2 files changed, 14 insertions(+)

package/uboot-tools/Config.in +6 -0

index e2c621c..aca310b 100644
@@ -53,4 +53,10 @@ config BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV
 	  bootloader, which allows access to the U-Boot environment
 	  from Linux.
 
+config BR2_PACKAGE_UBOOT_TOOLS_DUMPIMAGE
+	bool "dumpimage"
+	help
+	  The dumpimage tool from Das U-Boot bootloader, which allows
+	  extraction of data from U-Boot images.
+
 endif

package/uboot-tools/uboot-tools.mk +8 -0

index 3150279..264e9dd 100644
@@ -52,10 +52,17 @@ define UBOOT_TOOLS_INSTALL_FWPRINTENV
 endef
 endif
 
+ifeq ($(BR2_PACKAGE_UBOOT_TOOLS_DUMPIMAGE),y)
+define UBOOT_TOOLS_INSTALL_DUMPIMAGE
+	$(INSTALL) -m 0755 -D $(@D)/tools/dumpimage $(TARGET_DIR)/usr/sbin/dumpimage
+endef
+endif
+
 define UBOOT_TOOLS_INSTALL_TARGET_CMDS
 	$(UBOOT_TOOLS_INSTALL_MKIMAGE)
 	$(UBOOT_TOOLS_INSTALL_MKENVIMAGE)
 	$(UBOOT_TOOLS_INSTALL_FWPRINTENV)
+	$(UBOOT_TOOLS_INSTALL_DUMPIMAGE)
 endef
 
 ifeq ($(BR2_PACKAGE_HOST_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT),y)

@@ -79,6 +86,7 @@ endef
 define HOST_UBOOT_TOOLS_INSTALL_CMDS
 	$(INSTALL) -m 0755 -D $(@D)/tools/mkimage $(HOST_DIR)/usr/bin/mkimage
 	$(INSTALL) -m 0755 -D $(@D)/tools/mkenvimage $(HOST_DIR)/usr/bin/mkenvimage
+	$(INSTALL) -m 0755 -D $(@D)/tools/dumpimage $(HOST_DIR)/usr/bin/dumpimage
 endef
 
 $(eval $(generic-package))

Signature · 1 line

2.5.0

Carlos Santos

2016-02-25 17:14 UTC #2 lore raw

PATCH 1/1 uboot-tools: add option for dumpimage

In reply to Paulo Zaneti

From: Paulo Zaneti <[email protected]>

The tool dumpimage extracts data from U-Boot images. U-Boot added dumpimage tool on release 2014.01. This commit allows installation on target and host.

Signed-off-by Paulo Zaneti <[email protected]>

Tested-by Carlos Santos <[email protected]>

Built host (x86_64) and target (PowerPC) packages and verified that both are compiled and installed properly.

Signed-off-by Carlos Santos <[email protected]>

---
 package/uboot-tools/Config.in      | 6 ++++++
 package/uboot-tools/uboot-tools.mk | 8 ++++++++
 2 files changed, 14 insertions(+)

package/uboot-tools/Config.in +6 -0

index e2c621c..aca310b 100644
@@ -53,4 +53,10 @@ config BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV
 	  bootloader, which allows access to the U-Boot environment
 	  from Linux.
 
+config BR2_PACKAGE_UBOOT_TOOLS_DUMPIMAGE
+	bool "dumpimage"
+	help
+	  The dumpimage tool from Das U-Boot bootloader, which allows
+	  extraction of data from U-Boot images.
+
 endif

package/uboot-tools/uboot-tools.mk +8 -0

index 3150279..264e9dd 100644
@@ -52,10 +52,17 @@ define UBOOT_TOOLS_INSTALL_FWPRINTENV
 endef
 endif
 
+ifeq ($(BR2_PACKAGE_UBOOT_TOOLS_DUMPIMAGE),y)
+define UBOOT_TOOLS_INSTALL_DUMPIMAGE
+	$(INSTALL) -m 0755 -D $(@D)/tools/dumpimage $(TARGET_DIR)/usr/sbin/dumpimage
+endef
+endif
+
 define UBOOT_TOOLS_INSTALL_TARGET_CMDS
 	$(UBOOT_TOOLS_INSTALL_MKIMAGE)
 	$(UBOOT_TOOLS_INSTALL_MKENVIMAGE)
 	$(UBOOT_TOOLS_INSTALL_FWPRINTENV)
+	$(UBOOT_TOOLS_INSTALL_DUMPIMAGE)
 endef
 
 ifeq ($(BR2_PACKAGE_HOST_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT),y)

@@ -79,6 +86,7 @@ endef
 define HOST_UBOOT_TOOLS_INSTALL_CMDS
 	$(INSTALL) -m 0755 -D $(@D)/tools/mkimage $(HOST_DIR)/usr/bin/mkimage
 	$(INSTALL) -m 0755 -D $(@D)/tools/mkenvimage $(HOST_DIR)/usr/bin/mkenvimage
+	$(INSTALL) -m 0755 -D $(@D)/tools/dumpimage $(HOST_DIR)/usr/bin/dumpimage
 endef
 
 $(eval $(generic-package))

Signature · 1 line

2.5.0

Carlos Santos

2016-02-25 17:31 UTC #3 lore raw

PATCH 1/1 uboot-tools: add option for dumpimage

In reply to Paulo Zaneti

From: Paulo Zaneti <[email protected]>

Quoted 5 lines

The tool dumpimage extracts data from U-Boot images. U-Boot added dumpimage tool on release 2014.01. This commit allows installation on target and host.
Signed-off-by Paulo Zaneti <[email protected]>

Tested-by Carlos Santos <[email protected]>

Built host (x86_64) and target (PowerPC) packages and verified that both are compiled and installed properly.

Signed-off-by Carlos Santos <[email protected]>

Thomas Petazzoni

Applied

2016-02-25 20:36 UTC #4 lore raw

PATCH 1/1 uboot-tools: add option for dumpimage

In reply to Paulo Zaneti

Dear Paulo Zaneti,

Quoted 9 lines · Paulo Zaneti

The tool dumpimage extracts data from U-Boot images. U-Boot added dumpimage tool on release 2014.01. This commit allows installation on target and host.
Signed-off-by Paulo Zaneti <[email protected]>
---
 package/uboot-tools/Config.in      | 6 ++++++
 package/uboot-tools/uboot-tools.mk | 8 ++++++++
 2 files changed, 14 insertions(+)

Applied to next, thanks.

It is somewhat odd that the host variant gets installed in usr/bin, and the target variant in usr/sbin, but it's already the case for the other U-Boot tools. So if we want to improve this, it can be done as a separate patch.

Thanks,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com