Skip to contentSkip to conversation

ssb: host_soc depends on sprom

PATCH RESEND Applied Arnd Bergmann 2 participants 5 messages Feb 25, 2016 – Feb 26, 2016 Sonics silicon backplane driver (ssb)

lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH RESEND 1/1 ssb: host_soc depends on sprom

Drivers that use the SSB sprom functionality typically 'select SSB_SPROM' from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in a build failure unless at least one of the other drivers that selects it is enabled:

drivers/built-in.o: In function `ssb_host_soc_get_invariants':
(.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'

This adds the same select statement that is used elsewhere.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")
---
 drivers/ssb/Kconfig | 1 +
 1 file changed, 1 insertion(+)

I just noticed this hasn't shown up in linux-next yet, so I'm resending it to ensure it's still on someone's radar. Please ignore the resend if it's already in a tree that is not part of linux-next but will be merged eventually.

See https://patchwork.linux-mips.org/patch/12091/ for the original submission.

drivers/ssb/Kconfig +1 -0
index 0c675861623f..d8e4219c2324 100644
@@ -83,6 +83,7 @@ config SSB_SDIOHOST
 config SSB_HOST_SOC
 	bool "Support for SSB bus on SoC"
 	depends on SSB && BCM47XX_NVRAM
+	select SSB_SPROM
 	help
 	  Host interface for a SSB directly mapped into memory. This is
 	  for some Broadcom SoCs from the BCM47xx and BCM53xx lines.
Signature · 1 line
2.7.0
#1 lore raw
Quoted 16 lines · Arnd Bergmann

Drivers that use the SSB sprom functionality typically 'select SSB_SPROM' from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in a build failure unless at least one of the other drivers that selects it is enabled:

drivers/built-in.o: In function `ssb_host_soc_get_invariants':
(.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'

This adds the same select statement that is used elsewhere.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")
---
 drivers/ssb/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 7 lines

I just noticed this hasn't shown up in linux-next yet, so I'm resending it to ensure it's still on someone's radar. Please ignore the resend if it's already in a tree that is not part of linux-next but will be merged eventually.

See https://patchwork.linux-mips.org/patch/12091/ for the original submission.

Sorry, I didn't notice that linux-wireless was not CCed and I missed the patch because it was not in my patchwork queue. But the patch is now there and I should get to it in few days:

https://patchwork.kernel.org/patch/8426571/

Signature · 1 line
Kalle Valo
#2 lore raw
In reply to Arnd Bergmann
Quoted 5 lines · Arnd Bergmann

Drivers that use the SSB sprom functionality typically 'select SSB_SPROM' from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in a build failure unless at least one of the other drivers that selects it is enabled:

Quoted 7 lines

drivers/built-in.o: In function `ssb_host_soc_get_invariants':
(.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'

This adds the same select statement that is used elsewhere.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")

I'm planning to queue this to 4.5.

Signature · 1 line
Kalle Valo
Applied
#3 lore raw

PATCH RESEND 1/1 ssb: host_soc depends on sprom

In reply to Arnd Bergmann
Quoted 6 lines

Drivers that use the SSB sprom functionality typically 'select SSB_SPROM' from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in a build failure unless at least one of the other drivers that selects it is enabled:

Quoted 7 lines

drivers/built-in.o: In function `ssb_host_soc_get_invariants':
(.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'

This adds the same select statement that is used elsewhere.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")

Thanks, applied to wireless-drivers.git.

Kalle Valo

Applied
#4 lore raw
In reply to Arnd Bergmann
Quoted 6 lines

Drivers that use the SSB sprom functionality typically 'select SSB_SPROM' from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in a build failure unless at least one of the other drivers that selects it is enabled:

Quoted 7 lines

drivers/built-in.o: In function `ssb_host_soc_get_invariants':
(.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'

This adds the same select statement that is used elsewhere.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")

Thanks, applied to wireless-drivers.git.

Kalle Valo