staging: rtl8723au: Fix line longer than 80 columns.

PATCH Superseded Edward Lipinsky 2 participants 4 messages Feb 27, 2016 – Mar 12, 2016 Staging

lore

Share & tools

lore

Edward Lipinsky

author

2016-02-27 18:28 UTC #0 lore raw

PATCH 1/1 staging: rtl8723au: Fix line longer than 80 columns.

This patch fixes the checkpatch.pl warning:

WARNING: line over 80 characters

Signed-off-by Edward Lipinsky <[email protected]>

---
 drivers/staging/rtl8723au/core/rtw_ap.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/staging/rtl8723au/core/rtw_ap.c +2 -1

index ce4b589..03202df 100644
@@ -1834,7 +1834,8 @@ void stop_ap_mode23a(struct rtw_adapter *padapter)
 	}
 	spin_unlock_bh(&pacl_node_q->lock);
 
-	DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, pacl_list->num);
+	DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__,
+		  pacl_list->num);
 
 	rtw_sta_flush23a(padapter);

Signature · 1 line

1.7.9.5

Joe Perches

2016-02-27 18:49 UTC #1 lore raw

Quoted 2 lines · Edward Lipinsky

This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters

[]

drivers/staging/rtl8723au/core/rtw_ap.c

Quoted 1 line

drivers/staging/rtl8723au/core/rtw_ap.c +0 -0

[]

drivers/staging/rtl8723au/core/rtw_ap.c void stop_ap_mode23a(struct rtw_adapter *padapter) · line 1838

Quoted 7 lines

drivers/staging/rtl8723au/core/rtw_ap.c +0 -0

@@ -1834,7 +1834,8 @@ void stop_ap_mode23a(struct rtw_adapter *padapter)
  	}
  	spin_unlock_bh(&pacl_node_q->lock);

drivers/staging/rtl8723au/core/rtw_ap.c +2 -1

-	DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, pacl_list->num);
+	DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__,
+		  pacl_list->num);

It's generally nicer to break the line at the end
of the format sting like:

	DBG_8723A("%s, free acl_node_queue, num =%d\n",
		  __func__, pacl_list->num);

though it'd be even better to convert all of these DBG_8723A uses to pr_debug

$ git ls-files drivers/staging/rtl8723au/ |	\
  xargs sed -r -i				\
	-e 's/\bDBG_8723A\b/pr_debug/g'		\
 	-e 's/\bMSG|8723A\b/pr_debug/g'

Edward Lipinsky

author

2016-03-01 16:54 UTC #2 lore raw

Quoted 20 lines · Joe Perches

Quoted 2 lines · Edward Lipinsky
This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
[]
drivers/staging/rtl8723au/core/rtw_ap.c
Quoted 1 line
drivers/staging/rtl8723au/core/rtw_ap.c +0 -0
[]
drivers/staging/rtl8723au/core/rtw_ap.c void stop_ap_mode23a(struct rtw_adapter *padapter) · line 1838
Quoted 7 lines
drivers/staging/rtl8723au/core/rtw_ap.c +0 -0
@@ -1834,7 +1834,8 @@ void stop_ap_mode23a(struct rtw_adapter *padapter)
  	}
  	spin_unlock_bh(&pacl_node_q->lock);
drivers/staging/rtl8723au/core/rtw_ap.c +2 -1
-	DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, pacl_list->num);
+	DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__,
+		  pacl_list->num);
It's generally nicer to break the line at the end
of the format sting like:
	DBG_8723A("%s, free acl_node_queue, num =%d\n",
		  __func__, pacl_list->num);

Quoted 8 lines

though it'd be even better to convert all of these DBG_8723A uses to pr_debug
$ git ls-files drivers/staging/rtl8723au/ |	\
  xargs sed -r -i				\
	-e 's/\bDBG_8723A\b/pr_debug/g'		\
 	-e 's/\bMSG|8723A\b/pr_debug/g'

Thanks for the feedback. I will submit an updated patch.

Edward Lipinsky

author

2016-03-12 19:46 UTC #3 lore raw

PATCH v2 1/1 staging: rtl8723au: Fix line longer than 80 columns.

In reply to Edward Lipinsky

This patch fixes the checkpatch.pl warning:

WARNING: line over 80 characters

Signed-off-by Edward Lipinsky <[email protected]>

---
Change in v2:
- Break the line after the format string, as suggested by Joe Perches <[email protected]>.

 drivers/staging/rtl8723au/core/rtw_ap.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/staging/rtl8723au/core/rtw_ap.c +2 -1

index ce4b589..67c9d90 100644
@@ -1834,7 +1834,8 @@ void stop_ap_mode23a(struct rtw_adapter *padapter)
 	}
 	spin_unlock_bh(&pacl_node_q->lock);
 
-	DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, pacl_list->num);
+	DBG_8723A("%s, free acl_node_queue, num =%d\n",
+		  __func__, pacl_list->num);
 
 	rtw_sta_flush23a(padapter);

Signature · 1 line

1.7.9.5