Skip to contentSkip to conversation

Staging: slicoss: Use ether_addr_equal_64bits() insted of ether_addr_equal().

PATCH In review Sandhya Bankar 2 participants 2 messages Feb 28, 2016 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 Staging: slicoss: Use ether_addr_equal_64bits() insted of ether_addr_equal().

Use ether_addr_equal_64bits() insted of ether_addr_equal().

---
 drivers/staging/slicoss/slicoss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/slicoss/slicoss.c +2 -2
index ed1c067..b2a162a 100644
@@ -773,8 +773,8 @@ static bool slic_mac_filter(struct adapter *adapter,
 			struct mcast_address *mcaddr = adapter->mcastaddrs;
 
 			while (mcaddr) {
-				if (ether_addr_equal(mcaddr->address,
-						     ether_frame->ether_dhost)) {
+				if (ether_addr_equal_64bits(mcaddr->address,
+						ether_frame->ether_dhost)) {
 					adapter->rcv_multicasts++;
 					netdev->stats.multicast++;
 					return true;
Signature · 1 line
1.8.3.4
#1 lore raw
Quoted 1 line · Sandhya Bankar

Use ether_addr_equal_64bits() insted of ether_addr_equal().

Explain why this is correct and a good idea.

julia

Quoted 31 lines
---
 drivers/staging/slicoss/slicoss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/slicoss/slicoss.c +2 -2
index ed1c067..b2a162a 100644
@@ -773,8 +773,8 @@ static bool slic_mac_filter(struct adapter *adapter,
 			struct mcast_address *mcaddr = adapter->mcastaddrs;
 
 			while (mcaddr) {
-				if (ether_addr_equal(mcaddr->address,
-						     ether_frame->ether_dhost)) {
+				if (ether_addr_equal_64bits(mcaddr->address,
+						ether_frame->ether_dhost)) {
 					adapter->rcv_multicasts++;
 					netdev->stats.multicast++;
 					return true;
Signature · 8 lines
1.8.3.4

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160228114943.GA4709%40sandhya.
For more options, visit https://groups.google.com/d/optout.