Skip to contentSkip to conversation

Staging: rtl8192e: Use ether_addr_equal_64bits() instead of ether_addr_equal().

PATCH In review Sandhya Bankar 2 participants 2 messages Feb 28, 2016 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 Staging: rtl8192e: Use ether_addr_equal_64bits() instead of ether_addr_equal().

Use ether_addr_equal_64bits() instead of ether_addr_equal().

---
 drivers/staging/rtl8192e/rtllib_softmac.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtllib_softmac.c +3 -2
index 25b5b5e..07514e8 100644
@@ -1837,8 +1837,9 @@ static short probe_rq_parse(struct rtllib_device *ieee, struct sk_buff *skb,
 		return -1; /* corrupted */
 
 	bssid_match =
-	  (!ether_addr_equal(header->addr3, ieee->current_network.bssid)) &&
-	  (!is_broadcast_ether_addr(header->addr3));
+	  (!ether_addr_equal_64bits(header->addr3,
+		ieee->current_network.bssid)) &&
+		(!is_broadcast_ether_addr(header->addr3));
 	if (bssid_match)
 		return -1;
 
Signature · 1 line
1.8.3.4
#1 lore raw
Quoted 1 line · Sandhya Bankar

Use ether_addr_equal_64bits() instead of ether_addr_equal().

Again, explain why it is correct and a good idea.

julia

Quoted 32 lines
---
 drivers/staging/rtl8192e/rtllib_softmac.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtllib_softmac.c +3 -2
index 25b5b5e..07514e8 100644
@@ -1837,8 +1837,9 @@ static short probe_rq_parse(struct rtllib_device *ieee, struct sk_buff *skb,
 		return -1; /* corrupted */
 
 	bssid_match =
-	  (!ether_addr_equal(header->addr3, ieee->current_network.bssid)) &&
-	  (!is_broadcast_ether_addr(header->addr3));
+	  (!ether_addr_equal_64bits(header->addr3,
+		ieee->current_network.bssid)) &&
+		(!is_broadcast_ether_addr(header->addr3));
 	if (bssid_match)
 		return -1;
 
Signature · 8 lines
1.8.3.4

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160228115215.GA4726%40sandhya.
For more options, visit https://groups.google.com/d/optout.