Skip to contentSkip to conversation

Remove NULL test before vfree

PATCH Superseded Bhaktipriya Shridhar 2 participants 5 messages Feb 28, 2016

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

cover Remove NULL test before vfree

This patch-set removes NULL tests before vfree.

Bhaktipriya Shridhar (6):
staging: rts5208: Remove NULL test before vfree
staging: rtl8192e: Remove NULL test before vfree
staging: rts5208: Remove NULL Test before vfree
staging: rtl8188eu: core: Remove NULL test before vfree
staging: rtl8188eu: core: Remove NULL Test before vfree
staging: rtl8188eu: os_dep: Remove NULL test before vfree

 drivers/staging/rtl8188eu/core/rtw_recv.c    |  3 +--
 drivers/staging/rtl8188eu/core/rtw_sta_mgt.c |  3 +--
 drivers/staging/rtl8188eu/os_dep/usb_intf.c  |  2 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c |  6 ++---
 drivers/staging/rts5208/ms.c                 | 30 ++++++++---------------
 drivers/staging/rts5208/xd.c                 | 36 ++++++++++------------------
 6 files changed, 27 insertions(+), 53 deletions(-)

--
2.1.4

#1 lore raw
Quoted 8 lines · Bhaktipriya Shridhar

This patch-set removes NULL tests before vfree.

Bhaktipriya Shridhar (6):
staging: rts5208: Remove NULL test before vfree
staging: rtl8192e: Remove NULL test before vfree
staging: rts5208: Remove NULL Test before vfree
staging: rtl8188eu: core: Remove NULL test before vfree
staging: rtl8188eu: core: Remove NULL Test before vfree

I think that turning test into Test is a slightly subtle way of making the subject lines different. It could be better to use a bit more of the path name.

julia

Quoted 20 lines

staging: rtl8188eu: os_dep: Remove NULL test before vfree

 drivers/staging/rtl8188eu/core/rtw_recv.c    |  3 +--
 drivers/staging/rtl8188eu/core/rtw_sta_mgt.c |  3 +--
 drivers/staging/rtl8188eu/os_dep/usb_intf.c  |  2 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c |  6 ++---
 drivers/staging/rts5208/ms.c                 | 30 ++++++++---------------
 drivers/staging/rts5208/xd.c                 | 36 ++++++++++------------------
 6 files changed, 27 insertions(+), 53 deletions(-)

--
2.1.4

Signature · 5 lines
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160228194139.GA1694%40Karyakshetra.
For more options, visit https://groups.google.com/d/optout.
#2 lore raw

Hello Julia,

Well, you caught me there :)
Path names were the same for some patches because the files belonged to the same directory.
Can you suggest a different subject?

Thanks,
Bhaktipriya

Quoted 37 lines · Julia Lawall
Quoted 8 lines · Bhaktipriya Shridhar

This patch-set removes NULL tests before vfree.

Bhaktipriya Shridhar (6):
staging: rts5208: Remove NULL test before vfree
staging: rtl8192e: Remove NULL test before vfree
staging: rts5208: Remove NULL Test before vfree
staging: rtl8188eu: core: Remove NULL test before vfree
staging: rtl8188eu: core: Remove NULL Test before vfree

I think that turning test into Test is a slightly subtle way of making the subject lines different. It could be better to use a bit more of the path name.

julia

Quoted 20 lines

staging: rtl8188eu: os_dep: Remove NULL test before vfree

 drivers/staging/rtl8188eu/core/rtw_recv.c    |  3 +--
 drivers/staging/rtl8188eu/core/rtw_sta_mgt.c |  3 +--
 drivers/staging/rtl8188eu/os_dep/usb_intf.c  |  2 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c |  6 ++---
 drivers/staging/rts5208/ms.c                 | 30 ++++++++---------------
 drivers/staging/rts5208/xd.c                 | 36 ++++++++++------------------
 6 files changed, 27 insertions(+), 53 deletions(-)

--
2.1.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160228194139.GA1694%40Karyakshetra.
For more options, visit https://groups.google.com/d/optout.

#3 lore raw
Quoted 6 lines · Bhaktipriya Shridhar

Hello Julia,

Well, you caught me there :)
Path names were the same for some patches because the files belonged to the same directory.
Can you suggest a different subject?

If need be, you could go down to the file name (without the .c). Or just put the patches for two files together. None of the patches are that big.

julia

Quoted 46 lines

Thanks,
Bhaktipriya

Quoted 37 lines · Julia Lawall
Quoted 8 lines · Bhaktipriya Shridhar

This patch-set removes NULL tests before vfree.

Bhaktipriya Shridhar (6):
staging: rts5208: Remove NULL test before vfree
staging: rtl8192e: Remove NULL test before vfree
staging: rts5208: Remove NULL Test before vfree
staging: rtl8188eu: core: Remove NULL test before vfree
staging: rtl8188eu: core: Remove NULL Test before vfree

I think that turning test into Test is a slightly subtle way of making the subject lines different. It could be better to use a bit more of the path name.

julia

Quoted 20 lines

staging: rtl8188eu: os_dep: Remove NULL test before vfree

 drivers/staging/rtl8188eu/core/rtw_recv.c    |  3 +--
 drivers/staging/rtl8188eu/core/rtw_sta_mgt.c |  3 +--
 drivers/staging/rtl8188eu/os_dep/usb_intf.c  |  2 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c |  6 ++---
 drivers/staging/rts5208/ms.c                 | 30 ++++++++---------------
 drivers/staging/rts5208/xd.c                 | 36 ++++++++++------------------
 6 files changed, 27 insertions(+), 53 deletions(-)

--
2.1.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160228194139.GA1694%40Karyakshetra.
For more options, visit https://groups.google.com/d/optout.

#4 lore raw

Sure. Will send v2 with patches merged.

Thanks,
Bhaktipriya

Quoted 62 lines · Julia Lawall
Quoted 6 lines · Bhaktipriya Shridhar

Hello Julia,

Well, you caught me there :)
Path names were the same for some patches because the files belonged to the same directory.
Can you suggest a different subject?

If need be, you could go down to the file name (without the .c). Or just put the patches for two files together. None of the patches are that big.

julia

Quoted 46 lines

Thanks,
Bhaktipriya

Quoted 37 lines · Julia Lawall
Quoted 8 lines · Bhaktipriya Shridhar

This patch-set removes NULL tests before vfree.

Bhaktipriya Shridhar (6):
staging: rts5208: Remove NULL test before vfree
staging: rtl8192e: Remove NULL test before vfree
staging: rts5208: Remove NULL Test before vfree
staging: rtl8188eu: core: Remove NULL test before vfree
staging: rtl8188eu: core: Remove NULL Test before vfree

I think that turning test into Test is a slightly subtle way of making the subject lines different. It could be better to use a bit more of the path name.

julia

Quoted 20 lines

staging: rtl8188eu: os_dep: Remove NULL test before vfree

 drivers/staging/rtl8188eu/core/rtw_recv.c    |  3 +--
 drivers/staging/rtl8188eu/core/rtw_sta_mgt.c |  3 +--
 drivers/staging/rtl8188eu/os_dep/usb_intf.c  |  2 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c |  6 ++---
 drivers/staging/rts5208/ms.c                 | 30 ++++++++---------------
 drivers/staging/rts5208/xd.c                 | 36 ++++++++++------------------
 6 files changed, 27 insertions(+), 53 deletions(-)

--
2.1.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160228194139.GA1694%40Karyakshetra.
For more options, visit https://groups.google.com/d/optout.