Skip to contentSkip to conversation

ARM64: tegra: Add support for Google Pixel C

PATCH Superseded Jon Hunter 5 participants 9 messages Feb 8, 2016 – Feb 29, 2016

Subsystems (2)
lore
Share & tools
lore

Jon Hunter

author maintainer
#0 lore raw

PATCH v2 1/1 ARM64: tegra: Add support for Google Pixel C

Add initial device-tree support for Google Pixel C (a.k.a. Smaug) based upon Tegra210 SoC with 3 GiB of LPDDR4 RAM.

---
 arch/arm64/boot/dts/nvidia/Makefile           |  1 +
 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 60 +++++++++++++++++++++++++++
 2 files changed, 61 insertions(+)
 create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
arch/arm64/boot/dts/nvidia/Makefile +1 -0
index a7e865da1005..0f7cdf3e05c1 100644
@@ -2,6 +2,7 @@ dtb-$(CONFIG_ARCH_TEGRA_132_SOC) += tegra132-norrin.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-0000.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-2180.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2571.dtb
+dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-smaug.dtb
 
 always		:= $(dtb-y)
 clean-files	:= *.dtb
arch/arm64/boot/dts/nvidia/tegra210-smaug.dts new file +60 -0

60 lines not on this page · raw message

Signature · 1 line
2.1.4
author maintainer
#1 lore raw

PATCH v3 1/1 ARM64: tegra: Add support for Google Pixel C

Add initial device-tree support for Google Pixel C (a.k.a. Smaug) based upon Tegra210 SoC with 3 GiB of LPDDR4 RAM.

---

Changes v2 -> v3:
- Added PSCI information to enable all 4 CPUs on boot

Changes v1 -> v2:
- Removed console boot parameter and added stdout-path
- Added 32k clock for PMC

 arch/arm64/boot/dts/nvidia/Makefile           |  1 +
 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 83 +++++++++++++++++++++++++++
 2 files changed, 84 insertions(+)
 create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
arch/arm64/boot/dts/nvidia/Makefile +1 -0
index a7e865da1005..0f7cdf3e05c1 100644
@@ -2,6 +2,7 @@ dtb-$(CONFIG_ARCH_TEGRA_132_SOC) += tegra132-norrin.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-0000.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-2180.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2571.dtb
+dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-smaug.dtb
 
 always		:= $(dtb-y)
 clean-files	:= *.dtb
arch/arm64/boot/dts/nvidia/tegra210-smaug.dts new file +83 -0

83 lines not on this page · raw message

Signature · 1 line
2.1.4
#2 lore raw

PATCH v3 1/1 ARM64: tegra: Add support for Google Pixel C

Quoted 4 lines · Jon Hunter

Add initial device-tree support for Google Pixel C (a.k.a. Smaug) based upon Tegra210 SoC with 3 GiB of LPDDR4 RAM.

I need to add "clk_ignore_unused=1" to the bootargs in order to avoid a hang during boot, but otherwise can reach a serial console.

author maintainer
#3 lore raw

PATCH v3 1/1 ARM64: tegra: Add support for Google Pixel C

Quoted 8 lines · Alexandre Courbot
Quoted 4 lines · Jon Hunter

Add initial device-tree support for Google Pixel C (a.k.a. Smaug) based upon Tegra210 SoC with 3 GiB of LPDDR4 RAM.

I need to add "clk_ignore_unused=1" to the bootargs in order to avoid a hang during boot, but otherwise can reach a serial console.

Were you testing on -next? If so, you should not need that. Otherwise, please make sure you have this patch [0]. Thierry has included this in a clock fixes series that should turn up in main soon.

Quoted 1 line

Thanks
Jon

[0] https://lkml.org/lkml/2015/12/18/390

#4 lore raw

PATCH v3 1/1 ARM64: tegra: Add support for Google Pixel C

Quoted 6 lines · Jon Hunter
Quoted 4 lines · Alexandre Courbot
Quoted 3 lines · Jon Hunter

Add initial device-tree support for Google Pixel C (a.k.a. Smaug) based upon Tegra210 SoC with 3 GiB of LPDDR4 RAM.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

I need to add "clk_ignore_unused=1" to the bootargs in order to avoid a hang during boot, but otherwise can reach a serial console.

Were you testing on -next? If so, you should not need that. Otherwise, please make sure you have this patch [0]. Thierry has included this in a clock fixes series that should turn up in main soon.

In one of my moments of stupidity, I was on 4.5-rc3. Adding the patch you mention makes boot complete without issues.

Thanks,
Alex.

#5 lore raw

PATCH v3 1/1 ARM64: tegra: Add support for Google Pixel C

In reply to Jon Hunter

Jon,

Quoted 4 lines · Jon Hunter

Add initial device-tree support for Google Pixel C (a.k.a. Smaug) based upon Tegra210 SoC with 3 GiB of LPDDR4 RAM.

Quoted 122 lines

---

Changes v2 -> v3:
- Added PSCI information to enable all 4 CPUs on boot

Changes v1 -> v2:
- Removed console boot parameter and added stdout-path
- Added 32k clock for PMC

 arch/arm64/boot/dts/nvidia/Makefile           |  1 +
 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 83 +++++++++++++++++++++++++++
 2 files changed, 84 insertions(+)
 create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
arch/arm64/boot/dts/nvidia/Makefile +1 -0
index a7e865da1005..0f7cdf3e05c1 100644
@@ -2,6 +2,7 @@ dtb-$(CONFIG_ARCH_TEGRA_132_SOC) += tegra132-norrin.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-0000.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-2180.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2571.dtb
+dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-smaug.dtb
 
 always         := $(dtb-y)
 clean-files    := *.dtb
arch/arm64/boot/dts/nvidia/tegra210-smaug.dts new file +83 -1
new file mode 100644
index 000000000000..750e85c45135
@@ -0,0 +1,83 @@
+/dts-v1/;
+
+#include "tegra210.dtsi"
+
+/ {
+       model = "Google Pixel C";
+       compatible = "google,smaug-rev8", "google,smaug-rev7",
+                    "google,smaug-rev6", "google,smaug-rev5",
+                    "google,smaug-rev4", "google,smaug-rev3",
+                    "google,smaug-rev1", "google,smaug", "nvidia,tegra210";
+
+       aliases {
+               serial0 = &uarta;
+       };
+
+       chosen {
+               bootargs = "earlycon";
+               stdout-path = "serial0:115200n8";
+       };
+
+       memory {
+               device_type = "memory";
+               reg = <0x0 0x80000000 0x0 0xc0000000>;
+       };
+
+       serial at 0,70006000 {
+               status = "okay";
+       };
+
+       pmc at 0,7000e400 {
+               nvidia,invert-interrupt;
+               nvidia,suspend-mode = <0>;
+               nvidia,cpu-pwr-good-time = <0>;
+               nvidia,cpu-pwr-off-time = <0>;
+               nvidia,core-pwr-good-time = <12000 6000>;
+               nvidia,core-pwr-off-time = <39053>;
+               nvidia,core-power-req-active-high;
+               nvidia,sys-clock-req-active-high;
+               status = "okay";
+       };
+
+       sdhci at 0,700b0600 {
+               bus-width = <8>;
+               non-removable;
+               status = "okay";
+       };
+
+       clocks {
+               compatible = "simple-bus";
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               clk32k_in: clock at 0 {
+                       compatible = "fixed-clock";
+                       reg = <0>;
+                       #clock-cells = <0>;
+                       clock-frequency = <32768>;
+               };
+       };
+
+       cpus {
+               cpu at 0 {
+                       enable-method = "psci";
+               };
+
+               cpu at 1 {
+                       enable-method = "psci";
+               };
+
+               cpu at 2 {
+                       enable-method = "psci";
+               };
+
+               cpu at 3 {
+                       enable-method = "psci";
+               };
+       };
+
+       psci {
+               compatible = "arm,psci-1.0";
+               method = "smc";
+       };
+};
--

2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#6 lore raw

PATCH v3 1/1 ARM64: tegra: Add support for Google Pixel C

In reply to Jon Hunter
Quoted 9 lines · Jon Hunter

Add initial device-tree support for Google Pixel C (a.k.a. Smaug) based upon Tegra210 SoC with 3 GiB of LPDDR4 RAM.

---

Changes v2 -> v3:
- Added PSCI information to enable all 4 CPUs on boot

Quoted 8 lines

Changes v1 -> v2:
- Removed console boot parameter and added stdout-path
- Added 32k clock for PMC

 arch/arm64/boot/dts/nvidia/Makefile           |  1 +
 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 83 +++++++++++++++++++++++++++
 2 files changed, 84 insertions(+)
 create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts

Applied, thanks.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160229/5c33bdce/attachment.sig>

#7 lore raw

PATCH v2 1/1 ARM64: tegra: Add support for Google Pixel C

In reply to Jon Hunter

Jon,

Quoted 4 lines · Jon Hunter

Add initial device-tree support for Google Pixel C (a.k.a. Smaug) based upon Tegra210 SoC with 3 GiB of LPDDR4 RAM.

... and I booted up my Smaug with v4.5-rc5 + this patch, so:

Thanks,
Andrew

Quoted 91 lines
---
 arch/arm64/boot/dts/nvidia/Makefile           |  1 +
 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 60 +++++++++++++++++++++++++++
 2 files changed, 61 insertions(+)
 create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
arch/arm64/boot/dts/nvidia/Makefile +1 -0
index a7e865da1005..0f7cdf3e05c1 100644
@@ -2,6 +2,7 @@ dtb-$(CONFIG_ARCH_TEGRA_132_SOC) += tegra132-norrin.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-0000.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-2180.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2571.dtb
+dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-smaug.dtb
 
 always         := $(dtb-y)
 clean-files    := *.dtb
arch/arm64/boot/dts/nvidia/tegra210-smaug.dts new file +60 -1
new file mode 100644
index 000000000000..59acdb6b4f23
@@ -0,0 +1,60 @@
+/dts-v1/;
+
+#include "tegra210.dtsi"
+
+/ {
+       model = "Google Pixel C";
+       compatible = "google,smaug-rev8", "google,smaug-rev7",
+                    "google,smaug-rev6", "google,smaug-rev5",
+                    "google,smaug-rev4", "google,smaug-rev3",
+                    "google,smaug-rev1", "google,smaug", "nvidia,tegra210";
+
+       aliases {
+               serial0 = &uarta;
+       };
+
+       chosen {
+               bootargs = "earlycon";
+               stdout-path = "serial0:115200n8";
+       };
+
+       memory {
+               device_type = "memory";
+               reg = <0x0 0x80000000 0x0 0xc0000000>;
+       };
+
+       serial at 0,70006000 {
+               status = "okay";
+       };
+
+       pmc at 0,7000e400 {
+               nvidia,invert-interrupt;
+               nvidia,suspend-mode = <0>;
+               nvidia,cpu-pwr-good-time = <0>;
+               nvidia,cpu-pwr-off-time = <0>;
+               nvidia,core-pwr-good-time = <12000 6000>;
+               nvidia,core-pwr-off-time = <39053>;
+               nvidia,core-power-req-active-high;
+               nvidia,sys-clock-req-active-high;
+               status = "okay";
+       };
+
+       sdhci at 0,700b0600 {
+               bus-width = <8>;
+               non-removable;
+               status = "okay";
+       };
+
+       clocks {
+               compatible = "simple-bus";
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               clk32k_in: clock at 0 {
+                       compatible = "fixed-clock";
+                       reg = <0>;
+                       #clock-cells = <0>;
+                       clock-frequency = <32768>;
+               };
+       };
+};
--

2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

author maintainer
#8 lore raw

PATCH v2 1/1 ARM64: tegra: Add support for Google Pixel C

Quoted 6 lines · Andrew Bresticker

Jon,

Quoted 3 lines · Jon Hunter

Add initial device-tree support for Google Pixel C (a.k.a. Smaug) based upon Tegra210 SoC with 3 GiB of LPDDR4 RAM.

Quoted 7 lines
Quoted 1 line

... and I booted up my Smaug with v4.5-rc5 + this patch, so:

Thanks. There is a V3 of this patch [0]. The main difference is that it enables all 4 CPUs. Care of test/ack this version?

Cheers
Jon

[0] http://marc.info/?l=linux-arm-kernel&m=145502094332480&w=4